WARNING: The license listed CLOSED was not in the licenses collected for foo

WARNING: The license listed CLOSED was not in the licenses collected for foo

[Steffen Sledz]

Since switching from dizzy to fido we've some warnings related to some of our own closed source packages.

WARNING: log_check: There is a warn message in the logfile
WARNING: log_check: Matched keyword: [WARNING:]
WARNING: log_check: WARNING: The license listed CLOSED was not in the licenses collected for foo

The recipes contain lines like this one:

LICENSE = "CLOSED"

How should we fix the recipe to avoid the warning?

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Paul Eggleton]

Hi Steffen,

On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
> Since switching from dizzy to fido we've some warnings related to some of
> our own closed source packages.
> 
> WARNING: log_check: There is a warn message in the logfile
> WARNING: log_check: Matched keyword: [WARNING:]
> WARNING: log_check: WARNING: The license listed CLOSED was not in the
> licenses collected for foo
> 
> The recipes contain lines like this one:
> 
> LICENSE = "CLOSED"
> 
> How should we fix the recipe to avoid the warning?

I think the part of the code that produces this warning probably should be 
ignoring the CLOSED value. Can I ask you to please file a bug? Feel free to add 
me on CC.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Otavio Salvador]

On Fri, May 8, 2015 at 9:39 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
>> Since switching from dizzy to fido we've some warnings related to some of
>> our own closed source packages.
>>
>> WARNING: log_check: There is a warn message in the logfile
>> WARNING: log_check: Matched keyword: [WARNING:]
>> WARNING: log_check: WARNING: The license listed CLOSED was not in the
>> licenses collected for foo
>>
>> The recipes contain lines like this one:
>>
>> LICENSE = "CLOSED"
>>
>> How should we fix the recipe to avoid the warning?
>
> I think the part of the code that produces this warning probably should be
> ignoring the CLOSED value. Can I ask you to please file a bug? Feel free to add
> me on CC.

You can use proprietary.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Paul Eggleton]

On Friday 08 May 2015 09:40:48 Otavio Salvador wrote:
> On Fri, May 8, 2015 at 9:39 AM, Paul Eggleton
> 
> <paul.eggleton@linux.intel.com> wrote:
> > On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
> >> Since switching from dizzy to fido we've some warnings related to some of
> >> our own closed source packages.
> >> 
> >> WARNING: log_check: There is a warn message in the logfile
> >> WARNING: log_check: Matched keyword: [WARNING:]
> >> WARNING: log_check: WARNING: The license listed CLOSED was not in the
> >> licenses collected for foo
> >> 
> >> The recipes contain lines like this one:
> >> 
> >> LICENSE = "CLOSED"
> >> 
> >> How should we fix the recipe to avoid the warning?
> > 
> > I think the part of the code that produces this warning probably should be
> > ignoring the CLOSED value. Can I ask you to please file a bug? Feel free
> > to add me on CC.
> 
> You can use proprietary.

If you mean "Proprietary", yes there is a common license file for that but then 
I believe you will get an error if LIC_FILES_CHKSUM is not set in the recipe.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Mike Looijmans]

What is one expected to do when one justs wants to add the missing license to 
the "licenses collected for ..."?

I'm a bit spoiled now, most OE messages explain what it expects me to do to 
fix the problem.

M.

On 08-05-15 14:39, Paul Eggleton wrote:
> Hi Steffen,
>
> On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
>> Since switching from dizzy to fido we've some warnings related to some of
>> our own closed source packages.
>>
>> WARNING: log_check: There is a warn message in the logfile
>> WARNING: log_check: Matched keyword: [WARNING:]
>> WARNING: log_check: WARNING: The license listed CLOSED was not in the
>> licenses collected for foo
>>
>> The recipes contain lines like this one:
>>
>> LICENSE = "CLOSED"
>>
>> How should we fix the recipe to avoid the warning?
>
> I think the part of the code that produces this warning probably should be
> ignoring the CLOSED value. Can I ask you to please file a bug? Feel free to add
> me on CC.
>
> Cheers,
> Paul
>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Mike Looijmans]

Hmm, I cannot figure it out... I have in a recipe:

LICENSE = "internal"
LIC_FILES_CHKSUM = "file://LICENSE;md5=cf85de037de7ae12cc2d0059741fdbae"

Then in my layer.conf:

LICENSE_PATH += "${LAYERDIR}/licenses"

I have a file called "internal" in that path. Still, I get:

WARNING: log_check: WARNING: The license listed internal was not in the 
licenses collected for ...

What am I missing still then? What does the warning mean? I thought I got 
everything right, but either the licensing rules have changed or I never got 
it right in the first place and a check was added to make me aware of that.

On 11-05-15 08:54, Mike Looijmans wrote:
> What is one expected to do when one justs wants to add the missing license to
> the "licenses collected for ..."?
>
> I'm a bit spoiled now, most OE messages explain what it expects me to do to
> fix the problem.



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Paul Eggleton]

At a guess, maybe do_populate_lic didn't re-execute for this recipe. Does it 
still happen if you bitbake -c cleansstate the recipe and try again?

Cheers,
Paul

On Monday 11 May 2015 10:58:07 Mike Looijmans wrote:
> Hmm, I cannot figure it out... I have in a recipe:
> 
> LICENSE = "internal"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=cf85de037de7ae12cc2d0059741fdbae"
> 
> Then in my layer.conf:
> 
> LICENSE_PATH += "${LAYERDIR}/licenses"
> 
> I have a file called "internal" in that path. Still, I get:
> 
> WARNING: log_check: WARNING: The license listed internal was not in the
> licenses collected for ...
> 
> What am I missing still then? What does the warning mean? I thought I got
> everything right, but either the licensing rules have changed or I never got
> it right in the first place and a check was added to make me aware of that.
> On 11-05-15 08:54, Mike Looijmans wrote:
> > What is one expected to do when one justs wants to add the missing license
> > to the "licenses collected for ..."?
> > 
> > I'm a bit spoiled now, most OE messages explain what it expects me to do
> > to
> > fix the problem.
> 
> Kind regards,
> 
> Mike Looijmans
> System Expert
> 
> TOPIC Embedded Products
> Eindhovenseweg 32-C, NL-5683 KH Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> Telefax: +31 (0) 499 33 69 70
> E-mail: mike.looijmans@topicproducts.com
> Website: www.topicproducts.com
> 
> Please consider the environment before printing this e-mail

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Mike Looijmans]

On 11-05-15 11:36, Paul Eggleton wrote:
> At a guess, maybe do_populate_lic didn't re-execute for this recipe. Does it
> still happen if you bitbake -c cleansstate the recipe and try again?

Yes, it even complains about this on a completely fresh build.

>
> Cheers,
> Paul
>
> On Monday 11 May 2015 10:58:07 Mike Looijmans wrote:
>> Hmm, I cannot figure it out... I have in a recipe:
>>
>> LICENSE = "internal"
>> LIC_FILES_CHKSUM = "file://LICENSE;md5=cf85de037de7ae12cc2d0059741fdbae"
>>
>> Then in my layer.conf:
>>
>> LICENSE_PATH += "${LAYERDIR}/licenses"
>>
>> I have a file called "internal" in that path. Still, I get:
>>
>> WARNING: log_check: WARNING: The license listed internal was not in the
>> licenses collected for ...
>>
>> What am I missing still then? What does the warning mean? I thought I got
>> everything right, but either the licensing rules have changed or I never got
>> it right in the first place and a check was added to make me aware of that.
>> On 11-05-15 08:54, Mike Looijmans wrote:
>>> What is one expected to do when one justs wants to add the missing license
>>> to the "licenses collected for ..."?
>>>
>>> I'm a bit spoiled now, most OE messages explain what it expects me to do
>>> to
>>> fix the problem.
>>
>> Kind regards,
>>
>> Mike Looijmans
>> System Expert
>>
>> TOPIC Embedded Products
>> Eindhovenseweg 32-C, NL-5683 KH Best
>> Postbus 440, NL-5680 AK Best
>> Telefoon: +31 (0) 499 33 69 79
>> Telefax: +31 (0) 499 33 69 70
>> E-mail: mike.looijmans@topicproducts.com
>> Website: www.topicproducts.com
>>
>> Please consider the environment before printing this e-mail
>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Paul Eggleton]

Hi Mike,

If you want to do this you need to add a generic license file for the license 
in question, which means extending LICENSE_PATH in your custom layer to a 
directory containing a file named with the license. (However, for "CLOSED" this 
would not be the right course because "CLOSED" doesn't specify one particular 
license, hence my comment about this being a bug.)

You're right that the error message isn't as helpful as it could be. We should 
fix that as well.

Cheers,
Paul

On Monday 11 May 2015 08:54:25 Mike Looijmans wrote:
> What is one expected to do when one justs wants to add the missing license
> to the "licenses collected for ..."?
> 
> I'm a bit spoiled now, most OE messages explain what it expects me to do to
> fix the problem.
> 
> M.
> 
> On 08-05-15 14:39, Paul Eggleton wrote:
> > Hi Steffen,
> > 
> > On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
> >> Since switching from dizzy to fido we've some warnings related to some of
> >> our own closed source packages.
> >> 
> >> WARNING: log_check: There is a warn message in the logfile
> >> WARNING: log_check: Matched keyword: [WARNING:]
> >> WARNING: log_check: WARNING: The license listed CLOSED was not in the
> >> licenses collected for foo
> >> 
> >> The recipes contain lines like this one:
> >> 
> >> LICENSE = "CLOSED"
> >> 
> >> How should we fix the recipe to avoid the warning?
> > 
> > I think the part of the code that produces this warning probably should be
> > ignoring the CLOSED value. Can I ask you to please file a bug? Feel free
> > to add me on CC.
> > 
> > Cheers,
> > Paul
> 
> Kind regards,
> 
> Mike Looijmans
> System Expert
> 
> TOPIC Embedded Products
> Eindhovenseweg 32-C, NL-5683 KH Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> Telefax: +31 (0) 499 33 69 70
> E-mail: mike.looijmans@topicproducts.com
> Website: www.topicproducts.com
> 
> Please consider the environment before printing this e-mail

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Mike Looijmans]

On 11-05-15 11:09, Paul Eggleton wrote:
> If you want to do this you need to add a generic license file for the license
> in question, which means extending LICENSE_PATH in your custom layer to a
> directory containing a file named with the license.

I did that, but it didn't get rid of the warning message (see previous post).

> You're right that the error message isn't as helpful as it could be. We should
> fix that as well.

Well if I knew what to do myself, I could provide a patch for that...



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Re: WARNING: The license listed CLOSED was not in the licenses collected for foo

[Steffen Sledz]

On 08.05.2015 14:39, Paul Eggleton wrote:
> Hi Steffen,
> 
> On Friday 08 May 2015 13:07:35 Steffen Sledz wrote:
>> Since switching from dizzy to fido we've some warnings related to some of
>> our own closed source packages.
>>
>> WARNING: log_check: There is a warn message in the logfile
>> WARNING: log_check: Matched keyword: [WARNING:]
>> WARNING: log_check: WARNING: The license listed CLOSED was not in the
>> licenses collected for foo
>>
>> The recipes contain lines like this one:
>>
>> LICENSE = "CLOSED"
>>
>> How should we fix the recipe to avoid the warning?
> 
> I think the part of the code that produces this warning probably should be 
> ignoring the CLOSED value. Can I ask you to please file a bug? Feel free to add 
> me on CC.

https://bugzilla.yoctoproject.org/show_bug.cgi?id=7752

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058