* [PATCH] busybox/mdev: Ensure /sys is mounted before using it
@ 2016-04-07 7:02 Khem Raj
2016-04-07 9:50 ` Burton, Ross
2016-04-07 17:34 ` Andreas Oberritter
0 siblings, 2 replies; 8+ messages in thread
From: Khem Raj @ 2016-04-07 7:02 UTC (permalink / raw)
To: openembedded-core
echo would fail if /sys is not mounted and boot would abort
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-core/busybox/files/mdev | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/busybox/files/mdev b/meta/recipes-core/busybox/files/mdev
index 9625247..8c9c06e 100755
--- a/meta/recipes-core/busybox/files/mdev
+++ b/meta/recipes-core/busybox/files/mdev
@@ -1,10 +1,12 @@
#!/bin/sh
-
+mount -t proc proc /proc
+mount -t sysfs sysfs /sys
mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
mkdir /dev/pts /dev/shm
chmod 777 /dev/shm
mount -t devpts devpts /dev/pts
touch /dev/mdev.seq
+#sysctl -w kernel.hotplug=/sbin/mdev
echo "/sbin/mdev" > /proc/sys/kernel/hotplug
mdev -s
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 7:02 [PATCH] busybox/mdev: Ensure /sys is mounted before using it Khem Raj
@ 2016-04-07 9:50 ` Burton, Ross
2016-04-07 14:21 ` Khem Raj
2016-04-07 17:34 ` Andreas Oberritter
1 sibling, 1 reply; 8+ messages in thread
From: Burton, Ross @ 2016-04-07 9:50 UTC (permalink / raw)
To: Khem Raj; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
On 7 April 2016 at 08:02, Khem Raj <raj.khem@gmail.com> wrote:
> +#sysctl -w kernel.hotplug=/sbin/mdev
>
Why add a commented line?
Ross
[-- Attachment #2: Type: text/html, Size: 552 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 9:50 ` Burton, Ross
@ 2016-04-07 14:21 ` Khem Raj
0 siblings, 0 replies; 8+ messages in thread
From: Khem Raj @ 2016-04-07 14:21 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Thu, Apr 7, 2016 at 2:50 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 7 April 2016 at 08:02, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> +#sysctl -w kernel.hotplug=/sbin/mdev
>
>
> Why add a commented line?
this is an alternative way to insert mdev to be hotplug when sysfs is
not mounted.
>
> Ross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 7:02 [PATCH] busybox/mdev: Ensure /sys is mounted before using it Khem Raj
2016-04-07 9:50 ` Burton, Ross
@ 2016-04-07 17:34 ` Andreas Oberritter
2016-04-07 19:01 ` Khem Raj
1 sibling, 1 reply; 8+ messages in thread
From: Andreas Oberritter @ 2016-04-07 17:34 UTC (permalink / raw)
To: openembedded-core
Hi Khem,
On 07.04.2016 09:02, Khem Raj wrote:
> echo would fail if /sys is not mounted and boot would abort
are you sure about the dependency between echo and sysfs? It seems quite
unlikely to me. I'd guess the real problem is mdev failing to start
without sysfs.
Regards,
Andreas
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-core/busybox/files/mdev | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/busybox/files/mdev b/meta/recipes-core/busybox/files/mdev
> index 9625247..8c9c06e 100755
> --- a/meta/recipes-core/busybox/files/mdev
> +++ b/meta/recipes-core/busybox/files/mdev
> @@ -1,10 +1,12 @@
> #!/bin/sh
> -
> +mount -t proc proc /proc
> +mount -t sysfs sysfs /sys
> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
> mkdir /dev/pts /dev/shm
> chmod 777 /dev/shm
> mount -t devpts devpts /dev/pts
> touch /dev/mdev.seq
> +#sysctl -w kernel.hotplug=/sbin/mdev
> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
> mdev -s
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 17:34 ` Andreas Oberritter
@ 2016-04-07 19:01 ` Khem Raj
2016-04-07 23:46 ` Andreas Oberritter
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2016-04-07 19:01 UTC (permalink / raw)
To: Andreas Oberritter; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]
> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter <obi@opendreambox.org> wrote:
>
> Hi Khem,
>
> On 07.04.2016 09:02, Khem Raj wrote:
>> echo would fail if /sys is not mounted and boot would abort
>
> are you sure about the dependency between echo and sysfs? It seems quite
> unlikely to me. I'd guess the real problem is mdev failing to start
> without syses.
real problem was missing mounting sysfs on /sys, but I wanted to keep the other
way of setting it instead of echo
>
> Regards,
> Andreas
>
>
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-core/busybox/files/mdev | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/busybox/files/mdev b/meta/recipes-core/busybox/files/mdev
>> index 9625247..8c9c06e 100755
>> --- a/meta/recipes-core/busybox/files/mdev
>> +++ b/meta/recipes-core/busybox/files/mdev
>> @@ -1,10 +1,12 @@
>> #!/bin/sh
>> -
>> +mount -t proc proc /proc
>> +mount -t sysfs sysfs /sys
>> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
>> mkdir /dev/pts /dev/shm
>> chmod 777 /dev/shm
>> mount -t devpts devpts /dev/pts
>> touch /dev/mdev.seq
>> +#sysctl -w kernel.hotplug=/sbin/mdev
>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
>> mdev -s
>>
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 19:01 ` Khem Raj
@ 2016-04-07 23:46 ` Andreas Oberritter
2016-04-08 1:10 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Andreas Oberritter @ 2016-04-07 23:46 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On 07.04.2016 21:01, Khem Raj wrote:
>
>> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter <obi@opendreambox.org> wrote:
>>
>> Hi Khem,
>>
>> On 07.04.2016 09:02, Khem Raj wrote:
>>> echo would fail if /sys is not mounted and boot would abort
>>
>> are you sure about the dependency between echo and sysfs? It seems quite
>> unlikely to me. I'd guess the real problem is mdev failing to start
>> without syses.
>
> real problem was missing mounting sysfs on /sys, but I wanted to keep the other
> way of setting it instead of echo
Note that I was referring to your commit message.
After a second look I see that you also mount /proc in your patch, and I
guess that's what you meant to describe. Please update the commit
message (and subject) to actually match your patch.
Regards,
Andreas
>
>>
>> Regards,
>> Andreas
>>
>>
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> meta/recipes-core/busybox/files/mdev | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/busybox/files/mdev b/meta/recipes-core/busybox/files/mdev
>>> index 9625247..8c9c06e 100755
>>> --- a/meta/recipes-core/busybox/files/mdev
>>> +++ b/meta/recipes-core/busybox/files/mdev
>>> @@ -1,10 +1,12 @@
>>> #!/bin/sh
>>> -
>>> +mount -t proc proc /proc
>>> +mount -t sysfs sysfs /sys
>>> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
>>> mkdir /dev/pts /dev/shm
>>> chmod 777 /dev/shm
>>> mount -t devpts devpts /dev/pts
>>> touch /dev/mdev.seq
>>> +#sysctl -w kernel.hotplug=/sbin/mdev
>>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
>>> mdev -s
>>>
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-07 23:46 ` Andreas Oberritter
@ 2016-04-08 1:10 ` Khem Raj
2016-04-08 1:25 ` Andreas Oberritter
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2016-04-08 1:10 UTC (permalink / raw)
To: Andreas Oberritter; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]
On Apr 7, 2016 4:46 PM, "Andreas Oberritter" <obi@opendreambox.org> wrote:
>
> On 07.04.2016 21:01, Khem Raj wrote:
> >
> >> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter <obi@opendreambox.org>
wrote:
> >>
> >> Hi Khem,
> >>
> >> On 07.04.2016 09:02, Khem Raj wrote:
> >>> echo would fail if /sys is not mounted and boot would abort
> >>
> >> are you sure about the dependency between echo and sysfs? It seems
quite
> >> unlikely to me. I'd guess the real problem is mdev failing to start
> >> without syses.
> >
> > real problem was missing mounting sysfs on /sys, but I wanted to keep
the other
> > way of setting it instead of echo
>
> Note that I was referring to your commit message.
>
> After a second look I see that you also mount /proc in your patch, and I
> guess that's what you meant to describe. Please update the commit
> message (and subject) to actually match your patch.
Whata not clear in patch subject
>
> Regards,
> Andreas
>
>
> >
> >>
> >> Regards,
> >> Andreas
> >>
> >>
> >>>
> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>> ---
> >>> meta/recipes-core/busybox/files/mdev | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta/recipes-core/busybox/files/mdev
b/meta/recipes-core/busybox/files/mdev
> >>> index 9625247..8c9c06e 100755
> >>> --- a/meta/recipes-core/busybox/files/mdev
> >>> +++ b/meta/recipes-core/busybox/files/mdev
> >>> @@ -1,10 +1,12 @@
> >>> #!/bin/sh
> >>> -
> >>> +mount -t proc proc /proc
> >>> +mount -t sysfs sysfs /sys
> >>> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
> >>> mkdir /dev/pts /dev/shm
> >>> chmod 777 /dev/shm
> >>> mount -t devpts devpts /dev/pts
> >>> touch /dev/mdev.seq
> >>> +#sysctl -w kernel.hotplug=/sbin/mdev
> >>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
> >>> mdev -s
> >>>
> >>>
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>
[-- Attachment #2: Type: text/html, Size: 3298 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
2016-04-08 1:10 ` Khem Raj
@ 2016-04-08 1:25 ` Andreas Oberritter
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Oberritter @ 2016-04-08 1:25 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 08.04.2016 03:10, Khem Raj wrote:
>
> On Apr 7, 2016 4:46 PM, "Andreas Oberritter" <obi@opendreambox.org
> <mailto:obi@opendreambox.org>> wrote:
>>
>> On 07.04.2016 21:01, Khem Raj wrote:
>> >
>> >> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter
> <obi@opendreambox.org <mailto:obi@opendreambox.org>> wrote:
>> >>
>> >> Hi Khem,
>> >>
>> >> On 07.04.2016 09:02, Khem Raj wrote:
>> >>> echo would fail if /sys is not mounted and boot would abort
>> >>
>> >> are you sure about the dependency between echo and sysfs? It seems
> quite
>> >> unlikely to me. I'd guess the real problem is mdev failing to start
>> >> without syses.
>> >
>> > real problem was missing mounting sysfs on /sys, but I wanted to
> keep the other
>> > way of setting it instead of echo
>>
>> Note that I was referring to your commit message.
>>
>> After a second look I see that you also mount /proc in your patch, and I
>> guess that's what you meant to describe. Please update the commit
>> message (and subject) to actually match your patch.
>
> Whata not clear in patch subject
It doesn't mention /proc.
>>
>> Regards,
>> Andreas
>>
>>
>> >
>> >>
>> >> Regards,
>> >> Andreas
>> >>
>> >>
>> >>>
>> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>>
>> >>> ---
>> >>> meta/recipes-core/busybox/files/mdev | 4 +++-
>> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> >>>
>> >>> diff --git a/meta/recipes-core/busybox/files/mdev
> b/meta/recipes-core/busybox/files/mdev
>> >>> index 9625247..8c9c06e 100755
>> >>> --- a/meta/recipes-core/busybox/files/mdev
>> >>> +++ b/meta/recipes-core/busybox/files/mdev
>> >>> @@ -1,10 +1,12 @@
>> >>> #!/bin/sh
>> >>> -
>> >>> +mount -t proc proc /proc
>> >>> +mount -t sysfs sysfs /sys
>> >>> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755
>> >>> mkdir /dev/pts /dev/shm
>> >>> chmod 777 /dev/shm
>> >>> mount -t devpts devpts /dev/pts
>> >>> touch /dev/mdev.seq
>> >>> +#sysctl -w kernel.hotplug=/sbin/mdev
>> >>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
>> >>> mdev -s
>> >>>
>> >>>
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-08 1:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-07 7:02 [PATCH] busybox/mdev: Ensure /sys is mounted before using it Khem Raj
2016-04-07 9:50 ` Burton, Ross
2016-04-07 14:21 ` Khem Raj
2016-04-07 17:34 ` Andreas Oberritter
2016-04-07 19:01 ` Khem Raj
2016-04-07 23:46 ` Andreas Oberritter
2016-04-08 1:10 ` Khem Raj
2016-04-08 1:25 ` Andreas Oberritter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox