[PATCH 0/1] coreutils: correct the case for class-native

[PATCH 0/1] coreutils: correct the case for class-native

[Dengke Du]

The following changes since commit f4f1d206f4ebafcde18c96c88a1bfc4ab7b0c119:

  scripts/lib/bsp/help.py: Typo in help for yocto-bsp create (2016-04-05 14:33:58 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib dengke/correct_the_case_for_class-native
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=dengke/correct_the_case_for_class-native

Dengke Du (1):
  coreutils: correct the case for class-native

 meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
 1 file changed, 4 insertions(+)

-- 
1.9.1

[PATCH 1/1] coreutils: correct the case for class-native

[Dengke Du]

The function of do_install_append_class-native for class-native
had alread exist,so exclude the class-native in function
do_install_append.

Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
 meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb b/meta/recipes-core/coreutils/coreutils_8.25.bb
index 419a693..e8e269a 100644
--- a/meta/recipes-core/coreutils/coreutils_8.25.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
@@ -70,6 +70,10 @@ do_compile_prepend () {
 }
 
 do_install_append() {
+	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
+		return
+	fi
+
 	for i in df mktemp base64; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${BPN}; done
 
 	install -d ${D}${base_bindir}
-- 
1.9.1

Re: [PATCH 1/1] coreutils: correct the case for class-native

[dengke.du]

Sorry, my email has some problem that it send twice. I will fix it as 
soon as.

//dengke

On 2016年04月06日 12:45, Dengke Du wrote:
> The function of do_install_append_class-native for class-native
> had alread exist,so exclude the class-native in function
> do_install_append.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
>   meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb b/meta/recipes-core/coreutils/coreutils_8.25.bb
> index 419a693..e8e269a 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
> @@ -70,6 +70,10 @@ do_compile_prepend () {
>   }
>   
>   do_install_append() {
> +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
> +		return
> +	fi
> +
>   	for i in df mktemp base64; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${BPN}; done
>   
>   	install -d ${D}${base_bindir}

Re: [PATCH 1/1] coreutils: correct the case for class-native

[Robert Yang]

On 04/06/2016 12:45 PM, Dengke Du wrote:
> The function of do_install_append_class-native for class-native
> had alread exist,so exclude the class-native in function
> do_install_append.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
>   meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb b/meta/recipes-core/coreutils/coreutils_8.25.bb
> index 419a693..e8e269a 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
> @@ -70,6 +70,10 @@ do_compile_prepend () {
>   }
>
>   do_install_append() {
> +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
> +		return
> +	fi
> +

We need this patch, otherwise the tools provided by coreutils-native
are broken, for example, "ln" is "ln.coreutils" in native sysroot,
which can't be used by default.

This patch can fix the problem.

// Robert

>   	for i in df mktemp base64; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${BPN}; done
>
>   	install -d ${D}${base_bindir}
>

Re: [PATCH 1/1] coreutils: correct the case for class-native

[Joshua G Lock]

On Wed, 2016-04-06 at 12:50 +0800, Robert Yang wrote:
> 
> On 04/06/2016 12:45 PM, Dengke Du wrote:
> > 
> > The function of do_install_append_class-native for class-native
> > had alread exist,so exclude the class-native in function
> > do_install_append.
> > 
> > Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > ---
> >   meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb
> > b/meta/recipes-core/coreutils/coreutils_8.25.bb
> > index 419a693..e8e269a 100644
> > --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
> > +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
> > @@ -70,6 +70,10 @@ do_compile_prepend () {
> >   }
> > 
> >   do_install_append() {
> > +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
> > +		return
> > +	fi
> > +

If the do_install_append is only valid for the target it'd be cleaner
to use a target-specific override i.e.

do_install_append_class-target () {
}

Thanks,

Joshua

Re: [PATCH 1/1] coreutils: correct the case for class-native

[Robert Yang]

On 04/06/2016 04:42 PM, Joshua G Lock wrote:
> On Wed, 2016-04-06 at 12:50 +0800, Robert Yang wrote:
>>
>> On 04/06/2016 12:45 PM, Dengke Du wrote:
>>>
>>> The function of do_install_append_class-native for class-native
>>> had alread exist,so exclude the class-native in function
>>> do_install_append.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>>    meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> index 419a693..e8e269a 100644
>>> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> @@ -70,6 +70,10 @@ do_compile_prepend () {
>>>    }
>>>
>>>    do_install_append() {
>>> +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
>>> +		return
>>> +	fi
>>> +
>
> If the do_install_append is only valid for the target it'd be cleaner
> to use a target-specific override i.e.

Thanks, but it is needed by both target and nativesdk.

// Robert

>
> do_install_append_class-target () {
> }
>
> Thanks,
>
> Joshua
>

Re: [PATCH 1/1] coreutils: correct the case for class-native

[dengke.du]

But the nativesdk also need the do_install_append function to
slove the many warnings.

//dengke

On 2016年04月06日 16:42, Joshua G Lock wrote:
> On Wed, 2016-04-06 at 12:50 +0800, Robert Yang wrote:
>> On 04/06/2016 12:45 PM, Dengke Du wrote:
>>> The function of do_install_append_class-native for class-native
>>> had alread exist,so exclude the class-native in function
>>> do_install_append.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>>    meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> index 419a693..e8e269a 100644
>>> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> @@ -70,6 +70,10 @@ do_compile_prepend () {
>>>    }
>>>
>>>    do_install_append() {
>>> +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
>>> +		return
>>> +	fi
>>> +
> If the do_install_append is only valid for the target it'd be cleaner
> to use a target-specific override i.e.
>
> do_install_append_class-target () {
> }
>
> Thanks,
>
> Joshua