* [PATCH 0/1] A kernel recipe fix for meta-skeleton layer
@ 2014-04-11 17:05 nitin.a.kamble
2014-04-11 17:05 ` [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides nitin.a.kamble
0 siblings, 1 reply; 9+ messages in thread
From: nitin.a.kamble @ 2014-04-11 17:05 UTC (permalink / raw)
To: Openembedded-core, bruce.ashfield, darren.hart, richard.purdie
From: Nitin A Kamble <nitin.a.kamble@intel.com>
The kernel variables in kernel bbappend recipes such as LINUX_VERSION should
always use machine overrides to unintentionally influencing kernel variables
in other layers. Adding missing overrides to the kernel recipe in the
meta-skeleton layer, so people who use it to make their own recipes, start
the right way.
Thanks,
Nitin
The following changes since commit 863cc7483f5ee43189537940de8ee5c0964d24cc:
poky.conf: Post release version bump (2014-04-10 18:03:07 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib nitin/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Nitin A Kamble (1):
meta-skeleton: linux-yocto-custom.bb: use machine overrides
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-11 17:05 [PATCH 0/1] A kernel recipe fix for meta-skeleton layer nitin.a.kamble
@ 2014-04-11 17:05 ` nitin.a.kamble
2014-04-11 17:18 ` Hart, Darren
2014-04-11 17:48 ` Bruce Ashfield
0 siblings, 2 replies; 9+ messages in thread
From: nitin.a.kamble @ 2014-04-11 17:05 UTC (permalink / raw)
To: Openembedded-core, bruce.ashfield, darren.hart, richard.purdie
From: Nitin A Kamble <nitin.a.kamble@intel.com>
Use machine overrides for variables for this skeleton recipe so that
people following skeleton do it right at the beginning.
The machine overrides for the variables reduces pollution of name space
and avoid unintentional influences on other layers.
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
index c329106..76457ca 100644
--- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
+++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
@@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
# Override SRC_URI in a bbappend file to point at a different source
# tree if you do not want to build from Linus' tree.
-SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
+SRC_URI_machine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
-LINUX_VERSION ?= "3.4"
-LINUX_VERSION_EXTENSION ?= "-custom"
+LINUX_VERSION_machine ?= "3.4"
+LINUX_VERSION_EXTENSION_machine ?= "-custom"
# Override SRCREV to point to a different commit in a bbappend file to
# build a different release of the Linux kernel.
@@ -61,4 +61,4 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
# Override COMPATIBLE_MACHINE to include your machine in a bbappend
# file. Leaving it empty here ensures an early explicit build failure.
-COMPATIBLE_MACHINE = "(^$)"
+COMPATIBLE_MACHINE_machine = "(^$)"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-11 17:05 ` [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides nitin.a.kamble
@ 2014-04-11 17:18 ` Hart, Darren
2014-04-11 17:48 ` Bruce Ashfield
1 sibling, 0 replies; 9+ messages in thread
From: Hart, Darren @ 2014-04-11 17:18 UTC (permalink / raw)
To: Kamble, Nitin A, Openembedded-core@lists.openembedded.org,
Ashfield, Bruce (Wind River), richard.purdie@linuxfoundation.org
On 4/11/14, 10:05, "Kamble, Nitin A" <nitin.a.kamble@intel.com> wrote:
>From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
>Use machine overrides for variables for this skeleton recipe so that
>people following skeleton do it right at the beginning.
>
>The machine overrides for the variables reduces pollution of name space
>and avoid unintentional influences on other layers.
>
>Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>---
> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>index c329106..76457ca 100644
>--- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>+++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>@@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
>
> # Override SRC_URI in a bbappend file to point at a different source
> # tree if you do not want to build from Linus' tree.
>-SRC_URI =
>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol
>=git;nocheckout=1;name=machine"
>+SRC_URI_machine =
>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol
>=git;nocheckout=1;name=machine"
>
>-LINUX_VERSION ?= "3.4"
>-LINUX_VERSION_EXTENSION ?= "-custom"
>+LINUX_VERSION_machine ?= "3.4"
>+LINUX_VERSION_EXTENSION_machine ?= "-custom"
>
> # Override SRCREV to point to a different commit in a bbappend file to
> # build a different release of the Linux kernel.
>@@ -61,4 +61,4 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
>
> # Override COMPATIBLE_MACHINE to include your machine in a bbappend
> # file. Leaving it empty here ensures an early explicit build failure.
>-COMPATIBLE_MACHINE = "(^$)"
>+COMPATIBLE_MACHINE_machine = "(^$)"
Might as well change this to:
COMPATIBLE_MACHINE_machine = "machine"
And then add a comment at the top to remind people to replace "machine"
with their BSP name.
--
Darren Hart Open Source Technology Center
darren.hart@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-11 17:05 ` [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides nitin.a.kamble
2014-04-11 17:18 ` Hart, Darren
@ 2014-04-11 17:48 ` Bruce Ashfield
2014-04-11 17:53 ` Kamble, Nitin A
1 sibling, 1 reply; 9+ messages in thread
From: Bruce Ashfield @ 2014-04-11 17:48 UTC (permalink / raw)
To: nitin.a.kamble, Openembedded-core, darren.hart, richard.purdie
On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> Use machine overrides for variables for this skeleton recipe so that
> people following skeleton do it right at the beginning.
>
> The machine overrides for the variables reduces pollution of name space
> and avoid unintentional influences on other layers.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> index c329106..76457ca 100644
> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
>
> # Override SRC_URI in a bbappend file to point at a different source
> # tree if you do not want to build from Linus' tree.
> -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
> +SRC_URI_machine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
>
> -LINUX_VERSION ?= "3.4"
> -LINUX_VERSION_EXTENSION ?= "-custom"
> +LINUX_VERSION_machine ?= "3.4"
> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
For some reason, I thought you meant ${MACHINE} instead of _machine .. which
is what I use for machine specific overrides.
But assuming this works, i have no objections.
Bruce
>
> # Override SRCREV to point to a different commit in a bbappend file to
> # build a different release of the Linux kernel.
> @@ -61,4 +61,4 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
>
> # Override COMPATIBLE_MACHINE to include your machine in a bbappend
> # file. Leaving it empty here ensures an early explicit build failure.
> -COMPATIBLE_MACHINE = "(^$)"
> +COMPATIBLE_MACHINE_machine = "(^$)"
>
z
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-11 17:48 ` Bruce Ashfield
@ 2014-04-11 17:53 ` Kamble, Nitin A
2014-04-15 16:54 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Kamble, Nitin A @ 2014-04-11 17:53 UTC (permalink / raw)
To: Bruce Ashfield, Openembedded-core, darren.hart, richard.purdie
On 4/11/2014 10:48 AM, Bruce Ashfield wrote:
> On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>
>> Use machine overrides for variables for this skeleton recipe so that
>> people following skeleton do it right at the beginning.
>>
>> The machine overrides for the variables reduces pollution of name space
>> and avoid unintentional influences on other layers.
>>
>> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> ---
>> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> index c329106..76457ca 100644
>> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
>>
>> # Override SRC_URI in a bbappend file to point at a different source
>> # tree if you do not want to build from Linus' tree.
>> -SRC_URI =
>> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
>> +SRC_URI_machine =
>> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine"
>>
>> -LINUX_VERSION ?= "3.4"
>> -LINUX_VERSION_EXTENSION ?= "-custom"
>> +LINUX_VERSION_machine ?= "3.4"
>> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
>
> For some reason, I thought you meant ${MACHINE} instead of _machine ..
> which
> is what I use for machine specific overrides.
I think macros can not used as overrides.
Nitin
>
> But assuming this works, i have no objections.
>
> Bruce
>
>>
>> # Override SRCREV to point to a different commit in a bbappend file to
>> # build a different release of the Linux kernel.
>> @@ -61,4 +61,4 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
>>
>> # Override COMPATIBLE_MACHINE to include your machine in a bbappend
>> # file. Leaving it empty here ensures an early explicit build failure.
>> -COMPATIBLE_MACHINE = "(^$)"
>> +COMPATIBLE_MACHINE_machine = "(^$)"
>>
> z
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-11 17:53 ` Kamble, Nitin A
@ 2014-04-15 16:54 ` Paul Eggleton
2014-04-15 18:03 ` Hart, Darren
0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2014-04-15 16:54 UTC (permalink / raw)
To: openembedded-core; +Cc: darren.hart, Openembedded-core
On Friday 11 April 2014 10:53:17 Kamble, Nitin A wrote:
> On 4/11/2014 10:48 AM, Bruce Ashfield wrote:
> > On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
> >> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >>
> >> Use machine overrides for variables for this skeleton recipe so that
> >> people following skeleton do it right at the beginning.
> >>
> >> The machine overrides for the variables reduces pollution of name space
> >> and avoid unintentional influences on other layers.
> >>
> >> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> >> ---
> >>
> >> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> index c329106..76457ca 100644
> >> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
> >>
> >> # Override SRC_URI in a bbappend file to point at a different source
> >> # tree if you do not want to build from Linus' tree.
> >>
> >> -SRC_URI =
> >> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
> >> l=git;nocheckout=1;name=machine" +SRC_URI_machine =
> >> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
> >> l=git;nocheckout=1;name=machine"
> >>
> >> -LINUX_VERSION ?= "3.4"
> >> -LINUX_VERSION_EXTENSION ?= "-custom"
> >> +LINUX_VERSION_machine ?= "3.4"
> >> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
> >
> > For some reason, I thought you meant ${MACHINE} instead of _machine ..
> > which is what I use for machine specific overrides.
>
> I think macros can not used as overrides.
Variable references can be used in overrides, provided the expansion happens
at the right time. However, it would not be appropriate to use ${MACHINE} here
because if it were used verbatim in the recipe, it would not have the desired
effect - the value of ${MACHINE} would change with whatever MACHINE was set to,
and since ${MACHINE} is always in OVERRIDES it would always be applied.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-15 16:54 ` Paul Eggleton
@ 2014-04-15 18:03 ` Hart, Darren
2014-04-15 23:41 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Hart, Darren @ 2014-04-15 18:03 UTC (permalink / raw)
To: Paul Eggleton, openembedded-core@lists.openembedded.org
On 4/15/14, 9:54, "Paul Eggleton" <paul.eggleton@linux.intel.com> wrote:
>On Friday 11 April 2014 10:53:17 Kamble, Nitin A wrote:
>> On 4/11/2014 10:48 AM, Bruce Ashfield wrote:
>> > On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
>> >> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>> >>
>> >> Use machine overrides for variables for this skeleton recipe so that
>> >> people following skeleton do it right at the beginning.
>> >>
>> >> The machine overrides for the variables reduces pollution of name
>>space
>> >> and avoid unintentional influences on other layers.
>> >>
>> >> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> >> ---
>> >>
>> >> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8
>>++++----
>> >> 1 file changed, 4 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> index c329106..76457ca 100644
>> >> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
>> >>
>> >> # Override SRC_URI in a bbappend file to point at a different
>>source
>> >> # tree if you do not want to build from Linus' tree.
>> >>
>> >> -SRC_URI =
>> >>
>>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
>> >> l=git;nocheckout=1;name=machine" +SRC_URI_machine =
>> >>
>>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
>> >> l=git;nocheckout=1;name=machine"
>> >>
>> >> -LINUX_VERSION ?= "3.4"
>> >> -LINUX_VERSION_EXTENSION ?= "-custom"
>> >> +LINUX_VERSION_machine ?= "3.4"
>> >> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
>> >
>> > For some reason, I thought you meant ${MACHINE} instead of _machine ..
>> > which is what I use for machine specific overrides.
>>
>> I think macros can not used as overrides.
>
>Variable references can be used in overrides, provided the expansion
>happens
>at the right time. However, it would not be appropriate to use ${MACHINE}
>here
>because if it were used verbatim in the recipe, it would not have the
>desired
>effect - the value of ${MACHINE} would change with whatever MACHINE was
>set to,
>and since ${MACHINE} is always in OVERRIDES it would always be applied.
>
>Cheers,
>Paul
>
>--
>
>Paul Eggleton
>Intel Open Source Technology Centre
>
I think we should just drop the overrides. The overrides are needed with
linux-yocto bbappends so we don't pollute the namespace, but here there is
nothing to polute. This is the only recipe, you don't use bbappends with
it. It needs some documentation, but we should just drop all the overrides
in this recipe.
--
Darren Hart Open Source Technology Center
darren.hart@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-15 18:03 ` Hart, Darren
@ 2014-04-15 23:41 ` Paul Eggleton
2014-04-18 16:12 ` Kamble, Nitin A
0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2014-04-15 23:41 UTC (permalink / raw)
To: Hart, Darren; +Cc: openembedded-core
On Tuesday 15 April 2014 18:03:45 Hart, Darren wrote:
> On 4/15/14, 9:54, "Paul Eggleton" <paul.eggleton@linux.intel.com> wrote:
> >On Friday 11 April 2014 10:53:17 Kamble, Nitin A wrote:
> >> On 4/11/2014 10:48 AM, Bruce Ashfield wrote:
> >> > On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
> >> >> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >> >>
> >> >> Use machine overrides for variables for this skeleton recipe so that
> >> >> people following skeleton do it right at the beginning.
> >> >>
> >> >> The machine overrides for the variables reduces pollution of name
> >>
> >>space
> >>
> >> >> and avoid unintentional influences on other layers.
> >> >>
> >> >> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> >> >> ---
> >> >>
> >> >> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8
> >>
> >>++++----
> >>
> >> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >> >>
> >> >> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> >> b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> >> index c329106..76457ca 100644
> >> >> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> >> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
> >> >> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
> >> >>
> >> >> # Override SRC_URI in a bbappend file to point at a different
> >>
> >>source
> >>
> >> >> # tree if you do not want to build from Linus' tree.
> >> >>
> >> >> -SRC_URI =
> >>
> >>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
> >>
> >> >> l=git;nocheckout=1;name=machine" +SRC_URI_machine =
> >>
> >>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
> >>
> >> >> l=git;nocheckout=1;name=machine"
> >> >>
> >> >> -LINUX_VERSION ?= "3.4"
> >> >> -LINUX_VERSION_EXTENSION ?= "-custom"
> >> >> +LINUX_VERSION_machine ?= "3.4"
> >> >> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
> >> >
> >> > For some reason, I thought you meant ${MACHINE} instead of _machine ..
> >> > which is what I use for machine specific overrides.
> >>
> >> I think macros can not used as overrides.
> >
> >Variable references can be used in overrides, provided the expansion
> >happens
> >at the right time. However, it would not be appropriate to use ${MACHINE}
> >here
> >because if it were used verbatim in the recipe, it would not have the
> >desired
> >effect - the value of ${MACHINE} would change with whatever MACHINE was
> >set to,
> >and since ${MACHINE} is always in OVERRIDES it would always be applied.
>
> I think we should just drop the overrides. The overrides are needed with
> linux-yocto bbappends so we don't pollute the namespace, but here there is
> nothing to polute. This is the only recipe, you don't use bbappends with
> it. It needs some documentation, but we should just drop all the overrides
> in this recipe.
I think you're probably right with the way this recipe is intended to be used,
yes.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
2014-04-15 23:41 ` Paul Eggleton
@ 2014-04-18 16:12 ` Kamble, Nitin A
0 siblings, 0 replies; 9+ messages in thread
From: Kamble, Nitin A @ 2014-04-18 16:12 UTC (permalink / raw)
To: Paul Eggleton, Hart, Darren; +Cc: openembedded-core@lists.openembedded.org
> > >
> > >Variable references can be used in overrides, provided the expansion
> > >happens at the right time. However, it would not be appropriate to
> > >use ${MACHINE} here because if it were used verbatim in the recipe,
> > >it would not have the desired effect - the value of ${MACHINE} would
> > >change with whatever MACHINE was set to, and since ${MACHINE} is
> > >always in OVERRIDES it would always be applied.
> >
> > I think we should just drop the overrides. The overrides are needed
> > with linux-yocto bbappends so we don't pollute the namespace, but here
> > there is nothing to polute. This is the only recipe, you don't use
> > bbappends with it. It needs some documentation, but we should just
> > drop all the overrides in this recipe.
>
> I think you're probably right with the way this recipe is intended to be used,
> yes.
>
So shall we leave this recipe unchanged? As the commit was made to avoid the
unwanted recipe variable pollution across layers, which is not the case.
Nitin
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-18 16:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 17:05 [PATCH 0/1] A kernel recipe fix for meta-skeleton layer nitin.a.kamble
2014-04-11 17:05 ` [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides nitin.a.kamble
2014-04-11 17:18 ` Hart, Darren
2014-04-11 17:48 ` Bruce Ashfield
2014-04-11 17:53 ` Kamble, Nitin A
2014-04-15 16:54 ` Paul Eggleton
2014-04-15 18:03 ` Hart, Darren
2014-04-15 23:41 ` Paul Eggleton
2014-04-18 16:12 ` Kamble, Nitin A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox