[PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/distro/include/sane-toolchain.inc |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/conf/distro/include/sane-toolchain.inc b/conf/distro/include/sane-toolchain.inc
index 6b6b170..8d9912f 100644
--- a/conf/distro/include/sane-toolchain.inc
+++ b/conf/distro/include/sane-toolchain.inc
@@ -86,7 +86,12 @@ ARM_INSTRUCTION_SET = "${PREFERRED_ARM_INSTRUCTION_SET}"
 #    but requires more instructions (140% for 70% smaller code) so may be
 #    slower.
 
-THUMB_INTERWORK = "yes"
+# armv4 does not have thumb instruction set therefore no interworking instructions
+# so if machine is based on armv4 we dont have choice.
+
+THUMB_INTERWORK_armv4 = "no"
+THUMB_INTERWORK ?= "yes"
+
 # "yes" "no"
 #    Whether to compile with code to allow interworking between the two
 #    instruction sets.  This allows thumb code to be executed on a primarily
@@ -145,7 +150,7 @@ def detect_arm_abi (d):
 			return "oabi"
 		else:
 			return ""
-	if bb.data.getVar('TARGET_ARCH', d, 1) in [ 'arm', 'armeb' ]:          
+	if bb.data.getVar('TARGET_ARCH', d, 1) in [ 'arm', 'armeb' ]:
 		if 'eabi' in bb.data.getVar('DISTRO_FEATURES',d).split():
 			return "eabi"
 		return "oabi"
@@ -154,7 +159,7 @@ def detect_arm_abi (d):
 def compute_os_portion_of_target_triplet (d):
 	import bb
 	arm_eabi_supporting_arches = "armv6 armv6-novfp \
-	armv5te iwmmxt armv7a armv7 armv5teb armv4t"
+	armv5te iwmmxt armv7a armv7 armv5teb armv4t armv4"
 	ppc_spe_supporting_arches = "ppce500v2 ppce500"
 	gnu_suffix = ""
 	if bb.data.getVar('LIBC', d, 1) == "uclibc":
-- 
1.7.0.4

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Phil Blundell]

On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
> -THUMB_INTERWORK = "yes"
> +# armv4 does not have thumb instruction set therefore no interworking instructions
> +# so if machine is based on armv4 we dont have choice.
> +
> +THUMB_INTERWORK_armv4 = "no"
> +THUMB_INTERWORK ?= "yes"

I don't think this is necessary or desirable.  If you are building for
v4 then the BX instructions ought to be fixed up during final link.  Is
there a particular problem that you're trying to solve?

p.

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Khem Raj]

On Mon, Jul 19, 2010 at 7:26 AM, Phil Blundell <philb@gnu.org> wrote:
> On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
>> -THUMB_INTERWORK = "yes"
>> +# armv4 does not have thumb instruction set therefore no interworking instructions
>> +# so if machine is based on armv4 we dont have choice.
>> +
>> +THUMB_INTERWORK_armv4 = "no"
>> +THUMB_INTERWORK ?= "yes"
>
> I don't think this is necessary or desirable.  If you are building for
> v4 then the BX instructions ought to be fixed up during final link.

Yes with --fix-v4bx/--fix-v4bx-interworking its possible.


Is
> there a particular problem that you're trying to solve?
>

Not any particular case but some versions of compiler do not pass
flags to --fix-v4bx-interworking ld.

I was thinking its more apt to describe the machine with not
supporting THUMB_INTERWORK
hmmm but I now I see that we will need it for v4/EABI support. So
better fix the compiler.

> p.
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Phil Blundell]

On Mon, 2010-07-19 at 09:29 -0700, Khem Raj wrote:
> On Mon, Jul 19, 2010 at 7:26 AM, Phil Blundell <philb@gnu.org> wrote:
> > On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
> >> -THUMB_INTERWORK = "yes"
> >> +# armv4 does not have thumb instruction set therefore no interworking instructions
> >> +# so if machine is based on armv4 we dont have choice.
> >> +
> >> +THUMB_INTERWORK_armv4 = "no"
> >> +THUMB_INTERWORK ?= "yes"
> >
> > I don't think this is necessary or desirable.  If you are building for
> > v4 then the BX instructions ought to be fixed up during final link.
> 
> Yes with --fix-v4bx/--fix-v4bx-interworking its possible.
> 
> 
> Is
> > there a particular problem that you're trying to solve?
> >
> 
> Not any particular case but some versions of compiler do not pass
> flags to --fix-v4bx-interworking ld.

True.  But this is sane-toolchain we're talking about, and the version
that it selects by default (4.4.4) does get this right.  So I don't
think it's going to be a big deal in practice.

p.

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Khem Raj]

On Mon, Jul 19, 2010 at 9:46 AM, Phil Blundell <philb@gnu.org> wrote:
> On Mon, 2010-07-19 at 09:29 -0700, Khem Raj wrote:
>> On Mon, Jul 19, 2010 at 7:26 AM, Phil Blundell <philb@gnu.org> wrote:
>> > On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
>> >> -THUMB_INTERWORK = "yes"
>> >> +# armv4 does not have thumb instruction set therefore no interworking instructions
>> >> +# so if machine is based on armv4 we dont have choice.
>> >> +
>> >> +THUMB_INTERWORK_armv4 = "no"
>> >> +THUMB_INTERWORK ?= "yes"
>> >
>> > I don't think this is necessary or desirable.  If you are building for
>> > v4 then the BX instructions ought to be fixed up during final link.
>>
>> Yes with --fix-v4bx/--fix-v4bx-interworking its possible.
>>
>>
>> Is
>> > there a particular problem that you're trying to solve?
>> >
>>
>> Not any particular case but some versions of compiler do not pass
>> flags to --fix-v4bx-interworking ld.
>
> True.  But this is sane-toolchain we're talking about, and the version
> that it selects by default (4.4.4) does get this right.  So I don't
> think it's going to be a big deal in practice.

yes disregard that hunk.

>
> p.
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Phil Blundell]

On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
>  	import bb
>  	arm_eabi_supporting_arches = "armv6 armv6-novfp \
> -	armv5te iwmmxt armv7a armv7 armv5teb armv4t"
> +	armv5te iwmmxt armv7a armv7 armv5teb armv4t armv4"
>  	ppc_spe_supporting_arches = "ppce500v2 ppce500"

I guess it would make more sense to enumerate here the ARM arches which
don't support eabi.  All future ones will, presumably, so it's only
ARMv3 and older which don't.  That way we won't have to keep adjusting
this list for every new architecture variant that someone thinks up.

p.

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Khem Raj]

On Mon, Jul 19, 2010 at 1:20 PM, Phil Blundell <philb@gnu.org> wrote:
> On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
>>       import bb
>>       arm_eabi_supporting_arches = "armv6 armv6-novfp \
>> -     armv5te iwmmxt armv7a armv7 armv5teb armv4t"
>> +     armv5te iwmmxt armv7a armv7 armv5teb armv4t armv4"
>>       ppc_spe_supporting_arches = "ppce500v2 ppce500"
>
> I guess it would make more sense to enumerate here the ARM arches which
> don't support eabi.  All future ones will, presumably, so it's only
> ARMv3 and older which don't.  That way we won't have to keep adjusting
> this list for every new architecture variant that someone thinks up.

yes thats good idea.

>
> p.
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Khem Raj]

On Mon, Jul 19, 2010 at 1:20 PM, Phil Blundell <philb@gnu.org> wrote:
> On Mon, 2010-07-19 at 01:24 -0700, Khem Raj wrote:
>>       import bb
>>       arm_eabi_supporting_arches = "armv6 armv6-novfp \
>> -     armv5te iwmmxt armv7a armv7 armv5teb armv4t"
>> +     armv5te iwmmxt armv7a armv7 armv5teb armv4t armv4"
>>       ppc_spe_supporting_arches = "ppce500v2 ppce500"
>
> I guess it would make more sense to enumerate here the ARM arches which
> don't support eabi.  All future ones will, presumably, so it's only
> ARMv3 and older which don't.  That way we won't have to keep adjusting
> this list for every new architecture variant that someone thinks up.
>

and I think the oldest arm architecture we support is armv4 which means we may
not need this check at all anymore.


> p.
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] sane-toolchain.inc: THUMB_INTERWORK should not be defined for armv4 and add armv4 to ARM EABI supporting architectures.

[Phil Blundell]

On Mon, 2010-07-19 at 15:49 -0700, Khem Raj wrote:
> and I think the oldest arm architecture we support is armv4 which means we may
> not need this check at all anymore.

Yeah, that might well be right.  I had thought there were some ARM710
(which is armv3) machines supported, but I can't see any trace of them
now so either I imagined it or they have been deleted.

p.