* [meta-networking][PATCH] traceroute: Remove bashisms @ 2012-12-21 21:23 Morgan Little 2012-12-21 21:37 ` Martin Jansa 0 siblings, 1 reply; 9+ messages in thread From: Morgan Little @ 2012-12-21 21:23 UTC (permalink / raw) To: openembedded-devel Signed-off-by: Morgan Little <morgan.little@windriver.com> --- meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb index 719d9fb..d855c67 100644 --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb @@ -32,10 +32,8 @@ do_install() { install -d ${D}${mandir} install -p -m644 ${PN}/${PN}.8 ${D}${mandir} - pushd ${D}${mandir} - ln -s ${PN}.8 ${PN}6.8 - ln -s ${PN}.8 tcptraceroute.8 - popd + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 } -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2012-12-21 21:23 [meta-networking][PATCH] traceroute: Remove bashisms Morgan Little @ 2012-12-21 21:37 ` Martin Jansa 2012-12-21 22:02 ` Little, Morgan 0 siblings, 1 reply; 9+ messages in thread From: Martin Jansa @ 2012-12-21 21:37 UTC (permalink / raw) To: openembedded-devel On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little <morgan.little@windriver.com> wrote: > Signed-off-by: Morgan Little <morgan.little@windriver.com> > --- > meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > index 719d9fb..d855c67 100644 > --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > @@ -32,10 +32,8 @@ do_install() { > > install -d ${D}${mandir} > install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > - pushd ${D}${mandir} > - ln -s ${PN}.8 ${PN}6.8 > - ln -s ${PN}.8 tcptraceroute.8 > - popd > + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 Thanks for quick reply and fix, but I think this should be: > + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 ${D} path won't be valid on target and missing slash after mandir And is there something referencing those man pages with different name? Or why are those symlinks provided? Cheers, ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2012-12-21 21:37 ` Martin Jansa @ 2012-12-21 22:02 ` Little, Morgan 2013-01-09 14:22 ` Martin Jansa 2013-01-18 13:53 ` Joe MacDonald 0 siblings, 2 replies; 9+ messages in thread From: Little, Morgan @ 2012-12-21 22:02 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org On 12/21/2012 04:37 PM, Martin Jansa wrote: > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > <morgan.little@windriver.com> wrote: >> Signed-off-by: Morgan Little <morgan.little@windriver.com> >> --- >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb >> index 719d9fb..d855c67 100644 >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb >> @@ -32,10 +32,8 @@ do_install() { >> >> install -d ${D}${mandir} >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} >> - pushd ${D}${mandir} >> - ln -s ${PN}.8 ${PN}6.8 >> - ln -s ${PN}.8 tcptraceroute.8 >> - popd >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > Thanks for quick reply and fix, but I think this should be: >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > ${D} path won't be valid on target and missing slash after mandir It looks like it should be. Thank you for noticing that. > > And is there something referencing those man pages with different > name? Or why are those symlinks provided? I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. //Morgan > > Cheers, > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2012-12-21 22:02 ` Little, Morgan @ 2013-01-09 14:22 ` Martin Jansa 2013-01-09 14:42 ` Joe MacDonald 2013-01-18 13:53 ` Joe MacDonald 1 sibling, 1 reply; 9+ messages in thread From: Martin Jansa @ 2013-01-09 14:22 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1838 bytes --] On Fri, Dec 21, 2012 at 10:02:28PM +0000, Little, Morgan wrote: > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > <morgan.little@windriver.com> wrote: > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > >> --- > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> index 719d9fb..d855c67 100644 > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> @@ -32,10 +32,8 @@ do_install() { > >> > >> install -d ${D}${mandir} > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > >> - pushd ${D}${mandir} > >> - ln -s ${PN}.8 ${PN}6.8 > >> - ln -s ${PN}.8 tcptraceroute.8 > >> - popd > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > Thanks for quick reply and fix, but I think this should be: > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > ${D} path won't be valid on target and missing slash after mandir > It looks like it should be. Thank you for noticing that. > > > > And is there something referencing those man pages with different > > name? Or why are those symlinks provided? > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. ping :) -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2013-01-09 14:22 ` Martin Jansa @ 2013-01-09 14:42 ` Joe MacDonald 2013-01-17 21:00 ` Martin Jansa 0 siblings, 1 reply; 9+ messages in thread From: Joe MacDonald @ 2013-01-09 14:42 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2143 bytes --] [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 13.01.09 (Wed 15:22) Martin Jansa wrote: > On Fri, Dec 21, 2012 at 10:02:28PM +0000, Little, Morgan wrote: > > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > > <morgan.little@windriver.com> wrote: > > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > > >> --- > > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> index 719d9fb..d855c67 100644 > > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> @@ -32,10 +32,8 @@ do_install() { > > >> > > >> install -d ${D}${mandir} > > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > > >> - pushd ${D}${mandir} > > >> - ln -s ${PN}.8 ${PN}6.8 > > >> - ln -s ${PN}.8 tcptraceroute.8 > > >> - popd > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > > > Thanks for quick reply and fix, but I think this should be: > > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > > > ${D} path won't be valid on target and missing slash after mandir > > It looks like it should be. Thank you for noticing that. > > > > > > And is there something referencing those man pages with different > > > name? Or why are those symlinks provided? > > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. > > ping :) I think this belongs to me to finish up now. I plan to remove them. I've kept the thread in my inbox so hopefully I can cover all the comments on it. -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2013-01-09 14:42 ` Joe MacDonald @ 2013-01-17 21:00 ` Martin Jansa 0 siblings, 0 replies; 9+ messages in thread From: Martin Jansa @ 2013-01-17 21:00 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2337 bytes --] On Wed, Jan 09, 2013 at 09:42:37AM -0500, Joe MacDonald wrote: > [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 13.01.09 (Wed 15:22) Martin Jansa wrote: > > > On Fri, Dec 21, 2012 at 10:02:28PM +0000, Little, Morgan wrote: > > > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > > > <morgan.little@windriver.com> wrote: > > > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > > > >> --- > > > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > > > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > > >> > > > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> index 719d9fb..d855c67 100644 > > > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> @@ -32,10 +32,8 @@ do_install() { > > > >> > > > >> install -d ${D}${mandir} > > > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > > > >> - pushd ${D}${mandir} > > > >> - ln -s ${PN}.8 ${PN}6.8 > > > >> - ln -s ${PN}.8 tcptraceroute.8 > > > >> - popd > > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > > > > > Thanks for quick reply and fix, but I think this should be: > > > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > > > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > > > > > ${D} path won't be valid on target and missing slash after mandir > > > It looks like it should be. Thank you for noticing that. > > > > > > > > And is there something referencing those man pages with different > > > > name? Or why are those symlinks provided? > > > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. > > > > ping :) > > I think this belongs to me to finish up now. I plan to remove them. > I've kept the thread in my inbox so hopefully I can cover all the > comments on it. ping2 :) -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2012-12-21 22:02 ` Little, Morgan 2013-01-09 14:22 ` Martin Jansa @ 2013-01-18 13:53 ` Joe MacDonald 2013-01-18 14:17 ` Martin Jansa 1 sibling, 1 reply; 9+ messages in thread From: Joe MacDonald @ 2013-01-18 13:53 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2749 bytes --] [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 12.12.21 (Fri 22:02) Little, Morgan wrote: > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > <morgan.little@windriver.com> wrote: > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > >> --- > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> index 719d9fb..d855c67 100644 > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > >> @@ -32,10 +32,8 @@ do_install() { > >> > >> install -d ${D}${mandir} > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > >> - pushd ${D}${mandir} > >> - ln -s ${PN}.8 ${PN}6.8 > >> - ln -s ${PN}.8 tcptraceroute.8 > >> - popd > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > Thanks for quick reply and fix, but I think this should be: > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > ${D} path won't be valid on target and missing slash after mandir > It looks like it should be. Thank you for noticing that. Fixed. That one's easy. > > > > And is there something referencing those man pages with different > > name? Or why are those symlinks provided? > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. So, as far as I can tell, the links are provided to support /etc/alternatives/ versions of the manpages in case you've got an alternative implementation of traceroute/traceroute6/etc. on your system. Unless you think the links are adding unnecessary clutter, I'm inclined to leave them even though I honestly have never installed an alternative traceroute and never looked into why I might want to. -J. > > //Morgan > > > > Cheers, > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2013-01-18 13:53 ` Joe MacDonald @ 2013-01-18 14:17 ` Martin Jansa 2013-01-18 14:34 ` Joe MacDonald 0 siblings, 1 reply; 9+ messages in thread From: Martin Jansa @ 2013-01-18 14:17 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3356 bytes --] On Fri, Jan 18, 2013 at 08:53:01AM -0500, Joe MacDonald wrote: > [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 12.12.21 (Fri 22:02) Little, Morgan wrote: > > > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > > <morgan.little@windriver.com> wrote: > > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > > >> --- > > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> index 719d9fb..d855c67 100644 > > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> @@ -32,10 +32,8 @@ do_install() { > > >> > > >> install -d ${D}${mandir} > > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > > >> - pushd ${D}${mandir} > > >> - ln -s ${PN}.8 ${PN}6.8 > > >> - ln -s ${PN}.8 tcptraceroute.8 > > >> - popd > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > > > Thanks for quick reply and fix, but I think this should be: > > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > > > ${D} path won't be valid on target and missing slash after mandir > > It looks like it should be. Thank you for noticing that. > > Fixed. That one's easy. Great, thanks I'll reenable it in world build when it's pushed. > > > > > > And is there something referencing those man pages with different > > > name? Or why are those symlinks provided? > > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. > > So, as far as I can tell, the links are provided to support > /etc/alternatives/ versions of the manpages in case you've got an > alternative implementation of traceroute/traceroute6/etc. on your > system. Unless you think the links are adding unnecessary clutter, I'm > inclined to leave them even though I honestly have never installed an > alternative traceroute and never looked into why I might want to. I don't mind if they stay. (I'm not using traceroute on my targets). > -J. > > > > > //Morgan > > > > > > Cheers, > > > > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > -- > -Joe MacDonald. > :wq > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-networking][PATCH] traceroute: Remove bashisms 2013-01-18 14:17 ` Martin Jansa @ 2013-01-18 14:34 ` Joe MacDonald 0 siblings, 0 replies; 9+ messages in thread From: Joe MacDonald @ 2013-01-18 14:34 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3652 bytes --] [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 13.01.18 (Fri 15:17) Martin Jansa wrote: > On Fri, Jan 18, 2013 at 08:53:01AM -0500, Joe MacDonald wrote: > > [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 12.12.21 (Fri 22:02) Little, Morgan wrote: > > > > > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > > > <morgan.little@windriver.com> wrote: > > > >> Signed-off-by: Morgan Little <morgan.little@windriver.com> > > > >> --- > > > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++---- > > > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > > >> > > > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> index 719d9fb..d855c67 100644 > > > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > > >> @@ -32,10 +32,8 @@ do_install() { > > > >> > > > >> install -d ${D}${mandir} > > > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > > > >> - pushd ${D}${mandir} > > > >> - ln -s ${PN}.8 ${PN}6.8 > > > >> - ln -s ${PN}.8 tcptraceroute.8 > > > >> - popd > > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > > > > > Thanks for quick reply and fix, but I think this should be: > > > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > > > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > > > > > ${D} path won't be valid on target and missing slash after mandir > > > It looks like it should be. Thank you for noticing that. > > > > Fixed. That one's easy. > > Great, thanks I'll reenable it in world build when it's pushed. Just pushed. Thanks for the reminder, Martin. -J. > > > > > > > > > And is there something referencing those man pages with different > > > > name? Or why are those symlinks provided? > > > I provided them because I was basing the do_install step off of the .spec file the Fedora uses in their RPM file. It does a similar symlink step. I believe that is can be removed. > > > > So, as far as I can tell, the links are provided to support > > /etc/alternatives/ versions of the manpages in case you've got an > > alternative implementation of traceroute/traceroute6/etc. on your > > system. Unless you think the links are adding unnecessary clutter, I'm > > inclined to leave them even though I honestly have never installed an > > alternative traceroute and never looked into why I might want to. > > I don't mind if they stay. (I'm not using traceroute on my targets). > > > -J. > > > > > > > > //Morgan > > > > > > > > Cheers, > > > > > > > > _______________________________________________ > > > > Openembedded-devel mailing list > > > > Openembedded-devel@lists.openembedded.org > > > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > -- > > -Joe MacDonald. > > :wq > > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-01-18 14:50 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-21 21:23 [meta-networking][PATCH] traceroute: Remove bashisms Morgan Little 2012-12-21 21:37 ` Martin Jansa 2012-12-21 22:02 ` Little, Morgan 2013-01-09 14:22 ` Martin Jansa 2013-01-09 14:42 ` Joe MacDonald 2013-01-17 21:00 ` Martin Jansa 2013-01-18 13:53 ` Joe MacDonald 2013-01-18 14:17 ` Martin Jansa 2013-01-18 14:34 ` Joe MacDonald
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox