* [meta-oe][PATCH 2/7] obexftp: Create 0.23 version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-07 21:26 ` [meta-oe][PATCH 3/7] can-utils: Create git version Lauren Post
` (5 subsequent siblings)
6 siblings, 0 replies; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
obexftp is a tool to transfer files from any
OBEX enabled device. Disable prints to improve
performance
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
.../obexftp/Remove_some_printf_in_obexftpd.patch | 34 ++++++++++++++++++++
.../recipes-connectivity/obexftp/obexftp_0.23.bb | 16 +++++++++
2 files changed, 50 insertions(+)
create mode 100644 meta-oe/recipes-connectivity/obexftp/obexftp/Remove_some_printf_in_obexftpd.patch
create mode 100644 meta-oe/recipes-connectivity/obexftp/obexftp_0.23.bb
diff --git a/meta-oe/recipes-connectivity/obexftp/obexftp/Remove_some_printf_in_obexftpd.patch b/meta-oe/recipes-connectivity/obexftp/obexftp/Remove_some_printf_in_obexftpd.patch
new file mode 100644
index 0000000..8b73af3
--- /dev/null
+++ b/meta-oe/recipes-connectivity/obexftp/obexftp/Remove_some_printf_in_obexftpd.patch
@@ -0,0 +1,34 @@
+Signed-off-by: Jun Zhu <R01007@freescale.com>
+
+Upstream-Status: Not applicable
+
+diff -Nru obexftp-0.23/apps.orig/obexftpd.c obexftp-0.23/apps/obexftpd.c
+--- obexftp-0.23/apps.orig/obexftpd.c 2013-11-08 10:42:20.816631583 +0800
++++ obexftp-0.23/apps/obexftpd.c 2013-11-08 10:44:18.628634893 +0800
+@@ -639,7 +639,7 @@
+ struct stat statbuf;
+ //char *namebuf = NULL;
+
+- fprintf(stderr, "put_done>>>\n");
++ //fprintf(stderr, "put_done>>>\n");
+ while(OBEX_ObjectGetNextHeader(handle, object, &hi, &hv, &hlen)) {
+ switch(hi) {
+ case OBEX_HDR_BODY:
+@@ -671,7 +671,7 @@
+ }
+ }
+ if(!body) {
+- printf("Got a PUT without a body\n");
++ //printf("Got a PUT without a body\n");
+ OBEX_ObjectSetRsp(object, OBEX_RSP_CONTINUE, OBEX_RSP_SUCCESS);
+ }
+ if(!name) {
+@@ -807,7 +807,7 @@
+
+ switch(obex_cmd) {
+ case OBEX_CMD_PUT:
+- fprintf(stderr, "obex_ev_progress: obex_cmd_put\n");
++ //fprintf(stderr, "obex_ev_progress: obex_cmd_put\n");
+ put_done(handle, obj, 0);
+ break;
+ default:
diff --git a/meta-oe/recipes-connectivity/obexftp/obexftp_0.23.bb b/meta-oe/recipes-connectivity/obexftp/obexftp_0.23.bb
new file mode 100644
index 0000000..b6bdfb7
--- /dev/null
+++ b/meta-oe/recipes-connectivity/obexftp/obexftp_0.23.bb
@@ -0,0 +1,16 @@
+DESCRIPTION = "A tool for transfer files to/from any OBEX enabled device"
+LICENSE = "GPLv2 & LGPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
+
+DEPENDS += "openobex"
+
+SRC_URI = "http://sourceforge.net/projects/openobex/files/obexftp/${PV}/obexftp-${PV}.tar.bz2 \
+ file://Remove_some_printf_in_obexftpd.patch "
+
+SRC_URI[md5sum] = "f20762061b68bc921e80be4aebc349eb"
+SRC_URI[sha256sum] = "44a74ff288d38c0f75354d6bc2efe7d6dec10112eaff2e7b10e292b0d2105b36"
+
+inherit autotools pkgconfig
+
+EXTRA_OECONF += "--disable-tcl --disable-perl --disable-python --disable-ruby"
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [meta-oe][PATCH 3/7] can-utils: Create git version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
2014-03-07 21:26 ` [meta-oe][PATCH 2/7] obexftp: Create 0.23 version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-11 14:08 ` Martin Jansa
2014-03-07 21:26 ` [meta-oe][PATCH 4/7] glcompbench: Create 2012.08 version Lauren Post
` (4 subsequent siblings)
6 siblings, 1 reply; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
Linux CAN network development utilities - newer version than canutils
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
.../recipes-extended/socketcan/can-utils_git.bb | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 meta-oe/recipes-extended/socketcan/can-utils_git.bb
diff --git a/meta-oe/recipes-extended/socketcan/can-utils_git.bb b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
new file mode 100644
index 0000000..53632c8
--- /dev/null
+++ b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
@@ -0,0 +1,14 @@
+SUMMARY = "Linux CAN network development utilities"
+DESCRIPTION = "Linux CAN network development"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
+
+DEPENDS = "libsocketcan"
+
+SRC_URI = "git://git.gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"
+SRCREV = "67a2bdcd336e6becfa5784742e18c88dbeddc973"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 3/7] can-utils: Create git version
2014-03-07 21:26 ` [meta-oe][PATCH 3/7] can-utils: Create git version Lauren Post
@ 2014-03-11 14:08 ` Martin Jansa
2014-03-11 14:26 ` Otavio Salvador
0 siblings, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2014-03-11 14:08 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
On Fri, Mar 07, 2014 at 03:26:11PM -0600, Lauren Post wrote:
> Linux CAN network development utilities - newer version than canutils
>
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
> .../recipes-extended/socketcan/can-utils_git.bb | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 meta-oe/recipes-extended/socketcan/can-utils_git.bb
>
> diff --git a/meta-oe/recipes-extended/socketcan/can-utils_git.bb b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
> new file mode 100644
> index 0000000..53632c8
> --- /dev/null
> +++ b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "Linux CAN network development utilities"
> +DESCRIPTION = "Linux CAN network development"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
Please use something from source tree, not COREBASE.
> +DEPENDS = "libsocketcan"
> +
> +SRC_URI = "git://git.gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"
> +SRCREV = "67a2bdcd336e6becfa5784742e18c88dbeddc973"
Please set PV.
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 3/7] can-utils: Create git version
2014-03-11 14:08 ` Martin Jansa
@ 2014-03-11 14:26 ` Otavio Salvador
0 siblings, 0 replies; 20+ messages in thread
From: Otavio Salvador @ 2014-03-11 14:26 UTC (permalink / raw)
To: OpenEmbedded Devel List
Hello Lauren and Martin,
On Tue, Mar 11, 2014 at 11:08 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Mar 07, 2014 at 03:26:11PM -0600, Lauren Post wrote:
>> Linux CAN network development utilities - newer version than canutils
>>
>> Signed-off-by: Lauren Post <lauren.post@freescale.com>
>> ---
>> .../recipes-extended/socketcan/can-utils_git.bb | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>> create mode 100644 meta-oe/recipes-extended/socketcan/can-utils_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/socketcan/can-utils_git.bb b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
>> new file mode 100644
>> index 0000000..53632c8
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
>> @@ -0,0 +1,14 @@
>> +SUMMARY = "Linux CAN network development utilities"
>> +DESCRIPTION = "Linux CAN network development"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
>
> Please use something from source tree, not COREBASE.
I did a check in the contents and it seems to be a mix of licenses:
$: licensecheck -r *
asc2log.c: BSD (3 clause)
autogen.sh: *No copyright* UNKNOWN
bcmserver.c: *No copyright* UNKNOWN
canbusload.c: BSD (3 clause)
can-calc-bit-timing.c: GPL
candump.c: BSD (3 clause)
canfdtest.c: GPL
canframelen.c: BSD (3 clause)
canframelen.h: BSD (3 clause)
cangen.c: BSD (3 clause)
cangw.c: BSD (3 clause)
canlogserver.c: BSD (3 clause)
canplayer.c: BSD (3 clause)
cansend.c: BSD (3 clause)
cansniffer.c: BSD (3 clause)
include/linux/can.h: BSD (3 clause)
include/linux/can/bcm.h: BSD (3 clause)
include/linux/can/error.h: BSD (3 clause)
include/linux/can/gw.h: BSD (3 clause)
include/linux/can/isotp.h: BSD (3 clause)
include/linux/can/netlink.h: UNKNOWN
include/linux/can/raw.h: BSD (3 clause)
isotpdump.c: BSD (3 clause)
isotprecv.c: BSD (3 clause)
isotpsend.c: BSD (3 clause)
isotpserver.c: BSD (3 clause)
isotpsniffer.c: BSD (3 clause)
isotptun.c: BSD (3 clause)
lib.c: BSD (3 clause)
lib.h: BSD (3 clause)
log2asc.c: BSD (3 clause)
log2long.c: BSD (3 clause)
slcan_attach.c: BSD (3 clause)
slcand.c: GPL (v2 or later) (with incorrect FSF address)
slcanpty.c: GPL (v2 or later) (with incorrect FSF address)
terminal.h: BSD (3 clause)
>> +DEPENDS = "libsocketcan"
>> +
>> +SRC_URI = "git://git.gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"
I'd use:
SRC_URI = "git://gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"
As this is the common form used in the current recipes.
>> +SRCREV = "67a2bdcd336e6becfa5784742e18c88dbeddc973"
>
> Please set PV.
As it has not been tagged in the repository I'd use:
PV = "0.0+git${SRCPV}"
here.
>> +S = "${WORKDIR}/git"
>> +
>> +inherit autotools pkgconfig
...
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 20+ messages in thread
* [meta-oe][PATCH 4/7] glcompbench: Create 2012.08 version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
2014-03-07 21:26 ` [meta-oe][PATCH 2/7] obexftp: Create 0.23 version Lauren Post
2014-03-07 21:26 ` [meta-oe][PATCH 3/7] can-utils: Create git version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-11 15:51 ` Martin Jansa
2014-03-07 21:26 ` [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version Lauren Post
` (3 subsequent siblings)
6 siblings, 1 reply; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
glcompbench is a benchmark tool for GL(ES)2 based
compositing operations
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
.../glcompbench/glbench-compile-fix.patch | 35 ++++++++++++++++++++
.../glcompbench/glcompbench_2012.08.bb | 14 ++++++++
2 files changed, 49 insertions(+)
create mode 100644 meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
create mode 100644 meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
diff --git a/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch b/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
new file mode 100644
index 0000000..374a6cf
--- /dev/null
+++ b/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
@@ -0,0 +1,35 @@
+From c4bc44c3abf69f26e4c2b7684f4da4670a51f993 Mon Sep 17 00:00:00 2001
+From: Prabhu Sundararaj <prabhu.sundararaj@freescale.com>
+Date: Tue, 5 Nov 2013 11:03:04 -0600
+Subject: [PATCH] to make compilable
+
+Upstream Status: Inappropriate [workaround]
+
+Signed-off-by: Prabhu Sundararaj <prabhu.sundararaj@freescale.com>
+---
+ src/composite-test-simple-blur.cc | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/composite-test-simple-blur.cc b/src/composite-test-simple-blur.cc
+index 170ad64..d7f77cf 100644
+--- a/src/composite-test-simple-blur.cc
++++ b/src/composite-test-simple-blur.cc
+@@ -347,6 +347,7 @@ CompositeTestSimpleBlur::CompositeTestSimpleBlur() :
+
+ CompositeTestSimpleBlur::~CompositeTestSimpleBlur()
+ {
++#if 0
+ for (BlurWindowMapType::iterator winIt = priv_->windowMap.begin();
+ winIt != priv_->windowMap.end();
+ winIt++)
+@@ -354,6 +355,7 @@ CompositeTestSimpleBlur::~CompositeTestSimpleBlur()
+ RenderWindowBlur* ro = winIt->second;
+ delete ro;
+ }
++#endif
+ delete priv_;
+ }
+
+--
+1.8.1.2
+
diff --git a/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb b/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
new file mode 100644
index 0000000..1adcc02
--- /dev/null
+++ b/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
@@ -0,0 +1,14 @@
+SUMMARY = "GL Compositing Benchmark"
+DESCRIPTION = "A benchmark for GL(ES)2 based compositing operations"
+LICENSE = "GPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949"
+
+DEPENDS += "virtual/egl virtual/libgl virtual/libgal-x11 virtual/egl virtual/libgles1 virtual/libgles2 "
+
+inherit pkgconfig waf
+
+SRC_URI = "https://launchpad.net/glcompbench/trunk/2012.08/+download/glcompbench-2012.08.tar.gz \
+ file://glbench-compile-fix.patch"
+
+SRC_URI[md5sum] = "c939d9156fe940960098f38707fea827"
+SRC_URI[sha256sum] = "b04b738cec06c6786ceafa86e4735fd8b971c078265754854ef356b0379542ee"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 4/7] glcompbench: Create 2012.08 version
2014-03-07 21:26 ` [meta-oe][PATCH 4/7] glcompbench: Create 2012.08 version Lauren Post
@ 2014-03-11 15:51 ` Martin Jansa
0 siblings, 0 replies; 20+ messages in thread
From: Martin Jansa @ 2014-03-11 15:51 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 4441 bytes --]
On Fri, Mar 07, 2014 at 03:26:12PM -0600, Lauren Post wrote:
> glcompbench is a benchmark tool for GL(ES)2 based
> compositing operations
>
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
> .../glcompbench/glbench-compile-fix.patch | 35 ++++++++++++++++++++
> .../glcompbench/glcompbench_2012.08.bb | 14 ++++++++
> 2 files changed, 49 insertions(+)
> create mode 100644 meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
> create mode 100644 meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
>
> diff --git a/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch b/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
> new file mode 100644
> index 0000000..374a6cf
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/glcompbench/glcompbench/glbench-compile-fix.patch
> @@ -0,0 +1,35 @@
> +From c4bc44c3abf69f26e4c2b7684f4da4670a51f993 Mon Sep 17 00:00:00 2001
> +From: Prabhu Sundararaj <prabhu.sundararaj@freescale.com>
> +Date: Tue, 5 Nov 2013 11:03:04 -0600
> +Subject: [PATCH] to make compilable
> +
> +Upstream Status: Inappropriate [workaround]
> +
> +Signed-off-by: Prabhu Sundararaj <prabhu.sundararaj@freescale.com>
> +---
> + src/composite-test-simple-blur.cc | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/composite-test-simple-blur.cc b/src/composite-test-simple-blur.cc
> +index 170ad64..d7f77cf 100644
> +--- a/src/composite-test-simple-blur.cc
> ++++ b/src/composite-test-simple-blur.cc
> +@@ -347,6 +347,7 @@ CompositeTestSimpleBlur::CompositeTestSimpleBlur() :
> +
> + CompositeTestSimpleBlur::~CompositeTestSimpleBlur()
> + {
> ++#if 0
> + for (BlurWindowMapType::iterator winIt = priv_->windowMap.begin();
> + winIt != priv_->windowMap.end();
> + winIt++)
> +@@ -354,6 +355,7 @@ CompositeTestSimpleBlur::~CompositeTestSimpleBlur()
> + RenderWindowBlur* ro = winIt->second;
> + delete ro;
> + }
> ++#endif
> + delete priv_;
> + }
> +
> +--
> +1.8.1.2
> +
> diff --git a/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb b/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
> new file mode 100644
> index 0000000..1adcc02
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "GL Compositing Benchmark"
> +DESCRIPTION = "A benchmark for GL(ES)2 based compositing operations"
> +LICENSE = "GPLv3"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949"
> +
> +DEPENDS += "virtual/egl virtual/libgl virtual/libgal-x11 virtual/egl virtual/libgles1 virtual/libgles2 "
ERROR: Nothing PROVIDES 'virtual/libgal-x11' (but /home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb DEPENDS on or otherwise requires it). Close matches:
virtual/libx11
virtual/libgl
virtual/libgles1
ERROR: Nothing RPROVIDES 'glcompbench' (but /home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'glcompbench'
NOTE: Runtime target 'glcompbench' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['glcompbench']
ERROR: Nothing RPROVIDES 'glcompbench-dev' (but /home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-oe/recipes-graphics/glcompbench/glcompbench_2012.08.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'glcompbench-dev'
NOTE: Runtime target 'glcompbench-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['glcompbench-dev']
> +
> +inherit pkgconfig waf
> +
> +SRC_URI = "https://launchpad.net/glcompbench/trunk/2012.08/+download/glcompbench-2012.08.tar.gz \
> + file://glbench-compile-fix.patch"
> +
> +SRC_URI[md5sum] = "c939d9156fe940960098f38707fea827"
> +SRC_URI[sha256sum] = "b04b738cec06c6786ceafa86e4735fd8b971c078265754854ef356b0379542ee"
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
` (2 preceding siblings ...)
2014-03-07 21:26 ` [meta-oe][PATCH 4/7] glcompbench: Create 2012.08 version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-11 14:14 ` Martin Jansa
2014-03-07 21:26 ` [meta-oe][PATCH 6/7] vlan: Create 1.9 version Lauren Post
` (2 subsequent siblings)
6 siblings, 1 reply; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
gtkperf is a GTK Performance tool
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars | 25 ++++++++++++++++++++
meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb | 26 +++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
new file mode 100644
index 0000000..8b09f53
--- /dev/null
+++ b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
@@ -0,0 +1,25 @@
+# Makefile variables for PO directory in any package using GNU gettext.
+
+# Usually the message domain is the same as the package name.
+DOMAIN = $(PACKAGE)
+
+# These two variables depend on the location of this directory.
+subdir = po
+top_builddir = ..
+
+# These options get passed to xgettext.
+XGETTEXT_OPTIONS = --keyword=_ --keyword=N_
+
+# This is the copyright holder that gets inserted into the header of the
+# $(DOMAIN).pot file. Set this to the copyright holder of the surrounding
+# package. (Note that the msgstr strings, extracted from the package's
+# sources, belong to the copyright holder of the package.) Translators are
+# expected to transfer the copyright for their translations to this person
+# or entity, or to disclaim their copyright. The empty string stands for
+# the public domain; in this case the translators are expected to disclaim
+# their copyright.
+COPYRIGHT_HOLDER = Free Software Foundation, Inc.
+
+# This is the list of locale categories, beyond LC_MESSAGES, for which the
+# message catalogs shall be used. It is usually empty.
+EXTRA_LOCALE_CATEGORIES =
diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
new file mode 100644
index 0000000..7e97a11
--- /dev/null
+++ b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
@@ -0,0 +1,26 @@
+SUMMARY = "GTK Performance tool"
+DESCRIPTION = "GTK Performance tools"
+SECTION = "libs"
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+SRC_URI = "http://prdownloads.sourceforge.net/gtkperf/gtkperf_${PV}.tar.gz \
+ file://Makevars"
+
+SRC_URI[md5sum] = "4331dde4bb83865e15482885fcb0cc53"
+SRC_URI[sha256sum] = "9704344e732038eecbd007dd996a56293a6b027b5b76f3f036273a3fae1ab27b"
+
+S = "${WORKDIR}/gtkperf"
+
+inherit autotools binconfig pkgconfig gettext
+
+do_configure_prepend () {
+ rm -f ${S}/m4/init.m4
+ cp -f ${WORKDIR}/Makevars ${S}/po/
+}
+
+do_install_append () {
+ rm -rf ${WORKDIR}/image/usr/doc
+}
+
+FILES_${PN} += "${exec_prefix}/share/duck.png"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version
2014-03-07 21:26 ` [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version Lauren Post
@ 2014-03-11 14:14 ` Martin Jansa
0 siblings, 0 replies; 20+ messages in thread
From: Martin Jansa @ 2014-03-11 14:14 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]
On Fri, Mar 07, 2014 at 03:26:13PM -0600, Lauren Post wrote:
> gtkperf is a GTK Performance tool
>
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
> meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars | 25 ++++++++++++++++++++
> meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb | 26 +++++++++++++++++++++
> 2 files changed, 51 insertions(+)
> create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
> create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
>
> diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
> new file mode 100644
> index 0000000..8b09f53
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
> @@ -0,0 +1,25 @@
> +# Makefile variables for PO directory in any package using GNU gettext.
> +
> +# Usually the message domain is the same as the package name.
> +DOMAIN = $(PACKAGE)
> +
> +# These two variables depend on the location of this directory.
> +subdir = po
> +top_builddir = ..
> +
> +# These options get passed to xgettext.
> +XGETTEXT_OPTIONS = --keyword=_ --keyword=N_
> +
> +# This is the copyright holder that gets inserted into the header of the
> +# $(DOMAIN).pot file. Set this to the copyright holder of the surrounding
> +# package. (Note that the msgstr strings, extracted from the package's
> +# sources, belong to the copyright holder of the package.) Translators are
> +# expected to transfer the copyright for their translations to this person
> +# or entity, or to disclaim their copyright. The empty string stands for
> +# the public domain; in this case the translators are expected to disclaim
> +# their copyright.
> +COPYRIGHT_HOLDER = Free Software Foundation, Inc.
> +
> +# This is the list of locale categories, beyond LC_MESSAGES, for which the
> +# message catalogs shall be used. It is usually empty.
> +EXTRA_LOCALE_CATEGORIES =
> diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
> new file mode 100644
> index 0000000..7e97a11
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "GTK Performance tool"
> +DESCRIPTION = "GTK Performance tools"
Don't duplicate SUMMARY (extra 's' doesn't count)
> +SECTION = "libs"
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> +
> +SRC_URI = "http://prdownloads.sourceforge.net/gtkperf/gtkperf_${PV}.tar.gz \
gtkperf -> ${BPN}
> + file://Makevars"
> +
> +SRC_URI[md5sum] = "4331dde4bb83865e15482885fcb0cc53"
> +SRC_URI[sha256sum] = "9704344e732038eecbd007dd996a56293a6b027b5b76f3f036273a3fae1ab27b"
> +
> +S = "${WORKDIR}/gtkperf"
gtkperf -> ${BPN}
> +
> +inherit autotools binconfig pkgconfig gettext
> +
> +do_configure_prepend () {
> + rm -f ${S}/m4/init.m4
> + cp -f ${WORKDIR}/Makevars ${S}/po/
Please use consistent indentation: tab -> 4 spaces
> +}
> +
> +do_install_append () {
> + rm -rf ${WORKDIR}/image/usr/doc
Please use consistent indentation: 5 spaces -> 4 spaces
${WORKDIR}/image -> ${D}
> +}
> +
> +FILES_${PN} += "${exec_prefix}/share/duck.png"
${exec_prefix}/share -> ${datadir}
I've made above modifications when cherry-picking from patchwork to
master-next, so don't send v2 (unless you need to change something else
as well)
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [meta-oe][PATCH 6/7] vlan: Create 1.9 version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
` (3 preceding siblings ...)
2014-03-07 21:26 ` [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-11 14:17 ` Martin Jansa
2014-03-07 21:26 ` [meta-oe][PATCH 7/7] openobex: Remove --enable-dump to disable dumping Lauren Post
2014-03-28 18:00 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Denys Dmytriyenko
6 siblings, 1 reply; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
VLAN provides vconfig utility
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
.../recipes-connectivity/vlan/vlan_1.9.bb | 25 ++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
diff --git a/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
new file mode 100644
index 0000000..a9711ed
--- /dev/null
+++ b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
@@ -0,0 +1,25 @@
+DESCRIPTION = "VLAN provides vconfig utility"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://vconfig.c;md5=293ef69c4e88434d37a5ee577a5288cb"
+
+SRC_URI = "http://vlan.sourcearchive.com/downloads/1.9-3ubuntu9/vlan_1.9.orig.tar.gz"
+
+SRC_URI[md5sum] = "5f0c6060b33956fb16e11a15467dd394"
+SRC_URI[sha256sum] = "3b8f0a1bf0d3642764e5f646e1f3bbc8b1eeec474a77392d9aeb4868842b4cca"
+
+S = "${WORKDIR}/vlan"
+
+# comment out MakeInclude in Makefile which sets build environment
+do_configure_append () {
+ sed -i 's/^ include/#^include/' ${S}/Makefile
+}
+
+# ignore strip to avoid yocto errors in stripping
+do_compile () {
+ oe_runmake PLATFORM=ARM 'STRIP=echo' all
+}
+
+do_install () {
+ install -d ${D}/${exec_prefix}/bin
+ cp ${S}/vconfig ${D}/${exec_prefix}/bin
+}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 6/7] vlan: Create 1.9 version
2014-03-07 21:26 ` [meta-oe][PATCH 6/7] vlan: Create 1.9 version Lauren Post
@ 2014-03-11 14:17 ` Martin Jansa
2014-03-17 16:26 ` Otavio Salvador
0 siblings, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2014-03-11 14:17 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
On Fri, Mar 07, 2014 at 03:26:14PM -0600, Lauren Post wrote:
> VLAN provides vconfig utility
>
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
> .../recipes-connectivity/vlan/vlan_1.9.bb | 25 ++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
>
> diff --git a/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
> new file mode 100644
> index 0000000..a9711ed
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
> @@ -0,0 +1,25 @@
> +DESCRIPTION = "VLAN provides vconfig utility"
DESCRIPTION -> SUMMARY
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://vconfig.c;md5=293ef69c4e88434d37a5ee577a5288cb"
> +
> +SRC_URI = "http://vlan.sourcearchive.com/downloads/1.9-3ubuntu9/vlan_1.9.orig.tar.gz"
vlan -> ${BPN}
1.9 -> ${PV}
> +
> +SRC_URI[md5sum] = "5f0c6060b33956fb16e11a15467dd394"
> +SRC_URI[sha256sum] = "3b8f0a1bf0d3642764e5f646e1f3bbc8b1eeec474a77392d9aeb4868842b4cca"
> +
> +S = "${WORKDIR}/vlan"
vlan -> ${BPN}
> +
> +# comment out MakeInclude in Makefile which sets build environment
> +do_configure_append () {
> + sed -i 's/^ include/#^include/' ${S}/Makefile
> +}
> +
> +# ignore strip to avoid yocto errors in stripping
> +do_compile () {
> + oe_runmake PLATFORM=ARM 'STRIP=echo' all
> +}
> +
> +do_install () {
> + install -d ${D}/${exec_prefix}/bin
> + cp ${S}/vconfig ${D}/${exec_prefix}/bin
5 spaces -> 4 spaces
I'll modify above comments when cherry-picking to master-next.
> +}
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 6/7] vlan: Create 1.9 version
2014-03-11 14:17 ` Martin Jansa
@ 2014-03-17 16:26 ` Otavio Salvador
2014-03-17 17:24 ` Martin Jansa
0 siblings, 1 reply; 20+ messages in thread
From: Otavio Salvador @ 2014-03-17 16:26 UTC (permalink / raw)
To: OpenEmbedded Devel List
Hello Martin,
On Tue, Mar 11, 2014 at 11:17 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Mar 07, 2014 at 03:26:14PM -0600, Lauren Post wrote:
>> VLAN provides vconfig utility
>>
>> Signed-off-by: Lauren Post <lauren.post@freescale.com>
>> ---
>> .../recipes-connectivity/vlan/vlan_1.9.bb | 25 ++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>> create mode 100644 meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
>>
>> diff --git a/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
>> new file mode 100644
>> index 0000000..a9711ed
>> --- /dev/null
>> +++ b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
>> @@ -0,0 +1,25 @@
>> +DESCRIPTION = "VLAN provides vconfig utility"
>
> DESCRIPTION -> SUMMARY
>
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://vconfig.c;md5=293ef69c4e88434d37a5ee577a5288cb"
>> +
>> +SRC_URI = "http://vlan.sourcearchive.com/downloads/1.9-3ubuntu9/vlan_1.9.orig.tar.gz"
>
> vlan -> ${BPN}
> 1.9 -> ${PV}
>
>> +
>> +SRC_URI[md5sum] = "5f0c6060b33956fb16e11a15467dd394"
>> +SRC_URI[sha256sum] = "3b8f0a1bf0d3642764e5f646e1f3bbc8b1eeec474a77392d9aeb4868842b4cca"
>> +
>> +S = "${WORKDIR}/vlan"
>
> vlan -> ${BPN}
>
>> +
>> +# comment out MakeInclude in Makefile which sets build environment
>> +do_configure_append () {
>> + sed -i 's/^ include/#^include/' ${S}/Makefile
>> +}
>> +
>> +# ignore strip to avoid yocto errors in stripping
>> +do_compile () {
>> + oe_runmake PLATFORM=ARM 'STRIP=echo' all
>> +}
>> +
>> +do_install () {
>> + install -d ${D}/${exec_prefix}/bin
>> + cp ${S}/vconfig ${D}/${exec_prefix}/bin
>
> 5 spaces -> 4 spaces
>
> I'll modify above comments when cherry-picking to master-next.
So I assume this one does not need a v2. Am I right?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 6/7] vlan: Create 1.9 version
2014-03-17 16:26 ` Otavio Salvador
@ 2014-03-17 17:24 ` Martin Jansa
0 siblings, 0 replies; 20+ messages in thread
From: Martin Jansa @ 2014-03-17 17:24 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2379 bytes --]
On Mon, Mar 17, 2014 at 01:26:21PM -0300, Otavio Salvador wrote:
> Hello Martin,
>
> On Tue, Mar 11, 2014 at 11:17 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Fri, Mar 07, 2014 at 03:26:14PM -0600, Lauren Post wrote:
> >> VLAN provides vconfig utility
> >>
> >> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> >> ---
> >> .../recipes-connectivity/vlan/vlan_1.9.bb | 25 ++++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >> create mode 100644 meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
> >>
> >> diff --git a/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
> >> new file mode 100644
> >> index 0000000..a9711ed
> >> --- /dev/null
> >> +++ b/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb
> >> @@ -0,0 +1,25 @@
> >> +DESCRIPTION = "VLAN provides vconfig utility"
> >
> > DESCRIPTION -> SUMMARY
> >
> >> +LICENSE = "GPLv2"
> >> +LIC_FILES_CHKSUM = "file://vconfig.c;md5=293ef69c4e88434d37a5ee577a5288cb"
> >> +
> >> +SRC_URI = "http://vlan.sourcearchive.com/downloads/1.9-3ubuntu9/vlan_1.9.orig.tar.gz"
> >
> > vlan -> ${BPN}
> > 1.9 -> ${PV}
> >
> >> +
> >> +SRC_URI[md5sum] = "5f0c6060b33956fb16e11a15467dd394"
> >> +SRC_URI[sha256sum] = "3b8f0a1bf0d3642764e5f646e1f3bbc8b1eeec474a77392d9aeb4868842b4cca"
> >> +
> >> +S = "${WORKDIR}/vlan"
> >
> > vlan -> ${BPN}
> >
> >> +
> >> +# comment out MakeInclude in Makefile which sets build environment
> >> +do_configure_append () {
> >> + sed -i 's/^ include/#^include/' ${S}/Makefile
> >> +}
> >> +
> >> +# ignore strip to avoid yocto errors in stripping
> >> +do_compile () {
> >> + oe_runmake PLATFORM=ARM 'STRIP=echo' all
> >> +}
> >> +
> >> +do_install () {
> >> + install -d ${D}/${exec_prefix}/bin
> >> + cp ${S}/vconfig ${D}/${exec_prefix}/bin
> >
> > 5 spaces -> 4 spaces
> >
> > I'll modify above comments when cherry-picking to master-next.
>
> So I assume this one does not need a v2. Am I right?
Yes, it's already modified in:
http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=095fbd60d7b0b59558e49b97a20814d34626084e
so it doesn't need v2.
Other patches where I didn't say that I'll do the changes when
cherry-picking need v2.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [meta-oe][PATCH 7/7] openobex: Remove --enable-dump to disable dumping
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
` (4 preceding siblings ...)
2014-03-07 21:26 ` [meta-oe][PATCH 6/7] vlan: Create 1.9 version Lauren Post
@ 2014-03-07 21:26 ` Lauren Post
2014-03-28 18:00 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Denys Dmytriyenko
6 siblings, 0 replies; 20+ messages in thread
From: Lauren Post @ 2014-03-07 21:26 UTC (permalink / raw)
To: openembedded-devel
This features slows down performance and should only be
enabled when debugging openobex.
Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
meta-oe/recipes-connectivity/obex/openobex_1.5.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-connectivity/obex/openobex_1.5.bb b/meta-oe/recipes-connectivity/obex/openobex_1.5.bb
index c62c5aa..0d5cfef 100644
--- a/meta-oe/recipes-connectivity/obex/openobex_1.5.bb
+++ b/meta-oe/recipes-connectivity/obex/openobex_1.5.bb
@@ -17,7 +17,7 @@ SRC_URI[sha256sum] = "e602047570799a47ecb028420bda8f2cef41310e5a99d084de10aa9422
inherit autotools binconfig pkgconfig
-EXTRA_OECONF = "--enable-apps --enable-syslog --enable-dump \
+EXTRA_OECONF = "--enable-apps --enable-syslog \
--with-usb=${STAGING_LIBDIR}/.. --with-bluez=${STAGING_LIBDIR}/.."
do_install_append() {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version
2014-03-07 21:26 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Lauren Post
` (5 preceding siblings ...)
2014-03-07 21:26 ` [meta-oe][PATCH 7/7] openobex: Remove --enable-dump to disable dumping Lauren Post
@ 2014-03-28 18:00 ` Denys Dmytriyenko
2014-03-29 18:40 ` Otavio Salvador
6 siblings, 1 reply; 20+ messages in thread
From: Denys Dmytriyenko @ 2014-03-28 18:00 UTC (permalink / raw)
To: openembedded-devel
On Fri, Mar 07, 2014 at 03:26:09PM -0600, Lauren Post wrote:
> Precision Time Protocol (PTP) according to IEEE standard 1588
Heh, another instance of "duplication" - I also have a similar recipe in my
layer... Well, I do understand that "the early bird gets the worm" or the
first submitter gets his change merged, but let me point out few issues:
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
> .../recipes-connectivity/linuxptp/linuxptp_1.4.bb | 26 ++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
>
> diff --git a/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
> new file mode 100644
> index 0000000..c708b13
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "Precision Time Protocol (PTP) according to IEEE standard 1588 for Linux"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +DEPENDS = "virtual/kernel"
> +
> +SRC_URI = "http://sourceforge.net/projects/linuxptp/files/v${PV}/linuxptp-${PV}.tgz"
> +
> +SRC_URI[md5sum] = "a37ad2b2ef7d1ebc4d64a66d3fe55cdf"
> +SRC_URI[sha256sum] = "6cfd5291fb7394cc9f25458927874a203971b66b76d1c9d6568e007d0cbd81f2"
> +
> +inherit autotools pkgconfig
It's easy to see that linuxptp build doesn't really use autotools or pkgconfig
> +EXTRA_OEMAKE = 'KBUILD_OUTPUT="${STAGING_KERNEL_DIR}" CROSS_COMPILE="${TARGET_PREFIX}"'
> +
> +do_configure_append () {
> + find ${S} -name makefile | xargs sed -i 's,^\(CC\|CFLAGS\|prefix\|AR\)=,\1 ?=,g'
Why do you need to mangle the makefile? Passing CROSS_COMPILE and maybe ARCH
should be enough, isn't it?
> +}
> +
> +do_install () {
> + install -d ${D}/${bindir}
> + install -p ${S}/ptp4l ${D}/${bindir}
> + install -p ${S}/pmc ${D}/${bindir}
> + install -p ${S}/phc2sys ${D}/${bindir}
> + install -p ${S}/hwstamp_ctl ${D}/${bindir}
> +}
And the last bit about dependency on virtual/kernel above and passing
KBUILD_OUTPUT=STAGING_KERNEL_DIR to the build - I have looked into what that
does and it tries to locate the correct /usr/include/linux/net_tstamp.h just
to see if it contains definition for HWTSTAMP_TX_ONESTEP_SYNC. But that header
file hasn't changed in at least 5 years. Anyway, the result of the check is to
pass some defines to their build. I ended up just short-cutting the check and
avoid unnecessary dependency on virtual/kernel:
EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} ARCH=${TARGET_ARCH} \
EXTRA_CFLAGS='-D_GNU_SOURCE -DHAVE_CLOCK_ADJTIME \
-DHAVE_ONESTEP_SYNC'"
Should I submit a patch to fix the above issues?
--
Denys
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version
2014-03-28 18:00 ` [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version Denys Dmytriyenko
@ 2014-03-29 18:40 ` Otavio Salvador
2014-03-29 21:08 ` Denys Dmytriyenko
0 siblings, 1 reply; 20+ messages in thread
From: Otavio Salvador @ 2014-03-29 18:40 UTC (permalink / raw)
To: OpenEmbedded Devel List
Hello Denys,
On Fri, Mar 28, 2014 at 3:00 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Fri, Mar 07, 2014 at 03:26:09PM -0600, Lauren Post wrote:
>> Precision Time Protocol (PTP) according to IEEE standard 1588
>
> Heh, another instance of "duplication" - I also have a similar recipe in my
> layer... Well, I do understand that "the early bird gets the worm" or the
> first submitter gets his change merged, but let me point out few issues:
This is the price of 'late upstreaming' :-(
>> Signed-off-by: Lauren Post <lauren.post@freescale.com>
>> ---
>> .../recipes-connectivity/linuxptp/linuxptp_1.4.bb | 26 ++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
>>
>> diff --git a/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
>> new file mode 100644
>> index 0000000..c708b13
>> --- /dev/null
>> +++ b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
>> @@ -0,0 +1,26 @@
>> +DESCRIPTION = "Precision Time Protocol (PTP) according to IEEE standard 1588 for Linux"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +DEPENDS = "virtual/kernel"
>> +
>> +SRC_URI = "http://sourceforge.net/projects/linuxptp/files/v${PV}/linuxptp-${PV}.tgz"
>> +
>> +SRC_URI[md5sum] = "a37ad2b2ef7d1ebc4d64a66d3fe55cdf"
>> +SRC_URI[sha256sum] = "6cfd5291fb7394cc9f25458927874a203971b66b76d1c9d6568e007d0cbd81f2"
>> +
>> +inherit autotools pkgconfig
>
> It's easy to see that linuxptp build doesn't really use autotools or pkgconfig
What you suggest here?
>> +EXTRA_OEMAKE = 'KBUILD_OUTPUT="${STAGING_KERNEL_DIR}" CROSS_COMPILE="${TARGET_PREFIX}"'
>> +
>> +do_configure_append () {
>> + find ${S} -name makefile | xargs sed -i 's,^\(CC\|CFLAGS\|prefix\|AR\)=,\1 ?=,g'
>
> Why do you need to mangle the makefile? Passing CROSS_COMPILE and maybe ARCH
> should be enough, isn't it?
In fact I guess we do. Otherwise the build system won't use the build
flags we expect, will it?
>> +}
>> +
>> +do_install () {
>> + install -d ${D}/${bindir}
>> + install -p ${S}/ptp4l ${D}/${bindir}
>> + install -p ${S}/pmc ${D}/${bindir}
>> + install -p ${S}/phc2sys ${D}/${bindir}
>> + install -p ${S}/hwstamp_ctl ${D}/${bindir}
>> +}
>
> And the last bit about dependency on virtual/kernel above and passing
> KBUILD_OUTPUT=STAGING_KERNEL_DIR to the build - I have looked into what that
> does and it tries to locate the correct /usr/include/linux/net_tstamp.h just
> to see if it contains definition for HWTSTAMP_TX_ONESTEP_SYNC. But that header
> file hasn't changed in at least 5 years. Anyway, the result of the check is to
> pass some defines to their build. I ended up just short-cutting the check and
> avoid unnecessary dependency on virtual/kernel:
Oh good hint here. This is indeed a nice boost in build and avoids
rebuild when kernel changes.
Could you share this change?
> EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} ARCH=${TARGET_ARCH} \
> EXTRA_CFLAGS='-D_GNU_SOURCE -DHAVE_CLOCK_ADJTIME \
> -DHAVE_ONESTEP_SYNC'"
>
> Should I submit a patch to fix the above issues?
This is up to Lauren ... I am fine either way ...
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [meta-oe][PATCH 1/7] linuxptp: Create 1.4 version
2014-03-29 18:40 ` Otavio Salvador
@ 2014-03-29 21:08 ` Denys Dmytriyenko
0 siblings, 0 replies; 20+ messages in thread
From: Denys Dmytriyenko @ 2014-03-29 21:08 UTC (permalink / raw)
To: openembedded-devel
On Sat, Mar 29, 2014 at 03:40:30PM -0300, Otavio Salvador wrote:
> Hello Denys,
>
> On Fri, Mar 28, 2014 at 3:00 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Fri, Mar 07, 2014 at 03:26:09PM -0600, Lauren Post wrote:
> >> Precision Time Protocol (PTP) according to IEEE standard 1588
> >
> > Heh, another instance of "duplication" - I also have a similar recipe in my
> > layer... Well, I do understand that "the early bird gets the worm" or the
> > first submitter gets his change merged, but let me point out few issues:
>
> This is the price of 'late upstreaming' :-(
Understood, see above :) There are many other factors involved, but we are
trying to improve in this regard...
> >> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> >> ---
> >> .../recipes-connectivity/linuxptp/linuxptp_1.4.bb | 26 ++++++++++++++++++++
> >> 1 file changed, 26 insertions(+)
> >> create mode 100644 meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
> >>
> >> diff --git a/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
> >> new file mode 100644
> >> index 0000000..c708b13
> >> --- /dev/null
> >> +++ b/meta-oe/recipes-connectivity/linuxptp/linuxptp_1.4.bb
> >> @@ -0,0 +1,26 @@
> >> +DESCRIPTION = "Precision Time Protocol (PTP) according to IEEE standard 1588 for Linux"
> >> +LICENSE = "GPLv2"
> >> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> +
> >> +DEPENDS = "virtual/kernel"
> >> +
> >> +SRC_URI = "http://sourceforge.net/projects/linuxptp/files/v${PV}/linuxptp-${PV}.tgz"
> >> +
> >> +SRC_URI[md5sum] = "a37ad2b2ef7d1ebc4d64a66d3fe55cdf"
> >> +SRC_URI[sha256sum] = "6cfd5291fb7394cc9f25458927874a203971b66b76d1c9d6568e007d0cbd81f2"
> >> +
> >> +inherit autotools pkgconfig
> >
> > It's easy to see that linuxptp build doesn't really use autotools or pkgconfig
>
> What you suggest here?
Obviously, drop that line altogether :) There's nothing to inherit here.
> >> +EXTRA_OEMAKE = 'KBUILD_OUTPUT="${STAGING_KERNEL_DIR}" CROSS_COMPILE="${TARGET_PREFIX}"'
> >> +
> >> +do_configure_append () {
> >> + find ${S} -name makefile | xargs sed -i 's,^\(CC\|CFLAGS\|prefix\|AR\)=,\1 ?=,g'
> >
> > Why do you need to mangle the makefile? Passing CROSS_COMPILE and maybe ARCH
> > should be enough, isn't it?
>
> In fact I guess we do. Otherwise the build system won't use the build
> flags we expect, will it?
What about "prefix" then?
> >> +}
> >> +
> >> +do_install () {
> >> + install -d ${D}/${bindir}
> >> + install -p ${S}/ptp4l ${D}/${bindir}
> >> + install -p ${S}/pmc ${D}/${bindir}
> >> + install -p ${S}/phc2sys ${D}/${bindir}
> >> + install -p ${S}/hwstamp_ctl ${D}/${bindir}
> >> +}
> >
> > And the last bit about dependency on virtual/kernel above and passing
> > KBUILD_OUTPUT=STAGING_KERNEL_DIR to the build - I have looked into what that
> > does and it tries to locate the correct /usr/include/linux/net_tstamp.h just
> > to see if it contains definition for HWTSTAMP_TX_ONESTEP_SYNC. But that header
> > file hasn't changed in at least 5 years. Anyway, the result of the check is to
> > pass some defines to their build. I ended up just short-cutting the check and
> > avoid unnecessary dependency on virtual/kernel:
>
> Oh good hint here. This is indeed a nice boost in build and avoids
> rebuild when kernel changes.
>
> Could you share this change?
Sure, I can send a patch to address the above.
--
Denys
^ permalink raw reply [flat|nested] 20+ messages in thread