From: Richard Purdie <rpurdie@linux.intel.com>
To: Qing He <qing.he@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Sun, 28 Nov 2010 14:22:46 +0000 [thread overview]
Message-ID: <1290954166.27143.217.camel@rex> (raw)
In-Reply-To: <a03c4017a13bda3f20b8f39a4c099cb28f349968.1289982751.git.qing.he@intel.com>
On Wed, 2010-11-17 at 16:26 +0800, Qing He wrote:
> @@ -25,6 +24,10 @@ EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \
> --enable-crypto-auth \
> "
>
> +EXTRA_OECONF_append = " --with-gnutls=${STAGING_LIBDIR}/../"
> +EXTRA_OECONF_virtclass-native_append = " --without-gnutls"
> +EXTRA_OECONF_virtclass-nativesdk_append = " --without-gnutls"
> +
> do_configure_prepend() {
> sed -i s:OPT_GNUTLS/bin:OPT_GNUTLS:g configure.ac
> }
I'm going to push a fix but I wanted to note that the above is not
correct. Let me walk through this since I expect various people find
this confusing.
EXTRA_OECONF_virtclass-native_append = "X"
means append "X" to the variable EXTRA_OECONF_virtclass-native
So as bitbake expands this,
EXTRA_OECONF_virtclass-native = "X" (since EXTRA_OECONF_virtclass-native
was empty)
When bitbake expands overrides, the virtclass-native can be removed and
this overwrites the original EXTRA_OECONF variable so EXTRA_OECONF
becomes just X.
Now taking:
EXTRA_OECONF_append_virtclass-native = "X"
This is different. In this case, when overrides are expanded, this
becomes EXTRA_OECONF_append and then X is added to EXTRA_OECONF.
If the virtclass-native is never expanded (not in OVERRIDES), the append
is never "seen" by bitbake.
Unfortunately rewriting the above to:
EXTRA_OECONF_append = " --with-gnutls=${STAGING_LIBDIR}/../"
EXTRA_OECONF_append_virtclass-native = " --without-gnutls"
EXTRA_OECONF_append_virtclass-nativesdk = " --without-gnutls"
doesn't help since we end up with two appends in the native/nativesdk
cases. There is a way out of this though:
+CURLGNUTLS = " --with-gnutls=${STAGING_LIBDIR}/../"
+CURLGNUTLS_virtclass-native = "--without-gnutls"
+CURLGNUTLS_virtclass-nativesdk = "--without-gnutls"
and then reference CURLGNUTLS in EXTRA_OECONF which is what my update
does :)
Cheers,
Richard
next prev parent reply other threads:[~2010-11-28 21:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17 8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22 ` Richard Purdie [this message]
2010-11-29 5:26 ` Tian, Kevin
2010-11-29 5:53 ` Chris Larson
2010-11-29 5:58 ` Tian, Kevin
2010-11-29 12:25 ` Richard Purdie
2010-11-29 13:04 ` Frans Meulenbroeks
2010-11-29 15:17 ` Richard Purdie
2010-12-05 9:48 ` Tian, Kevin
2010-11-29 15:24 ` Chris Larson
2010-12-05 9:32 ` Tian, Kevin
2010-12-06 1:04 ` Richard Purdie
2010-12-07 7:55 ` Tian, Kevin
2010-12-07 12:37 ` Richard Purdie
2010-12-08 3:12 ` Qing He
2010-12-09 15:16 ` Richard Purdie
2010-12-13 5:52 ` Qing He
2010-12-13 10:48 ` Qing He
2010-11-30 1:44 ` Qing He
2010-12-05 9:43 ` Tian, Kevin
2010-12-06 1:10 ` Richard Purdie
2010-12-07 7:56 ` Tian, Kevin
2010-11-29 8:17 ` Qing He
2010-11-29 11:57 ` Richard Purdie
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26 ` Scott Garman
2010-11-19 22:43 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290954166.27143.217.camel@rex \
--to=rpurdie@linux.intel.com \
--cc=poky@yoctoproject.org \
--cc=qing.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox