Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Chris Larson <clarson@kergoth.com>,
	"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Tue, 07 Dec 2010 12:37:35 +0000	[thread overview]
Message-ID: <1291725455.11475.10.camel@rex> (raw)
In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1504D47543B3B@shsmsx502.ccr.corp.intel.com>

On Tue, 2010-12-07 at 15:55 +0800, Tian, Kevin wrote:
> >From: Richard Purdie [mailto:rpurdie@linux.intel.com]
> >http://git.pokylinux.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/bitbake&id=c77410305f
> >e736aa195ce720c8317b39da057052
> 
> yes, that looks a clear fix.

In the absence of Chris saying no, I've merged this into Poky so it
doesn't get lost.

> Actually my original thought was a little bit different. Atm I thought that only one
> appendix should take effect, i.e:
> 
> FOO = "A"
> FOO_append_OVERA = "B"
> FOO_append_OVERB = "C"
> 
> If OVERB is higher priority than OVERA, the result would be "AC" then.
> 
> Now obviously my earlier thought is wrong. Every _append appends a new
> value if the override is valid. :-)

Right, there is just the question of ordering.

> I also thought that there's no ordering constraint in this design. either "A B C"
> or "A C B" could work, unless the appendix itself has order constraint, say 
> a patch sequence. But I'm not sure whether there's real usage and we need
> to handle it or not.

I think its not something we should worry too much about, just something
to be aware of.

I do still think we should support FOO_append_OVERA_OVERB_OVERC though
perhaps we should leave a bug open on that?

Cheers,

Richard



  reply	other threads:[~2010-12-07 12:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17  8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22   ` Richard Purdie
2010-11-29  5:26     ` Tian, Kevin
2010-11-29  5:53       ` Chris Larson
2010-11-29  5:58         ` Tian, Kevin
2010-11-29 12:25         ` Richard Purdie
2010-11-29 13:04           ` Frans Meulenbroeks
2010-11-29 15:17             ` Richard Purdie
2010-12-05  9:48               ` Tian, Kevin
2010-11-29 15:24           ` Chris Larson
2010-12-05  9:32             ` Tian, Kevin
2010-12-06  1:04               ` Richard Purdie
2010-12-07  7:55                 ` Tian, Kevin
2010-12-07 12:37                   ` Richard Purdie [this message]
2010-12-08  3:12                     ` Qing He
2010-12-09 15:16                       ` Richard Purdie
2010-12-13  5:52                         ` Qing He
2010-12-13 10:48                           ` Qing He
2010-11-30  1:44           ` Qing He
2010-12-05  9:43             ` Tian, Kevin
2010-12-06  1:10               ` Richard Purdie
2010-12-07  7:56                 ` Tian, Kevin
2010-11-29  8:17     ` Qing He
2010-11-29 11:57       ` Richard Purdie
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26   ` Scott Garman
2010-11-19 22:43     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291725455.11475.10.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=kevin.tian@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox