Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: Qing He <qing.he@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>,
	Chris Larson <clarson@kergoth.com>
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Thu, 09 Dec 2010 15:16:12 +0000	[thread overview]
Message-ID: <1291907772.1554.894.camel@rex> (raw)
In-Reply-To: <20101208031204.GA20033@qhe2-db>

On Wed, 2010-12-08 at 11:12 +0800, Qing He wrote:
> Thank you for the fix, I've been looking the smart data section
> recently, and the rationale becomes much clearer to me.
> 
> However, the following case still has some confusion:
> 
> FOO = "A"
> FOO_append = "B"
> FOO_virtclass-native = "C"
> 
> when in virtclass-native, the output is simply "C", instead of "CB"
> as I expected

This is a tricky one. It would be interesting to see if this applies
with other overrides such as MACHINE. The reason I say that is the way
the virtclass-native override is added (see native.bbclass).

> > > I also thought that there's no ordering constraint in this design. either "A B C"
> > > or "A C B" could work, unless the appendix itself has order constraint, say 
> > > a patch sequence. But I'm not sure whether there's real usage and we need
> > > to handle it or not.
> > 
> > I think its not something we should worry too much about, just something
> > to be aware of.
> 
> There is some occasion where the ordering may matter, for example, CFLAGS
> (and some other command line options). But even this may avoid the need of
> predicatable order if we are careful.

Right, there are cases it will matter like patch application but we just
need to be sensitive to that when writing metadata.

> > I do still think we should support FOO_append_OVERA_OVERB_OVERC though
> > perhaps we should leave a bug open on that?
> 
> This question also arose when I read the code, then I realize that
> FOO_append_OVERA_OVERB_OVERC doesn't work in current design. Previously
> I expected something like a staged handling, i.e. peeling off the
> append/prepend first, and then handling override, but actually they are
> not that loosely coupled.

I'd also actually thought the code worked differently to how it does
before I looked at it!

> That said, it seems supporting multiple overrides in append is still
> ok, I tried to sketch a patch as follow, seems work for
> FOO_append_virtclass-native_qemux86 = "C"

This looks reasonable. In python you should used "True" and "False"
instead of "1" and "0".

I've just mentally been asking myself what if this was a variable like
SRC_URI where the name contains an "_" but since we don't allow
overrides to contain the character, I think we're safe.

I also think you can simplify the logic slightly to be:

+                            for override in o.split('_'):
+                                if not override in overrides:
+                                    keep.append((a ,o)) 
+                                    continue

?

Cheers,

Richard

> ---
> diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
> index c8cd8f8..116ea10 100644
> --- a/bitbake/lib/bb/data_smart.py
> +++ b/bitbake/lib/bb/data_smart.py
> @@ -160,9 +160,15 @@ class DataSmart:
>                  for append in appends:
>                      keep = []
>                      for (a, o) in self.getVarFlag(append, op) or []:
> -                        if o and not o in overrides:
> -                            keep.append((a ,o))
> -                            continue
> +                        if o:
> +                            applicable = 1
> +                            for override in o.split('_'):
> +                                if not override in overrides:
> +                                    applicable = 0
> +                                    break
> +                            if not applicable:
> +                                keep.append((a ,o))
> +                                continue
>  
>                          if op is "_append":
>                              sval = self.getVar(append, False) or ""
> ---
> 
> 
> Thanks,
> Qing
> 




  reply	other threads:[~2010-12-09 15:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17  8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22   ` Richard Purdie
2010-11-29  5:26     ` Tian, Kevin
2010-11-29  5:53       ` Chris Larson
2010-11-29  5:58         ` Tian, Kevin
2010-11-29 12:25         ` Richard Purdie
2010-11-29 13:04           ` Frans Meulenbroeks
2010-11-29 15:17             ` Richard Purdie
2010-12-05  9:48               ` Tian, Kevin
2010-11-29 15:24           ` Chris Larson
2010-12-05  9:32             ` Tian, Kevin
2010-12-06  1:04               ` Richard Purdie
2010-12-07  7:55                 ` Tian, Kevin
2010-12-07 12:37                   ` Richard Purdie
2010-12-08  3:12                     ` Qing He
2010-12-09 15:16                       ` Richard Purdie [this message]
2010-12-13  5:52                         ` Qing He
2010-12-13 10:48                           ` Qing He
2010-11-30  1:44           ` Qing He
2010-12-05  9:43             ` Tian, Kevin
2010-12-06  1:10               ` Richard Purdie
2010-12-07  7:56                 ` Tian, Kevin
2010-11-29  8:17     ` Qing He
2010-11-29 11:57       ` Richard Purdie
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26   ` Scott Garman
2010-11-19 22:43     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291907772.1554.894.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=poky@yoctoproject.org \
    --cc=qing.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox