Poky Project Discussions
 help / color / mirror / Atom feed
From: Qing He <qing.he@intel.com>
To: Richard Purdie <rpurdie@linux.intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>,
	Chris Larson <clarson@kergoth.com>
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Mon, 13 Dec 2010 13:52:02 +0800	[thread overview]
Message-ID: <20101213055202.GA19053@qhe2-db> (raw)
In-Reply-To: <1291907772.1554.894.camel@rex>

On Thu, 2010-12-09 at 23:16 +0800, Richard Purdie wrote:
> On Wed, 2010-12-08 at 11:12 +0800, Qing He wrote:
> > Thank you for the fix, I've been looking the smart data section
> > recently, and the rationale becomes much clearer to me.
> > 
> > However, the following case still has some confusion:
> > 
> > FOO = "A"
> > FOO_append = "B"
> > FOO_virtclass-native = "C"
> > 
> > when in virtclass-native, the output is simply "C", instead of "CB"
> > as I expected
> 
> This is a tricky one. It would be interesting to see if this applies
> with other overrides such as MACHINE. The reason I say that is the way
> the virtclass-native override is added (see native.bbclass).

So you mean this is intended? The FOO_append is meant to be hidden by
the use of an override? I'd rather have expected something like this:

---
diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
index c8cd8f8..3e4c710 100644
--- a/bitbake/lib/bb/data_smart.py
+++ b/bitbake/lib/bb/data_smart.py
@@ -149,6 +149,11 @@ class DataSmart:
             for var in vars:
                 name = var[:-l]
                 try:
+                    for op in __setvar_keyword__:
+                        if op in self[name]:
+                            sval = self.getVarFlag(name, op, False)
+                            self.setVarFlag(var, op, sval)
+
                     self[name] = self[var]
                 except Exception:
                     bb.msg.note(1, bb.msg.domain.Data, "Untracked delVar")

---


> SRC_URI where the name contains an "_" but since we don't allow
> overrides to contain the character, I think we're safe.
> 
> I also think you can simplify the logic slightly to be:
> 
> +                            for override in o.split('_'):
> +                                if not override in overrides:
> +                                    keep.append((a ,o)) 
> +                                    continue
> 
> ?
> 

This `continue' falls into the scope of `for override in o.split'
instead of the former one, chances are the (a, o) can be appended
more than once if multiple overrides not present.

Thanks,
Qing


  reply	other threads:[~2010-12-13  5:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17  8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22   ` Richard Purdie
2010-11-29  5:26     ` Tian, Kevin
2010-11-29  5:53       ` Chris Larson
2010-11-29  5:58         ` Tian, Kevin
2010-11-29 12:25         ` Richard Purdie
2010-11-29 13:04           ` Frans Meulenbroeks
2010-11-29 15:17             ` Richard Purdie
2010-12-05  9:48               ` Tian, Kevin
2010-11-29 15:24           ` Chris Larson
2010-12-05  9:32             ` Tian, Kevin
2010-12-06  1:04               ` Richard Purdie
2010-12-07  7:55                 ` Tian, Kevin
2010-12-07 12:37                   ` Richard Purdie
2010-12-08  3:12                     ` Qing He
2010-12-09 15:16                       ` Richard Purdie
2010-12-13  5:52                         ` Qing He [this message]
2010-12-13 10:48                           ` Qing He
2010-11-30  1:44           ` Qing He
2010-12-05  9:43             ` Tian, Kevin
2010-12-06  1:10               ` Richard Purdie
2010-12-07  7:56                 ` Tian, Kevin
2010-11-29  8:17     ` Qing He
2010-11-29 11:57       ` Richard Purdie
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26   ` Scott Garman
2010-11-19 22:43     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101213055202.GA19053@qhe2-db \
    --to=qing.he@intel.com \
    --cc=clarson@kergoth.com \
    --cc=poky@yoctoproject.org \
    --cc=rpurdie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox