Re: [PATCH v2 1/5] rust: miscdevice: use vertical import style

["Onur Özkan" <work@onurozkan.dev>]

On Wed, 20 May 2026 10:40:08 +0800
Alvin Sun <alvin.sun@linux.dev> wrote:

> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Alvin Sun <alvin.sun@linux.dev>

Reviewed-by: Onur Özkan <work@onurozkan.dev>

> ---
>  rust/kernel/miscdevice.rs | 34 ++++++++++++++++++++++++++++------
>  1 file changed, 28 insertions(+), 6 deletions(-)
> 
> diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> index c3c2052c92069..05a6b6b9770f2 100644
> --- a/rust/kernel/miscdevice.rs
> +++ b/rust/kernel/miscdevice.rs
> @@ -11,16 +11,38 @@
>  use crate::{
>      bindings,
>      device::Device,
> -    error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR},
> -    ffi::{c_int, c_long, c_uint, c_ulong},
> -    fs::{File, Kiocb},
> -    iov::{IovIterDest, IovIterSource},
> +    error::{
> +        to_result,
> +        Error,
> +        Result,
> +        VTABLE_DEFAULT_ERROR, //
> +    },
> +    ffi::{
> +        c_int,
> +        c_long,
> +        c_uint,
> +        c_ulong, //
> +    },
> +    fs::{
> +        File,
> +        Kiocb, //
> +    },
> +    iov::{
> +        IovIterDest,
> +        IovIterSource, //
> +    },
>      mm::virt::VmaNew,
>      prelude::*,
>      seq_file::SeqFile,
> -    types::{ForeignOwnable, Opaque},
> +    types::{
> +        ForeignOwnable,
> +        Opaque, //
> +    },
> +};
> +use core::{
> +    marker::PhantomData,
> +    pin::Pin, //
>  };
> -use core::{marker::PhantomData, pin::Pin};
>  
>  /// Options for creating a misc device.
>  #[derive(Copy, Clone)]
> 
> -- 
> 2.43.0
> 
>