Re: [PATCH v2 2/5] samples: rust_misc_device: use vertical import style

["Onur Özkan" <work@onurozkan.dev>]

On Wed, 20 May 2026 10:40:09 +0800
Alvin Sun <alvin.sun@linux.dev> wrote:

> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Alvin Sun <alvin.sun@linux.dev>

Reviewed-by: Onur Özkan <work@onurozkan.dev>

> ---
>  samples/rust/rust_misc_device.rs | 34 ++++++++++++++++++++++++++++------
>  1 file changed, 28 insertions(+), 6 deletions(-)
> 
> diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs
> index 87a1fe63533ae..41e26c825060b 100644
> --- a/samples/rust/rust_misc_device.rs
> +++ b/samples/rust/rust_misc_device.rs
> @@ -97,14 +97,36 @@
>  
>  use kernel::{
>      device::Device,
> -    fs::{File, Kiocb},
> -    ioctl::{_IO, _IOC_SIZE, _IOR, _IOW},
> -    iov::{IovIterDest, IovIterSource},
> -    miscdevice::{MiscDevice, MiscDeviceOptions, MiscDeviceRegistration},
> +    fs::{
> +        File,
> +        Kiocb, //
> +    },
> +    ioctl::{
> +        _IO,
> +        _IOC_SIZE,
> +        _IOR,
> +        _IOW, //
> +    },
> +    iov::{
> +        IovIterDest,
> +        IovIterSource, //
> +    },
> +    miscdevice::{
> +        MiscDevice,
> +        MiscDeviceOptions,
> +        MiscDeviceRegistration, //
> +    },
>      new_mutex,
>      prelude::*,
> -    sync::{aref::ARef, Mutex},
> -    uaccess::{UserSlice, UserSliceReader, UserSliceWriter},
> +    sync::{
> +        aref::ARef,
> +        Mutex, //
> +    },
> +    uaccess::{
> +        UserSlice,
> +        UserSliceReader,
> +        UserSliceWriter, //
> +    },
>  };
>  
>  const RUST_MISC_DEV_HELLO: u32 = _IO('|' as u32, 0x80);
> 
> -- 
> 2.43.0
> 
>