Re: [PATCH v2 4/5] rust: block: mq: use vertical import style

["Onur Özkan" <work@onurozkan.dev>]

On Wed, 20 May 2026 10:40:11 +0800
Alvin Sun <alvin.sun@linux.dev> wrote:

> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Alvin Sun <alvin.sun@linux.dev>

Reviewed-by: Onur Özkan <work@onurozkan.dev>

> ---
>  rust/kernel/block/mq/gen_disk.rs   | 21 +++++++++++++++++----
>  rust/kernel/block/mq/operations.rs | 17 +++++++++++++----
>  rust/kernel/block/mq/request.rs    | 12 +++++++++---
>  rust/kernel/block/mq/tag_set.rs    | 24 +++++++++++++++++++-----
>  4 files changed, 58 insertions(+), 16 deletions(-)
> 
> diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_disk.rs
> index 912cb805caf51..6f599f654f37f 100644
> --- a/rust/kernel/block/mq/gen_disk.rs
> +++ b/rust/kernel/block/mq/gen_disk.rs
> @@ -7,14 +7,27 @@
>  
>  use crate::{
>      bindings,
> -    block::mq::{Operations, TagSet},
> -    error::{self, from_err_ptr, Result},
> -    fmt::{self, Write},
> +    block::mq::{
> +        Operations,
> +        TagSet, //
> +    },
> +    error::{
> +        self,
> +        from_err_ptr,
> +        Result, //
> +    },
> +    fmt::{
> +        self,
> +        Write, //
> +    },
>      prelude::*,
>      static_lock_class,
>      str::NullTerminatedFormatter,
>      sync::Arc,
> -    types::{ForeignOwnable, ScopeGuard},
> +    types::{
> +        ForeignOwnable,
> +        ScopeGuard, //
> +    },
>  };
>  
>  /// A builder for [`GenDisk`].
> diff --git a/rust/kernel/block/mq/operations.rs b/rust/kernel/block/mq/operations.rs
> index 8ad46129a52c4..187b0b7791db9 100644
> --- a/rust/kernel/block/mq/operations.rs
> +++ b/rust/kernel/block/mq/operations.rs
> @@ -6,11 +6,20 @@
>  
>  use crate::{
>      bindings,
> -    block::mq::{request::RequestDataWrapper, Request},
> -    error::{from_result, Result},
> +    block::mq::{
> +        request::RequestDataWrapper,
> +        Request, //
> +    },
> +    error::{
> +        from_result,
> +        Result, //
> +    },
>      prelude::*,
> -    sync::{aref::ARef, Refcount},
> -    types::ForeignOwnable,
> +    sync::{
> +        aref::ARef,
> +        Refcount, //
> +    },
> +    types::ForeignOwnable, //
>  };
>  use core::marker::PhantomData;
>  
> diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
> index ce3e30c81cb5e..4e0579660e906 100644
> --- a/rust/kernel/block/mq/request.rs
> +++ b/rust/kernel/block/mq/request.rs
> @@ -9,13 +9,19 @@
>      block::mq::Operations,
>      error::Result,
>      sync::{
> -        aref::{ARef, AlwaysRefCounted},
> +        aref::{
> +            ARef,
> +            AlwaysRefCounted, //
> +        },
>          atomic::Relaxed,
> -        Refcount,
> +        Refcount, //
>      },
>      types::Opaque,
>  };
> -use core::{marker::PhantomData, ptr::NonNull};
> +use core::{
> +    marker::PhantomData,
> +    ptr::NonNull, //
> +};
>  
>  /// A wrapper around a blk-mq [`struct request`]. This represents an IO request.
>  ///
> diff --git a/rust/kernel/block/mq/tag_set.rs b/rust/kernel/block/mq/tag_set.rs
> index dae9df408a862..c1fd3e047af50 100644
> --- a/rust/kernel/block/mq/tag_set.rs
> +++ b/rust/kernel/block/mq/tag_set.rs
> @@ -8,13 +8,27 @@
>  
>  use crate::{
>      bindings,
> -    block::mq::{operations::OperationsVTable, request::RequestDataWrapper, Operations},
> -    error::{self, Result},
> +    block::mq::{
> +        operations::OperationsVTable,
> +        request::RequestDataWrapper,
> +        Operations, //
> +    },
> +    error::{
> +        self,
> +        Result, //
> +    },
>      prelude::try_pin_init,
> -    types::Opaque,
> +    types::Opaque, //
> +};
> +use core::{
> +    convert::TryInto,
> +    marker::PhantomData, //
> +};
> +use pin_init::{
> +    pin_data,
> +    pinned_drop,
> +    PinInit, //
>  };
> -use core::{convert::TryInto, marker::PhantomData};
> -use pin_init::{pin_data, pinned_drop, PinInit};
>  
>  /// A wrapper for the C `struct blk_mq_tag_set`.
>  ///
> 
> -- 
> 2.43.0
> 
>