[U-Boot] [PATCH] net/designware: call phy_connect_dev() to properly setup phylib device

[U-Boot] [PATCH] net/designware: call phy_connect_dev() to properly setup phylib device

[Ian Campbell]

This sets up the linkage from the phydev back to the ethernet device. This
symptom of not doing this which I noticed was:
    <NULL> Waiting for PHY auto negotiation to complete....
rather than:
    dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
---
 drivers/net/designware.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index c9afe16..b8a7631 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -390,6 +390,8 @@ static int dw_phy_init(struct eth_device *dev)
 	if (!phydev)
 		return -1;
 
+	phy_connect_dev(phydev, dev);
+
 	phydev->supported &= PHY_GBIT_FEATURES;
 	phydev->advertising = phydev->supported;
 
-- 
1.9.0

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Tom Rini]

On Mon, Apr 28, 2014 at 08:14:05PM +0100, Ian Campbell wrote:

> This sets up the linkage from the phydev back to the ethernet device. This
> symptom of not doing this which I noticed was:
>     <NULL> Waiting for PHY auto negotiation to complete....
> rather than:
>     dwmac.1c50000 Waiting for PHY auto negotiation to complete....
> 
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140512/1e0ae36c/attachment.pgp>

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Ian Campbell]

On Mon, 2014-05-12 at 21:53 -0400, Tom Rini wrote:
> On Mon, Apr 28, 2014 at 08:14:05PM +0100, Ian Campbell wrote:
> 
> > This sets up the linkage from the phydev back to the ethernet device. This
> > symptom of not doing this which I noticed was:
> >     <NULL> Waiting for PHY auto negotiation to complete....
> > rather than:
> >     dwmac.1c50000 Waiting for PHY auto negotiation to complete....
> > 
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> 
> Applied to u-boot/master, thanks!

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
data cache, phylib and burst size" which included this and some other
(far more critical, since designware is currently unusable on ARM)
fixes?

Ian.

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Tom Rini]

On Tue, May 13, 2014 at 11:19:13AM +0100, Ian Campbell wrote:
> On Mon, 2014-05-12 at 21:53 -0400, Tom Rini wrote:
> > On Mon, Apr 28, 2014 at 08:14:05PM +0100, Ian Campbell wrote:
> > 
> > > This sets up the linkage from the phydev back to the ethernet device. This
> > > symptom of not doing this which I noticed was:
> > >     <NULL> Waiting for PHY auto negotiation to complete....
> > > rather than:
> > >     dwmac.1c50000 Waiting for PHY auto negotiation to complete....
> > > 
> > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > 
> > Applied to u-boot/master, thanks!
> 
> Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
> data cache, phylib and burst size" which included this and some other
> (far more critical, since designware is currently unusable on ARM)
> fixes?

For the moment I've tossed all of the rest of them over to Albert to
grab along with the sunxi stuff.  Albert, if you're uncomfortable there
I can pick them up instead, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140513/b8f0befe/attachment.pgp>

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Ian Campbell]

On Tue, 2014-05-13 at 07:19 -0400, Tom Rini wrote:
> On Tue, May 13, 2014 at 11:19:13AM +0100, Ian Campbell wrote:
> > On Mon, 2014-05-12 at 21:53 -0400, Tom Rini wrote:
> > > On Mon, Apr 28, 2014 at 08:14:05PM +0100, Ian Campbell wrote:
> > > 
> > > > This sets up the linkage from the phydev back to the ethernet device. This
> > > > symptom of not doing this which I noticed was:
> > > >     <NULL> Waiting for PHY auto negotiation to complete....
> > > > rather than:
> > > >     dwmac.1c50000 Waiting for PHY auto negotiation to complete....
> > > > 
> > > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > > 
> > > Applied to u-boot/master, thanks!
> > 
> > Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
> > data cache, phylib and burst size" which included this and some other
> > (far more critical, since designware is currently unusable on ARM)
> > fixes?
> 
> For the moment I've tossed all of the rest of them over to Albert to
> grab along with the sunxi stuff.

OK, thanks. Does that mean they should be delegated to him in patchwork
(because they still say trini)?

> Albert, if you're uncomfortable there
> I can pick them up instead, thanks!

Cheers,
Ian.

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Tom Rini]

On Wed, May 14, 2014 at 08:29:48AM +0100, Ian Campbell wrote:
> On Tue, 2014-05-13 at 07:19 -0400, Tom Rini wrote:
> > On Tue, May 13, 2014 at 11:19:13AM +0100, Ian Campbell wrote:
> > > On Mon, 2014-05-12 at 21:53 -0400, Tom Rini wrote:
> > > > On Mon, Apr 28, 2014 at 08:14:05PM +0100, Ian Campbell wrote:
> > > > 
> > > > > This sets up the linkage from the phydev back to the ethernet device. This
> > > > > symptom of not doing this which I noticed was:
> > > > >     <NULL> Waiting for PHY auto negotiation to complete....
> > > > > rather than:
> > > > >     dwmac.1c50000 Waiting for PHY auto negotiation to complete....
> > > > > 
> > > > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > > > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > > > 
> > > > Applied to u-boot/master, thanks!
> > > 
> > > Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
> > > data cache, phylib and burst size" which included this and some other
> > > (far more critical, since designware is currently unusable on ARM)
> > > fixes?
> > 
> > For the moment I've tossed all of the rest of them over to Albert to
> > grab along with the sunxi stuff.
> 
> OK, thanks. Does that mean they should be delegated to him in patchwork
> (because they still say trini)?

I think I forgot to update them, oops.  I checked with Albert on IRC
just now and he's fine with it and will grab them tomorrow.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140514/c4e06c50/attachment.pgp>

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Ian Campbell]

On Wed, 2014-05-14 at 11:20 -0400, Tom Rini wrote:
> On Wed, May 14, 2014 at 08:29:48AM +0100, Ian Campbell wrote:
> > On Tue, 2014-05-13 at 07:19 -0400, Tom Rini wrote:
> > > On Tue, May 13, 2014 at 11:19:13AM +0100, Ian Campbell wrote:
> > > > Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
> > > > data cache, phylib and burst size" which included this and some other
> > > > (far more critical, since designware is currently unusable on ARM)
> > > > fixes?
> > > 
> > > For the moment I've tossed all of the rest of them over to Albert to
> > > grab along with the sunxi stuff.
> > 
> > OK, thanks. Does that mean they should be delegated to him in patchwork
> > (because they still say trini)?
> 
> I think I forgot to update them, oops.  I checked with Albert on IRC
> just now and he's fine with it and will grab them tomorrow.

Hi,

I was just wondering what the status of these two series was.

Thanks,
Ian.

[U-Boot] net/designware: call phy_connect_dev() to properly setup phylib device

[Tom Rini]

On Wed, May 21, 2014 at 07:44:15PM +0100, Ian Campbell wrote:
> On Wed, 2014-05-14 at 11:20 -0400, Tom Rini wrote:
> > On Wed, May 14, 2014 at 08:29:48AM +0100, Ian Campbell wrote:
> > > On Tue, 2014-05-13 at 07:19 -0400, Tom Rini wrote:
> > > > On Tue, May 13, 2014 at 11:19:13AM +0100, Ian Campbell wrote:
> > > > > Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for
> > > > > data cache, phylib and burst size" which included this and some other
> > > > > (far more critical, since designware is currently unusable on ARM)
> > > > > fixes?
> > > > 
> > > > For the moment I've tossed all of the rest of them over to Albert to
> > > > grab along with the sunxi stuff.
> > > 
> > > OK, thanks. Does that mean they should be delegated to him in patchwork
> > > (because they still say trini)?
> > 
> > I think I forgot to update them, oops.  I checked with Albert on IRC
> > just now and he's fine with it and will grab them tomorrow.
> 
> Hi,
> 
> I was just wondering what the status of these two series was.

You had posted v3.1 of one of the patches or so when I had poked Albert
on IRC about grabbing it and he said he hadn't seen 3.1 just yet.
Albert?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140521/a3b9f906/attachment.pgp>