[U-Boot] AT91: CFI support broken

[U-Boot] AT91: CFI support broken

[esw at bus-elektronik.de]

Hello,

since "AT91: fix timer.c - remove reset_timer()"

<http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>

was commited the arm926ejs/at91 boards can't compile with cfi_flash support:

u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'

I think this patch should be revert, as long as other modules need the
reset_timer function.

Can anybody confirm this

Thanks

Jens Scharsig

[U-Boot] AT91: CFI support broken

[Reinhard Meyer]

Dear esw at bus-elektronik.de,
> Hello,
>
> since "AT91: fix timer.c - remove reset_timer()"
>
> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>
> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>
> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>
> I think this patch should be revert, as long as other modules need the
> reset_timer function.
>
> Can anybody confirm this

I think we should fix the place where reset_timer() is still used, to use get_timer() only.
All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
that get_timer() is monotonic. reset_timer() resets the value back to zero.

Best Regards,
Reinhard

[U-Boot] AT91: CFI support broken

[Jens Scharsig]

Hello Stefan Roese,

>> Hello,
>>
>> since "AT91: fix timer.c - remove reset_timer()"
>>
>> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>>
>> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>>
>> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>>
>> I think this patch should be revert, as long as other modules need the
>> reset_timer function.
>>
>> Can anybody confirm this
> 
> I think we should fix the place where reset_timer() is still used, to use get_timer() only.
> All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
> that get_timer() is monotonic. reset_timer() resets the value back to zero.
> 
> Best Regards,
> Reinhard

what do you think about?

Best regards

Jens

[U-Boot] AT91: CFI support broken

[Stefan Roese]

Hi Jens,

On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
> >> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
> >> 
> >> I think this patch should be revert, as long as other modules need the
> >> reset_timer function.
> >> 
> >> Can anybody confirm this
> > 
> > I think we should fix the place where reset_timer() is still used, to use
> > get_timer() only. All other drivers that are used in atmel context do
> > not use reset_timer(), but rely on the fact that get_timer() is
> > monotonic. reset_timer() resets the value back to zero.
> > 
> > Best Regards,
> > Reinhard
> 
> what do you think about?

I would welcome it, if somebody would provide a patch to remove the 
reset_timer() call from the common CFI driver.

Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] AT91: CFI support broken

[Graeme Russ]

On Monday, May 23, 2011, Stefan Roese <sr@denx.de> wrote:
> Hi Jens,
>
> On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
>> >> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>> >>
>> >> I think this patch should be revert, as long as other modules need the
>> >> reset_timer function.
>> >>
>> >> Can anybody confirm this
>> >
>> > I think we should fix the place where reset_timer() is still used, to use
>> > get_timer() only. All other drivers that are used in atmel context do
>> > not use reset_timer(), but rely on the fact that get_timer() is
>> > monotonic. reset_timer() resets the value back to zero.
>> >
>> > Best Regards,
>> > Reinhard
>>
>> what do you think about?
>
> I would welcome it, if somebody would provide a patch to remove the
> reset_timer() call from the common CFI driver.
>

Working on it now

Regards,

Graeme