From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH V3 07/14] ARM: dts: stm32: Use DT alias for the configuration EEPROM
Date: Tue, 31 Mar 2020 19:51:29 +0200 [thread overview]
Message-ID: <20200331175136.205020-8-marex@denx.de> (raw)
In-Reply-To: <20200331175136.205020-1-marex@denx.de>
Use DT /aliases node to establish a stable phandle to the configuration
EEPROM. This permits the configuration EEPROM to be moved e.g. to a
different address or a different bus. Adjust the board code to handle
new phandle lookup.
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
---
V2: No change
V3: No change
---
arch/arm/dts/stm32mp15xx-dhcom.dtsi | 6 +++++-
board/dhelectronics/dh_stm32mp1/board.c | 15 +++++++--------
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom.dtsi b/arch/arm/dts/stm32mp15xx-dhcom.dtsi
index bed69c97b6..e5be0a79ac 100644
--- a/arch/arm/dts/stm32mp15xx-dhcom.dtsi
+++ b/arch/arm/dts/stm32mp15xx-dhcom.dtsi
@@ -10,6 +10,10 @@
#include <dt-bindings/mfd/st,stpmic1.h>
/ {
+ aliases {
+ eeprom0 = &eeprom0;
+ };
+
memory at c0000000 {
device_type = "memory";
reg = <0xC0000000 0x40000000>;
@@ -187,7 +191,7 @@
};
};
- eeprom at 50 {
+ eeprom0: eeprom at 50 {
compatible = "atmel,24c02";
reg = <0x50>;
pagesize = <16>;
diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c
index 109d9ec935..a3458a2623 100644
--- a/board/dhelectronics/dh_stm32mp1/board.c
+++ b/board/dhelectronics/dh_stm32mp1/board.c
@@ -78,22 +78,21 @@ DECLARE_GLOBAL_DATA_PTR;
int setup_mac_address(void)
{
- struct udevice *dev;
- ofnode eeprom;
unsigned char enetaddr[6];
- int ret;
+ struct udevice *dev;
+ int off, ret;
ret = eth_env_get_enetaddr("ethaddr", enetaddr);
if (ret) /* ethaddr is already set */
return 0;
- eeprom = ofnode_path("/soc/i2c at 5c002000/eeprom at 50");
- if (!ofnode_valid(eeprom)) {
- printf("Invalid hardware path to EEPROM!\n");
- return -ENODEV;
+ off = fdt_path_offset(gd->fdt_blob, "eeprom0");
+ if (off < 0) {
+ printf("%s: No eeprom0 path offset\n", __func__);
+ return off;
}
- ret = uclass_get_device_by_ofnode(UCLASS_I2C_EEPROM, eeprom, &dev);
+ ret = uclass_get_device_by_of_offset(UCLASS_I2C_EEPROM, off, &dev);
if (ret) {
printf("Cannot find EEPROM!\n");
return ret;
--
2.25.1
next prev parent reply other threads:[~2020-03-31 17:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 17:51 [PATCH V3 00/14] ARM: stm32: Fix Avenger96 Marek Vasut
2020-03-31 17:51 ` [PATCH V3 01/14] ARM: dts: stm32: Repair SD1 pre-reloc pinmux DT node on AV96 Marek Vasut
2020-04-01 9:54 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 02/14] ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins Marek Vasut
2020-04-01 9:55 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 03/14] ARM: dts: stm32: Repair SDMMC1 operation on AV96 Marek Vasut
2020-04-01 9:55 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 04/14] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
2020-04-01 9:56 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 05/14] ARM: dts: stm32: Repair SDMMC2 operation Marek Vasut
2020-04-01 9:56 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 06/14] ARM: dts: stm32: Add QSPI NOR on AV96 Marek Vasut
2020-04-01 8:17 ` Patrick DELAUNAY
2020-04-01 9:59 ` Patrick DELAUNAY
2020-03-31 17:51 ` Marek Vasut [this message]
2020-04-01 9:59 ` [PATCH V3 07/14] ARM: dts: stm32: Use DT alias for the configuration EEPROM Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 08/14] ARM: dts: stm32: Add configuration EEPROM on AV96 Marek Vasut
2020-04-01 10:02 ` Patrick DELAUNAY
2020-04-01 11:00 ` Marek Vasut
2020-03-31 17:51 ` [PATCH V3 09/14] ARM: dts: stm32: Add alternate pinmux for ethernet RGMII Marek Vasut
2020-04-01 10:03 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 10/14] ARM: dts: stm32: Repair ethernet operation on AV96 Marek Vasut
2020-04-01 10:03 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 11/14] ARM: dts: stm32: Add missing ethernet PHY reset " Marek Vasut
2020-04-01 10:04 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration " Marek Vasut
2020-04-01 7:34 ` Patrick DELAUNAY
2020-04-01 11:06 ` Marek Vasut
2020-04-01 12:45 ` Patrice CHOTARD
2020-04-01 12:53 ` Marek Vasut
2020-04-01 13:52 ` Patrick DELAUNAY
2020-04-01 13:53 ` Marek Vasut
2020-04-02 12:53 ` Pascal PAILLET-LME
2020-04-02 13:07 ` Marek Vasut
2020-04-02 13:43 ` Pascal PAILLET-LME
2020-04-09 11:28 ` Marek Vasut
2020-04-01 10:04 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 13/14] ARM: dts: stm32: Adjust PLL4 settings " Marek Vasut
2020-04-01 10:24 ` Patrick DELAUNAY
2020-04-01 11:09 ` Marek Vasut
2020-04-01 16:49 ` Gerald BAEZA
2020-04-01 17:45 ` Manivannan Sadhasivam
2020-04-01 18:48 ` Marek Vasut
2020-04-02 7:44 ` Gerald BAEZA
2020-04-02 13:04 ` Marek Vasut
2020-04-24 14:31 ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 14/14] ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board Marek Vasut
2020-04-24 14:31 ` Patrick DELAUNAY
2020-04-27 10:29 ` Marek Vasut
2020-04-27 14:00 ` Patrick DELAUNAY
2020-04-27 14:34 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331175136.205020-8-marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox