public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH V3 13/14] ARM: dts: stm32: Adjust PLL4 settings on AV96
Date: Wed, 1 Apr 2020 13:09:19 +0200	[thread overview]
Message-ID: <e9871867-daae-532e-6d2d-a94426fdcb30@denx.de> (raw)
In-Reply-To: <1c8ce6c4f0ed4611a54c885d9473182e@SFHDAG6NODE3.st.com>

On 4/1/20 12:24 PM, Patrick DELAUNAY wrote:
> Hi Gerald and Manivannan,

Hi,

>> From: Marek Vasut <marex@denx.de>
>> Sent: mardi 31 mars 2020 19:52
>>
>> The PLL4 is supplying SDMMC12, SDMMC3 and SPDIF with 120 MHz and
>> FDCAN with 96 MHz. This isn't good for the SDMMC interfaces, which can not
>> easily divide the clock down to e.g. 50 MHz for high speed SD and eMMC
>> devices, so those devices end up running at 30 MHz as that is 120 MHz / 4.
>> Adjust the PLL4 settings such that both PLL4P and PLL4R run at 100 MHz
>> instead, which is easy to divide to 50MHz for optimal operation of both SD and
>> eMMC, SPDIF clock are not that much slower and FDCAN is also unaffected.
>>
>> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
>> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> ---
>> V2: Move this patch before the split of AV96 into SoM and carrier
>> V3: No change
>> ---
> 
> This patch update the PLL4 frequency used on AV96 board,
> with different of reference clock tree used on ST board,
> this new setting allow to optimize the SDMMC frequency (50MHz vs 30Mz).
> 
> I don't know why the previous PLL4 frequency was chosen as a compromise
> on reference clock-tree  (PLL4 is used by mostly all the peripheral,
> with display and audio requirements).
> 
> Can you cross check the proposed clock tree and ack this patch
> if these ST requirements are not applicable on AV96 board.
> 
> Anyway the code is correct.

Likely because these PLL settings are being copied from reference
platform to other platforms etc.

But I did notice one odd thing, which is when running the SD1 in SDR104,
the read data transfers can be unstable, which I suspect is because the
bus runs at actual 100 MHz instead of some 60 MHz. I need to look at
that with a scope, so that's to be checked. For now I turned the SDR104 off.

  reply	other threads:[~2020-04-01 11:09 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 17:51 [PATCH V3 00/14] ARM: stm32: Fix Avenger96 Marek Vasut
2020-03-31 17:51 ` [PATCH V3 01/14] ARM: dts: stm32: Repair SD1 pre-reloc pinmux DT node on AV96 Marek Vasut
2020-04-01  9:54   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 02/14] ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins Marek Vasut
2020-04-01  9:55   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 03/14] ARM: dts: stm32: Repair SDMMC1 operation on AV96 Marek Vasut
2020-04-01  9:55   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 04/14] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
2020-04-01  9:56   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 05/14] ARM: dts: stm32: Repair SDMMC2 operation Marek Vasut
2020-04-01  9:56   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 06/14] ARM: dts: stm32: Add QSPI NOR on AV96 Marek Vasut
2020-04-01  8:17   ` Patrick DELAUNAY
2020-04-01  9:59   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 07/14] ARM: dts: stm32: Use DT alias for the configuration EEPROM Marek Vasut
2020-04-01  9:59   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 08/14] ARM: dts: stm32: Add configuration EEPROM on AV96 Marek Vasut
2020-04-01 10:02   ` Patrick DELAUNAY
2020-04-01 11:00     ` Marek Vasut
2020-03-31 17:51 ` [PATCH V3 09/14] ARM: dts: stm32: Add alternate pinmux for ethernet RGMII Marek Vasut
2020-04-01 10:03   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 10/14] ARM: dts: stm32: Repair ethernet operation on AV96 Marek Vasut
2020-04-01 10:03   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 11/14] ARM: dts: stm32: Add missing ethernet PHY reset " Marek Vasut
2020-04-01 10:04   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration " Marek Vasut
2020-04-01  7:34   ` Patrick DELAUNAY
2020-04-01 11:06     ` Marek Vasut
2020-04-01 12:45       ` Patrice CHOTARD
2020-04-01 12:53         ` Marek Vasut
2020-04-01 13:52           ` Patrick DELAUNAY
2020-04-01 13:53             ` Marek Vasut
2020-04-02 12:53             ` Pascal PAILLET-LME
2020-04-02 13:07               ` Marek Vasut
2020-04-02 13:43                 ` Pascal PAILLET-LME
2020-04-09 11:28                   ` Marek Vasut
2020-04-01 10:04   ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 13/14] ARM: dts: stm32: Adjust PLL4 settings " Marek Vasut
2020-04-01 10:24   ` Patrick DELAUNAY
2020-04-01 11:09     ` Marek Vasut [this message]
2020-04-01 16:49       ` Gerald BAEZA
2020-04-01 17:45         ` Manivannan Sadhasivam
2020-04-01 18:48         ` Marek Vasut
2020-04-02  7:44           ` Gerald BAEZA
2020-04-02 13:04             ` Marek Vasut
2020-04-24 14:31               ` Patrick DELAUNAY
2020-03-31 17:51 ` [PATCH V3 14/14] ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board Marek Vasut
2020-04-24 14:31   ` Patrick DELAUNAY
2020-04-27 10:29     ` Marek Vasut
2020-04-27 14:00       ` Patrick DELAUNAY
2020-04-27 14:34         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9871867-daae-532e-6d2d-a94426fdcb30@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox