public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] cache: l2x0: Fix missing write to Auxiliary Control Register
@ 2020-05-04 10:41 Ley Foon Tan
  2020-05-07 13:04 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Ley Foon Tan @ 2020-05-04 10:41 UTC (permalink / raw)
  To: u-boot

commit f62782fb2999 ("cache: l2x0: Fix write to incorrect shared-override
bit")

Commit above removed writel to regs->pl310_aux_ctrl by accidentally,
restore it back.

Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
 drivers/cache/cache-l2x0.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cache/cache-l2x0.c b/drivers/cache/cache-l2x0.c
index 226824c2832e..a1556fbf1740 100644
--- a/drivers/cache/cache-l2x0.c
+++ b/drivers/cache/cache-l2x0.c
@@ -36,6 +36,8 @@ static void l2c310_of_parse_and_init(struct udevice *dev)
 	if (dev_read_bool(dev, "arm,shared-override"))
 		saved_reg |= L310_SHARED_ATT_OVERRIDE_ENABLE;
 
+	writel(saved_reg, &regs->pl310_aux_ctrl);
+
 	saved_reg = readl(&regs->pl310_tag_latency_ctrl);
 	if (!dev_read_u32_array(dev, "arm,tag-latency", tag, 3))
 		saved_reg |= L310_LATENCY_CTRL_RD(tag[0] - 1) |
-- 
2.19.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] cache: l2x0: Fix missing write to Auxiliary Control Register
  2020-05-04 10:41 [PATCH] cache: l2x0: Fix missing write to Auxiliary Control Register Ley Foon Tan
@ 2020-05-07 13:04 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2020-05-07 13:04 UTC (permalink / raw)
  To: u-boot

On Mon, May 04, 2020 at 06:41:55PM +0800, Ley Foon Tan wrote:

> commit f62782fb2999 ("cache: l2x0: Fix write to incorrect shared-override
> bit")
> 
> Commit above removed writel to regs->pl310_aux_ctrl by accidentally,
> restore it back.
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200507/cb1d30a4/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-07 13:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-04 10:41 [PATCH] cache: l2x0: Fix missing write to Auxiliary Control Register Ley Foon Tan
2020-05-07 13:04 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox