From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: U-Boot atheros PHY support and cubox ethernet
Date: Tue, 16 Jun 2020 16:58:12 -0400 [thread overview]
Message-ID: <20200616205812.GC24893@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5B4gvNR=C6fYycnxR0Xnf8kPCS2A+gWa8oLttbmURRFrw@mail.gmail.com>
On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote:
> On Tue, Jun 16, 2020 at 5:51 PM Tom Rini <trini@konsulko.com> wrote:
>
> > Ah. So this is probably why the DT being right isn't helping then. If
> > you want to blind-convert I'm happy to test, otherwise do you have a
> > similar board conversion for me to look at? Thanks!
>
> Please try Vladimir's suggestion as it seems to be the less intrusive approach:
>
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -321,7 +321,7 @@ int board_eth_init(bd_t *bis)
> if (!bus)
> return -EINVAL;
>
> - phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII);
> + phydev = phy_find_by_mask(bus, ETH_PHY_MASK,
> PHY_INTERFACE_MODE_RGMII_ID);
> if (!phydev) {
> ret = -EINVAL;
> goto free_bus;
>
OK, tried that and not enough. Console says PHY autoneg completes, but
DHCP still doesn't reply.
> Here is a similar DM_ETH board conversion:
>
> commit 02ee7a4aa57b37d6003263b69b1852c4cda5975e
> Author: Alifer Moraes <alifer.wsdm@gmail.com>
> Date: Mon Feb 10 11:28:01 2020 -0300
>
> mx6sabresd: Convert ethernet to driver model
>
> Convert imx6sabresd ethernet to driver model to fix the following warning:
>
> ===================== WARNING ======================
> This board does not use CONFIG_DM_ETH (Driver Model
> for Ethernet drivers). Please update the board to use
> CONFIG_DM_ETH before the v2020.07 release. Failure to
> update by the deadline may result in board removal.
> See doc/driver-model/migration.rst for more info.
> ====================================================
>
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Let us know if this helps.
I'm looking at the conversion now, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200616/c0591ab8/attachment.sig>
next prev parent reply other threads:[~2020-06-16 20:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 19:55 U-Boot atheros PHY support and cubox ethernet Tom Rini
2020-06-16 19:58 ` Vladimir Oltean
2020-06-16 20:10 ` Tom Rini
2020-06-16 20:21 ` Vladimir Oltean
2020-06-16 20:31 ` Tom Rini
2020-06-16 20:37 ` Vladimir Oltean
2020-06-16 21:35 ` Tom Rini
2020-06-16 21:57 ` Vladimir Oltean
2020-06-17 7:19 ` Michael Walle
2020-06-16 21:30 ` Michael Walle
2020-06-16 21:37 ` Tom Rini
2020-06-16 20:42 ` Fabio Estevam
2020-06-16 20:48 ` Vladimir Oltean
2020-06-16 20:51 ` Tom Rini
2020-06-16 20:55 ` Fabio Estevam
2020-06-16 20:58 ` Tom Rini [this message]
2020-06-16 21:01 ` Fabio Estevam
2020-06-16 22:30 ` Tom Rini
2020-06-17 12:04 ` Fabio Estevam
2020-06-17 13:06 ` Fabio Estevam
2020-06-17 13:23 ` Tom Rini
2020-06-17 17:31 ` Fabio Estevam
2020-06-17 19:00 ` Tom Rini
2020-06-17 19:09 ` Fabio Estevam
2020-06-17 19:18 ` Fabio Estevam
2020-06-17 19:24 ` Tom Rini
2020-06-17 19:19 ` Tom Rini
2020-06-17 21:28 ` Fabio Estevam
2020-06-17 21:30 ` Tom Rini
2020-06-18 0:41 ` Fabio Estevam
2020-06-18 13:39 ` Tom Rini
2020-06-20 2:14 ` Fabio Estevam
2020-06-24 19:20 ` Soeren Moch
2020-06-24 19:39 ` Fabio Estevam
2020-06-24 20:13 ` Soeren Moch
2020-06-24 20:29 ` Fabio Estevam
2020-06-24 20:45 ` Sören Moch
2020-06-24 21:35 ` Fabio Estevam
2020-06-24 22:29 ` Soeren Moch
2020-06-24 23:19 ` Fabio Estevam
2020-06-24 23:44 ` Fabio Estevam
2020-06-25 9:56 ` Soeren Moch
2020-06-25 10:26 ` Fabio Estevam
2020-06-18 3:05 ` Fabio Estevam
2020-06-16 21:01 ` Vladimir Oltean
2020-06-16 21:04 ` Vladimir Oltean
2020-06-16 21:57 ` Tom Rini
2020-06-16 21:59 ` Vladimir Oltean
2020-06-16 21:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616205812.GC24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox