From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: U-Boot atheros PHY support and cubox ethernet
Date: Wed, 17 Jun 2020 15:19:55 -0400 [thread overview]
Message-ID: <20200617191955.GG27801@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5Ds0L4TaXOE=mp7B4UF1GJoRLSK0=Y+P+8Pq5Ca=UuLTw@mail.gmail.com>
On Wed, Jun 17, 2020 at 04:09:19PM -0300, Fabio Estevam wrote:
> On Wed, Jun 17, 2020 at 4:00 PM Tom Rini <trini@konsulko.com> wrote:
>
> > +#ifdef CONFIG_FEC_MXC
> > +static int setup_fec(void)
> > +{
> > + struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
> > + struct gpio_desc desc;
> > +
> > + int ret = enable_fec_anatop_clock(0, ENET_25MHZ);
> > + if (ret)
> > + return ret;
> > +
> > + /* set gpr1[ENET_CLK_SEL] */
> > + setbits_le32(&iomuxc_regs->gpr[1], IOMUXC_GPR1_ENET_CLK_SEL_MASK);
> > +
> > + /* Reset PHY */
> > + ret = dm_gpio_lookup_name("GPIO4_15", &desc);
> > + if (ret) {
> > + printf("%s: phy reset lookup failed\n", __func__);
> > + return ret;
> > + }
> > +
> > + ret = dm_gpio_request(&desc, "phy-reset");
> > + if (ret) {
> > + printf("%s: phy reset request failed\n", __func__);
> > + return ret;
> > + }
> > +
> > + gpio_direction_output(ETH_PHY_RESET, 0);
> > + mdelay(10);
> > + gpio_set_value(ETH_PHY_RESET, 1);
> > + udelay(100);
>
> The Ethernet PHY reset can be done via device tree.
>
> It seems we need to change it like this:
>
> --- a/arch/arm/dts/imx6qdl-sr-som.dtsi
> +++ b/arch/arm/dts/imx6qdl-sr-som.dtsi
> @@ -54,7 +54,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
> phy-mode = "rgmii-id";
> - phy-reset-duration = <2>;
> + phy-reset-duration = <10>;
> + phy-reset-post-delay = <1>;
> phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
> Does it still probe if you remove the PHY reset from the board code?
Nope, same "Could not get PHY for FEC0: addr 0". I gather from another
part of this thread there's some further breakage / unexpected changes,
so I'll chime in there next.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200617/3bf7ae20/attachment.sig>
next prev parent reply other threads:[~2020-06-17 19:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 19:55 U-Boot atheros PHY support and cubox ethernet Tom Rini
2020-06-16 19:58 ` Vladimir Oltean
2020-06-16 20:10 ` Tom Rini
2020-06-16 20:21 ` Vladimir Oltean
2020-06-16 20:31 ` Tom Rini
2020-06-16 20:37 ` Vladimir Oltean
2020-06-16 21:35 ` Tom Rini
2020-06-16 21:57 ` Vladimir Oltean
2020-06-17 7:19 ` Michael Walle
2020-06-16 21:30 ` Michael Walle
2020-06-16 21:37 ` Tom Rini
2020-06-16 20:42 ` Fabio Estevam
2020-06-16 20:48 ` Vladimir Oltean
2020-06-16 20:51 ` Tom Rini
2020-06-16 20:55 ` Fabio Estevam
2020-06-16 20:58 ` Tom Rini
2020-06-16 21:01 ` Fabio Estevam
2020-06-16 22:30 ` Tom Rini
2020-06-17 12:04 ` Fabio Estevam
2020-06-17 13:06 ` Fabio Estevam
2020-06-17 13:23 ` Tom Rini
2020-06-17 17:31 ` Fabio Estevam
2020-06-17 19:00 ` Tom Rini
2020-06-17 19:09 ` Fabio Estevam
2020-06-17 19:18 ` Fabio Estevam
2020-06-17 19:24 ` Tom Rini
2020-06-17 19:19 ` Tom Rini [this message]
2020-06-17 21:28 ` Fabio Estevam
2020-06-17 21:30 ` Tom Rini
2020-06-18 0:41 ` Fabio Estevam
2020-06-18 13:39 ` Tom Rini
2020-06-20 2:14 ` Fabio Estevam
2020-06-24 19:20 ` Soeren Moch
2020-06-24 19:39 ` Fabio Estevam
2020-06-24 20:13 ` Soeren Moch
2020-06-24 20:29 ` Fabio Estevam
2020-06-24 20:45 ` Sören Moch
2020-06-24 21:35 ` Fabio Estevam
2020-06-24 22:29 ` Soeren Moch
2020-06-24 23:19 ` Fabio Estevam
2020-06-24 23:44 ` Fabio Estevam
2020-06-25 9:56 ` Soeren Moch
2020-06-25 10:26 ` Fabio Estevam
2020-06-18 3:05 ` Fabio Estevam
2020-06-16 21:01 ` Vladimir Oltean
2020-06-16 21:04 ` Vladimir Oltean
2020-06-16 21:57 ` Tom Rini
2020-06-16 21:59 ` Vladimir Oltean
2020-06-16 21:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617191955.GG27801@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox