From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: U-Boot atheros PHY support and cubox ethernet
Date: Tue, 16 Jun 2020 17:37:06 -0400 [thread overview]
Message-ID: <20200616213706.GE24893@bill-the-cat> (raw)
In-Reply-To: <57D4DB39-6D19-4D70-B020-0FFBF8C5EE75@walle.cc>
On Tue, Jun 16, 2020 at 11:30:00PM +0200, Michael Walle wrote:
> Am 16. Juni 2020 22:21:08 MESZ schrieb Vladimir Oltean <olteanv@gmail.com>:
> >On Tue, 16 Jun 2020 at 23:10, Tom Rini <trini@konsulko.com> wrote:
> >>
> >> On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote:
> >> > Hi Tom,
> >> >
> >> > On Tue, 16 Jun 2020 at 22:55, Tom Rini <trini@konsulko.com> wrote:
> >> > >
> >> > > Hey all,
> >> > >
> >> > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays
> >actually
> >> > > configurable for AR8035") we brought in changes to get in to line
> >with
> >> > > upstream linux kernel support for this PHY and in turn deal with
> >more
> >> > > "driver was wrong, DT was wrong too" changes. Now the problem I
> >have is
> >> > > that ethernet on my Hummingboard doesn't work AND as far as I can
> >tell,
> >> > > the DTB is correct and saying phy-mode = "rgmii-id" now not
> >"rgmii". It
> >> > > also looks to match what's in v5.7 for the kernel. What do I
> >need to do
> >> > > here next? Thanks!
> >> > >
> >> > > --
> >> > > Tom
> >> >
> >> > Reverting 4346df3392c0 makes your interface work?
> >>
> >> Yup.
> >>
> >> > What is the DTS path that your hummingboard uses?
> >>
> >> Good question. Per board/solidrun/mx6cuboxi/mx6cuboxi.c:
> >> /*
> >> * This is not a perfect match. Avoid dependency on the DM GPIO
> >driver
> >> * needed
> >> * for accurate board detection. Hummingboard2 DT is good enough for
> >> * U-Boot on
> >> * all Hummingboard/Cubox-i platforms.
> >> */
> >> so arch/arm/dts/imx6dl-hummingboard2-emmc-som-v15.dts is the base.
> >But
> >> the board really is the original hummingboard platform. Thanks!
> >>
> >> --
> >> Tom
> >
> >Does it work if you say PHY_INTERFACE_MODE_RGMII_ID here?
> >https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1232
>
> it should be PHY_INTERFACE_MODE_RGMII_TXID to get the original behavior, shouldn't it? The commit in question only removes the hardcoded TX delay.
This change alone also still fails on master for me.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200616/c1b2aaaf/attachment.sig>
next prev parent reply other threads:[~2020-06-16 21:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 19:55 U-Boot atheros PHY support and cubox ethernet Tom Rini
2020-06-16 19:58 ` Vladimir Oltean
2020-06-16 20:10 ` Tom Rini
2020-06-16 20:21 ` Vladimir Oltean
2020-06-16 20:31 ` Tom Rini
2020-06-16 20:37 ` Vladimir Oltean
2020-06-16 21:35 ` Tom Rini
2020-06-16 21:57 ` Vladimir Oltean
2020-06-17 7:19 ` Michael Walle
2020-06-16 21:30 ` Michael Walle
2020-06-16 21:37 ` Tom Rini [this message]
2020-06-16 20:42 ` Fabio Estevam
2020-06-16 20:48 ` Vladimir Oltean
2020-06-16 20:51 ` Tom Rini
2020-06-16 20:55 ` Fabio Estevam
2020-06-16 20:58 ` Tom Rini
2020-06-16 21:01 ` Fabio Estevam
2020-06-16 22:30 ` Tom Rini
2020-06-17 12:04 ` Fabio Estevam
2020-06-17 13:06 ` Fabio Estevam
2020-06-17 13:23 ` Tom Rini
2020-06-17 17:31 ` Fabio Estevam
2020-06-17 19:00 ` Tom Rini
2020-06-17 19:09 ` Fabio Estevam
2020-06-17 19:18 ` Fabio Estevam
2020-06-17 19:24 ` Tom Rini
2020-06-17 19:19 ` Tom Rini
2020-06-17 21:28 ` Fabio Estevam
2020-06-17 21:30 ` Tom Rini
2020-06-18 0:41 ` Fabio Estevam
2020-06-18 13:39 ` Tom Rini
2020-06-20 2:14 ` Fabio Estevam
2020-06-24 19:20 ` Soeren Moch
2020-06-24 19:39 ` Fabio Estevam
2020-06-24 20:13 ` Soeren Moch
2020-06-24 20:29 ` Fabio Estevam
2020-06-24 20:45 ` Sören Moch
2020-06-24 21:35 ` Fabio Estevam
2020-06-24 22:29 ` Soeren Moch
2020-06-24 23:19 ` Fabio Estevam
2020-06-24 23:44 ` Fabio Estevam
2020-06-25 9:56 ` Soeren Moch
2020-06-25 10:26 ` Fabio Estevam
2020-06-18 3:05 ` Fabio Estevam
2020-06-16 21:01 ` Vladimir Oltean
2020-06-16 21:04 ` Vladimir Oltean
2020-06-16 21:57 ` Tom Rini
2020-06-16 21:59 ` Vladimir Oltean
2020-06-16 21:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616213706.GE24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox