* [PATCH v1] cmd: acpi: Print revisions in hex format
@ 2020-09-08 14:30 Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Andy Shevchenko @ 2020-09-08 14:30 UTC (permalink / raw)
To: u-boot
The revisions are usually dates in hex-decimal format representing
YYYYmmdd. Print them in hex to see this clearly.
Before:
...
FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
...
After:
...
FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
...
Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
cmd/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/acpi.c b/cmd/acpi.c
index 085a3a650d1a..a3419b42b556 100644
--- a/cmd/acpi.c
+++ b/cmd/acpi.c
@@ -26,7 +26,7 @@ static void dump_hdr(struct acpi_table_header *hdr)
printf("%.*s %08lx %06x", ACPI_NAME_LEN, hdr->signature,
(ulong)map_to_sysmem(hdr), hdr->length);
if (has_hdr) {
- printf(" (v%02d %.6s %.8s %u %.4s %d)\n", hdr->revision,
+ printf(" (v%02d %.6s %.8s %x %.4s %x)\n", hdr->revision,
hdr->oem_id, hdr->oem_table_id, hdr->oem_revision,
hdr->aslc_id, hdr->aslc_revision);
} else {
--
2.28.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
@ 2020-09-08 14:58 ` Wolfgang Wallner
2020-09-08 15:17 ` Andy Shevchenko
2020-09-21 1:31 ` Bin Meng
2020-09-21 2:20 ` Bin Meng
2 siblings, 1 reply; 11+ messages in thread
From: Wolfgang Wallner @ 2020-09-08 14:58 UTC (permalink / raw)
To: u-boot
Hi Andy,
-----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
> Betreff: [PATCH v1] cmd: acpi: Print revisions in hex format
>
> The revisions are usually dates in hex-decimal format representing
> YYYYmmdd. Print them in hex to see this clearly.
>
> Before:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> ...
> After:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> ...
>
> Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> cmd/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Tested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Tested on a custom Apollolake board.
Related to "acpi list":
During my recent ACPI debugging I found it very useful to have the checksum
printed for each table with "acpi list". Would there be interest to have that
upstream? If so I would send a patch.
regards, Wolfgang
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 14:58 ` Wolfgang Wallner
@ 2020-09-08 15:17 ` Andy Shevchenko
2020-09-08 15:32 ` Wolfgang Wallner
0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2020-09-08 15:17 UTC (permalink / raw)
To: u-boot
On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
> -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
> > Betreff: [PATCH v1] cmd: acpi: Print revisions in hex format
> >
> > The revisions are usually dates in hex-decimal format representing
> > YYYYmmdd. Print them in hex to see this clearly.
> >
> > Before:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> > ...
> > After:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> > ...
> >
> > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > cmd/acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Tested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Tested on a custom Apollolake board.
Thanks!
> Related to "acpi list":
> During my recent ACPI debugging I found it very useful to have the checksum
> printed for each table with "acpi list". Would there be interest to have that
> upstream? If so I would send a patch.
Can you elaborate what was the problem that checksum helped?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 15:17 ` Andy Shevchenko
@ 2020-09-08 15:32 ` Wolfgang Wallner
2020-09-08 15:48 ` Andy Shevchenko
2020-09-09 7:15 ` Wolfgang Wallner
0 siblings, 2 replies; 11+ messages in thread
From: Wolfgang Wallner @ 2020-09-08 15:32 UTC (permalink / raw)
To: u-boot
Hi Andy,
-----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
>
> On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> > -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
> > > Betreff: [PATCH v1] cmd: acpi: Print revisions in hex format
> > >
> > > The revisions are usually dates in hex-decimal format representing
> > > YYYYmmdd. Print them in hex to see this clearly.
> > >
> > > Before:
> > > ...
> > > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> > > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> > > ...
> > > After:
> > > ...
> > > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> > > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> > > ...
> > >
> > > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > > Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > cmd/acpi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Tested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Tested on a custom Apollolake board.
>
> Thanks!
You're welcome.
>
> > Related to "acpi list":
> > During my recent ACPI debugging I found it very useful to have the checksum
> > printed for each table with "acpi list". Would there be interest to have that
> > upstream? If so I would send a patch.
>
> Can you elaborate what was the problem that checksum helped?
Sure. I saw two strange things with the ACPI checksums:
1) The DSDT length included uninitialized bytes from alignment. This is
described in the following link:
https://lists.denx.de/pipermail/u-boot/2020-September/425378.html
This was the actual bug I was looking for.
2) acpi_create_spcr() is missing a memset(). The other acpi_create_xxxx()
functions perform a memset on their structure, acpi_create_spcr() does not
and as a result the contents of this table are party uninitialized.
I plan to send a patch for both of them.
Regards, Wolfgang
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 15:32 ` Wolfgang Wallner
@ 2020-09-08 15:48 ` Andy Shevchenko
2020-09-09 7:15 ` Wolfgang Wallner
1 sibling, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2020-09-08 15:48 UTC (permalink / raw)
To: u-boot
On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> > On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> > <wolfgang.wallner@br-automation.com> wrote:
> > > -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
...
> > > Related to "acpi list":
> > > During my recent ACPI debugging I found it very useful to have the checksum
> > > printed for each table with "acpi list". Would there be interest to have that
> > > upstream? If so I would send a patch.
> >
> > Can you elaborate what was the problem that checksum helped?
>
> Sure. I saw two strange things with the ACPI checksums:
>
> 1) The DSDT length included uninitialized bytes from alignment. This is
> described in the following link:
>
> https://lists.denx.de/pipermail/u-boot/2020-September/425378.html
>
> This was the actual bug I was looking for.
>
> 2) acpi_create_spcr() is missing a memset(). The other acpi_create_xxxx()
> functions perform a memset on their structure, acpi_create_spcr() does not
> and as a result the contents of this table are party uninitialized.
>
> I plan to send a patch for both of them.
I'm not sure I understood how checksum pointed to uninitialized data?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 15:32 ` Wolfgang Wallner
2020-09-08 15:48 ` Andy Shevchenko
@ 2020-09-09 7:15 ` Wolfgang Wallner
2020-09-09 8:51 ` Andy Shevchenko
1 sibling, 1 reply; 11+ messages in thread
From: Wolfgang Wallner @ 2020-09-09 7:15 UTC (permalink / raw)
To: u-boot
Hi Andy,
-----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
>
> On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> > -----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> > > On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> > > <wolfgang.wallner@br-automation.com> wrote:
> > > > -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
>
> ...
>
> > > > Related to "acpi list":
> > > > During my recent ACPI debugging I found it very useful to have the checksum
> > > > printed for each table with "acpi list". Would there be interest to have that
> > > > upstream? If so I would send a patch.
> > >
> > > Can you elaborate what was the problem that checksum helped?
> >
> > Sure. I saw two strange things with the ACPI checksums:
> >
> > 1) The DSDT length included uninitialized bytes from alignment. This is
> > described in the following link:
> >
> > https://lists.denx.de/pipermail/u-boot/2020-September/425378.html
> >
> > This was the actual bug I was looking for.
> >
> > 2) acpi_create_spcr() is missing a memset(). The other acpi_create_xxxx()
> > functions perform a memset on their structure, acpi_create_spcr() does not
> > and as a result the contents of this table are party uninitialized.
> >
> > I plan to send a patch for both of them.
>
> I'm not sure I understood how checksum pointed to uninitialized data?
After adding the checksums to "acpi list" I realized that the checksums for
DSDT and SPCR where different after every reset. Looking at the code each
turned out to be somehow related to uninitialized memory.
regards, Wolfgang
PS: My mail client has somehow corrupted your last mail, and I can't open it.
A colleague has forwarded it to me so I could reply. This is why I reply to my
own mail.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-09 7:15 ` Wolfgang Wallner
@ 2020-09-09 8:51 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2020-09-09 8:51 UTC (permalink / raw)
To: u-boot
On Wed, Sep 09, 2020 at 09:15:22AM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> > Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
> > On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> > > -----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> > > > On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> > > > <wolfgang.wallner@br-automation.com> wrote:
> > > > > -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
...
> > > > > Related to "acpi list":
> > > > > During my recent ACPI debugging I found it very useful to have the checksum
> > > > > printed for each table with "acpi list". Would there be interest to have that
> > > > > upstream? If so I would send a patch.
> > > >
> > > > Can you elaborate what was the problem that checksum helped?
> > >
> > > Sure. I saw two strange things with the ACPI checksums:
> > >
> > > 1) The DSDT length included uninitialized bytes from alignment. This is
> > > described in the following link:
> > >
> > > https://lists.denx.de/pipermail/u-boot/2020-September/425378.html
> > >
> > > This was the actual bug I was looking for.
> > >
> > > 2) acpi_create_spcr() is missing a memset(). The other acpi_create_xxxx()
> > > functions perform a memset on their structure, acpi_create_spcr() does not
> > > and as a result the contents of this table are party uninitialized.
> > >
> > > I plan to send a patch for both of them.
> >
> > I'm not sure I understood how checksum pointed to uninitialized data?
>
> After adding the checksums to "acpi list" I realized that the checksums for
> DSDT and SPCR where different after every reset. Looking at the code each
> turned out to be somehow related to uninitialized memory.
I see. I would rather to have it as a separate (sub-)command. But I leave this
to Simon.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
@ 2020-09-21 1:31 ` Bin Meng
2020-09-21 1:35 ` Bin Meng
2020-09-21 2:20 ` Bin Meng
2 siblings, 1 reply; 11+ messages in thread
From: Bin Meng @ 2020-09-21 1:31 UTC (permalink / raw)
To: u-boot
On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The revisions are usually dates in hex-decimal format representing
> YYYYmmdd. Print them in hex to see this clearly.
>
> Before:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> ...
> After:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> ...
>
> Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> cmd/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-21 1:31 ` Bin Meng
@ 2020-09-21 1:35 ` Bin Meng
0 siblings, 0 replies; 11+ messages in thread
From: Bin Meng @ 2020-09-21 1:35 UTC (permalink / raw)
To: u-boot
On Mon, Sep 21, 2020 at 9:31 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The revisions are usually dates in hex-decimal format representing
> > YYYYmmdd. Print them in hex to see this clearly.
> >
> > Before:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> > ...
> > After:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> > ...
> >
> > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > cmd/acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
2020-09-21 1:31 ` Bin Meng
@ 2020-09-21 2:20 ` Bin Meng
2020-09-21 8:36 ` Andy Shevchenko
2 siblings, 1 reply; 11+ messages in thread
From: Bin Meng @ 2020-09-21 2:20 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The revisions are usually dates in hex-decimal format representing
> YYYYmmdd. Print them in hex to see this clearly.
>
> Before:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> ...
> After:
> ...
> FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> ...
>
> Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> cmd/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/acpi.c b/cmd/acpi.c
> index 085a3a650d1a..a3419b42b556 100644
> --- a/cmd/acpi.c
> +++ b/cmd/acpi.c
> @@ -26,7 +26,7 @@ static void dump_hdr(struct acpi_table_header *hdr)
> printf("%.*s %08lx %06x", ACPI_NAME_LEN, hdr->signature,
> (ulong)map_to_sysmem(hdr), hdr->length);
> if (has_hdr) {
> - printf(" (v%02d %.6s %.8s %u %.4s %d)\n", hdr->revision,
> + printf(" (v%02d %.6s %.8s %x %.4s %x)\n", hdr->revision,
> hdr->oem_id, hdr->oem_table_id, hdr->oem_revision,
> hdr->aslc_id, hdr->aslc_revision);
> } else {
> --
This unfortunately breaks the unit test.
/u/test/dm/acpi.c:371, dm_test_acpi_cmd_list(): console:
Expected 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 538970401 INTL 0)',
got 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 20200921 INTL 0)'
Failures: 2
Would you please resend v2 to fix this?
Regards,
Bin
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v1] cmd: acpi: Print revisions in hex format
2020-09-21 2:20 ` Bin Meng
@ 2020-09-21 8:36 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2020-09-21 8:36 UTC (permalink / raw)
To: u-boot
On Mon, Sep 21, 2020 at 10:20:18AM +0800, Bin Meng wrote:
> On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The revisions are usually dates in hex-decimal format representing
> > YYYYmmdd. Print them in hex to see this clearly.
> >
> > Before:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> > ...
> > After:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> > ...
> >
> > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > cmd/acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/cmd/acpi.c b/cmd/acpi.c
> > index 085a3a650d1a..a3419b42b556 100644
> > --- a/cmd/acpi.c
> > +++ b/cmd/acpi.c
> > @@ -26,7 +26,7 @@ static void dump_hdr(struct acpi_table_header *hdr)
> > printf("%.*s %08lx %06x", ACPI_NAME_LEN, hdr->signature,
> > (ulong)map_to_sysmem(hdr), hdr->length);
> > if (has_hdr) {
> > - printf(" (v%02d %.6s %.8s %u %.4s %d)\n", hdr->revision,
> > + printf(" (v%02d %.6s %.8s %x %.4s %x)\n", hdr->revision,
> > hdr->oem_id, hdr->oem_table_id, hdr->oem_revision,
> > hdr->aslc_id, hdr->aslc_revision);
> > } else {
> > --
>
> This unfortunately breaks the unit test.
>
> /u/test/dm/acpi.c:371, dm_test_acpi_cmd_list(): console:
> Expected 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 538970401 INTL 0)',
> got 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 20200921 INTL 0)'
> Failures: 2
>
> Would you please resend v2 to fix this?
v2 has been just sent. Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-09-21 8:36 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
2020-09-08 15:17 ` Andy Shevchenko
2020-09-08 15:32 ` Wolfgang Wallner
2020-09-08 15:48 ` Andy Shevchenko
2020-09-09 7:15 ` Wolfgang Wallner
2020-09-09 8:51 ` Andy Shevchenko
2020-09-21 1:31 ` Bin Meng
2020-09-21 1:35 ` Bin Meng
2020-09-21 2:20 ` Bin Meng
2020-09-21 8:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox