public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH RFC 03/10] image: Add support for placing crypto_algo in linker lists
Date: Fri, 14 May 2021 14:45:55 -0500	[thread overview]
Message-ID: <20210514194602.598322-4-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20210514194602.598322-1-mr.nuke.me@gmail.com>

The purpose of this change is to enable crypto algorithms to be placed
in linker lists, rather than be declared as a static array. The goal
is to remove the crypto_algos array in a subsequent patch.

Create a new linker list named "cryptos", and search it when
image_get_crypto_algo() is invoked.

NOTE that adding support for manual relocation of crypto_algos within
linker lists is beyond the scope of this patch.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
 common/image-sig.c | 9 +++++++++
 include/image.h    | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/common/image-sig.c b/common/image-sig.c
index 698b044d50..2b7e23f99a 100644
--- a/common/image-sig.c
+++ b/common/image-sig.c
@@ -107,6 +107,7 @@ struct checksum_algo *image_get_checksum_algo(const char *full_name)
 
 struct crypto_algo *image_get_crypto_algo(const char *full_name)
 {
+	struct crypto_algo *crypto, *end;
 	int i;
 	const char *name;
 
@@ -133,6 +134,14 @@ struct crypto_algo *image_get_crypto_algo(const char *full_name)
 			return &crypto_algos[i];
 	}
 
+	crypto = ll_entry_start(struct crypto_algo, cryptos);
+	end = ll_entry_end(struct crypto_algo, cryptos);
+	for (; crypto < end; crypto++) {
+		if (!strcmp(crypto->name, name))
+			return crypto;
+	}
+
+	/* Not found */
 	return NULL;
 }
 
diff --git a/include/image.h b/include/image.h
index 459685d4d4..1bda4ef725 100644
--- a/include/image.h
+++ b/include/image.h
@@ -47,6 +47,7 @@ struct fdt_region;
 #include <lmb.h>
 #include <asm/u-boot.h>
 #include <command.h>
+#include <linker_lists.h>
 
 /* Take notice of the 'ignore' property for hashes */
 #define IMAGE_ENABLE_IGNORE	1
@@ -1362,6 +1363,10 @@ struct crypto_algo {
 		      uint8_t *sig, uint sig_len);
 };
 
+/* Declare a new U-Boot crypto algorithm handler */
+#define U_BOOT_CRYPTO_ALGO(__name)						\
+ll_entry_declare(struct crypto_algo, __name, cryptos)
+
 struct padding_algo {
 	const char *name;
 	int (*verify)(struct image_sign_info *info,
-- 
2.31.1

  parent reply	other threads:[~2021-05-14 19:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 19:45 [PATCH RFC 00/10] image: Reduce the abuse of #ifdefs in image-sig.c Alexandru Gagniuc
2021-05-14 19:45 ` [PATCH RFC 01/10] common: Move host-only logic in image-sig.c to separate file Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-17 14:19     ` Alex G.
2021-05-14 19:45 ` [PATCH RFC 02/10] common: image-sig.c: Remove host-specific logic and #ifdefs Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:45 ` Alexandru Gagniuc [this message]
2021-05-15 15:20   ` [PATCH RFC 03/10] image: Add support for placing crypto_algo in linker lists Simon Glass
2021-05-14 19:45 ` [PATCH RFC 04/10] [UNTESTED] image: Add support for relocating crypto_algos " Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-19  7:07     ` Michal Simek
2021-05-14 19:45 ` [PATCH RFC 05/10] image: rsa: Move verification algorithm to a linker list Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 06/10] image: image-sig.c: Remove crypto_algos array Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 07/10] lib: ecdsa: Remove #ifdefs from ecdsa.h Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:46 ` [PATCH RFC 08/10] lib: rsa: Remove #ifdefs from rsa.h Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:46 ` [PATCH RFC 09/10] image: Eliminate IMAGE_ENABLE_VERIFY macro Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass
2021-05-14 19:46 ` [PATCH RFC 10/10] image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro Alexandru Gagniuc
2021-05-15 15:20   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514194602.598322-4-mr.nuke.me@gmail.com \
    --to=mr.nuke.me@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox