From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH RFC 08/10] lib: rsa: Remove #ifdefs from rsa.h
Date: Fri, 14 May 2021 14:46:00 -0500 [thread overview]
Message-ID: <20210514194602.598322-9-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20210514194602.598322-1-mr.nuke.me@gmail.com>
It is no longer necessary to implement rsa_() functions as no-ops
depending on config options. It is merely sufficient to provide the
prototypes, as the rsa code is no longer linked when unused.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
include/u-boot/rsa.h | 47 --------------------------------------------
1 file changed, 47 deletions(-)
diff --git a/include/u-boot/rsa.h b/include/u-boot/rsa.h
index bed1c097c2..4ac373cd5e 100644
--- a/include/u-boot/rsa.h
+++ b/include/u-boot/rsa.h
@@ -31,7 +31,6 @@ struct rsa_public_key {
struct image_sign_info;
-#if IMAGE_ENABLE_SIGN
/**
* sign() - calculate and return signature for given input data
*
@@ -66,22 +65,7 @@ int rsa_sign(struct image_sign_info *info,
other -ve value on error
*/
int rsa_add_verify_data(struct image_sign_info *info, void *keydest);
-#else
-static inline int rsa_sign(struct image_sign_info *info,
- const struct image_region region[], int region_count,
- uint8_t **sigp, uint *sig_len)
-{
- return -ENXIO;
-}
-
-static inline int rsa_add_verify_data(struct image_sign_info *info,
- void *keydest)
-{
- return -ENXIO;
-}
-#endif
-#if IMAGE_ENABLE_VERIFY
/**
* rsa_verify_hash() - Verify a signature against a hash
*
@@ -124,37 +108,6 @@ int padding_pss_verify(struct image_sign_info *info,
uint8_t *msg, int msg_len,
const uint8_t *hash, int hash_len);
#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */
-#else
-static inline int rsa_verify_hash(struct image_sign_info *info,
- const uint8_t *hash,
- uint8_t *sig, uint sig_len)
-{
- return -ENXIO;
-}
-
-static inline int rsa_verify(struct image_sign_info *info,
- const struct image_region region[], int region_count,
- uint8_t *sig, uint sig_len)
-{
- return -ENXIO;
-}
-
-static inline int padding_pkcs_15_verify(struct image_sign_info *info,
- uint8_t *msg, int msg_len,
- const uint8_t *hash, int hash_len)
-{
- return -ENXIO;
-}
-
-#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT
-static inline int padding_pss_verify(struct image_sign_info *info,
- uint8_t *msg, int msg_len,
- const uint8_t *hash, int hash_len)
-{
- return -ENXIO;
-}
-#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */
-#endif
#define RSA_DEFAULT_PADDING_NAME "pkcs-1.5"
--
2.31.1
next prev parent reply other threads:[~2021-05-14 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 19:45 [PATCH RFC 00/10] image: Reduce the abuse of #ifdefs in image-sig.c Alexandru Gagniuc
2021-05-14 19:45 ` [PATCH RFC 01/10] common: Move host-only logic in image-sig.c to separate file Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-17 14:19 ` Alex G.
2021-05-14 19:45 ` [PATCH RFC 02/10] common: image-sig.c: Remove host-specific logic and #ifdefs Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 03/10] image: Add support for placing crypto_algo in linker lists Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 04/10] [UNTESTED] image: Add support for relocating crypto_algos " Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-19 7:07 ` Michal Simek
2021-05-14 19:45 ` [PATCH RFC 05/10] image: rsa: Move verification algorithm to a linker list Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 06/10] image: image-sig.c: Remove crypto_algos array Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:45 ` [PATCH RFC 07/10] lib: ecdsa: Remove #ifdefs from ecdsa.h Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:46 ` Alexandru Gagniuc [this message]
2021-05-15 15:20 ` [PATCH RFC 08/10] lib: rsa: Remove #ifdefs from rsa.h Simon Glass
2021-05-14 19:46 ` [PATCH RFC 09/10] image: Eliminate IMAGE_ENABLE_VERIFY macro Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
2021-05-14 19:46 ` [PATCH RFC 10/10] image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro Alexandru Gagniuc
2021-05-15 15:20 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514194602.598322-9-mr.nuke.me@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox