public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Stefan Roese <sr@denx.de>
Cc: pali@kernel.org, U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design
Date: Tue, 13 Sep 2022 18:11:37 +0200	[thread overview]
Message-ID: <20220913181137.54c55e1f@dellmb> (raw)
In-Reply-To: <20220913161028.3785-1-kabel@kernel.org>

On Tue, 13 Sep 2022 18:10:28 +0200
Marek Behún <kabel@kernel.org> wrote:

> It seems that waiting only 10 ms after releasing LAN switch from reset
> is not enough for the strapping pins to latch the requested values.
> P6_MODE[0] is latched to 0 instead of 1.
> 
> Increasing the delay to 50 ms fixes this issue.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
>  board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index a7f96e5b77..19c5043fcb 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -654,7 +654,7 @@ static void initialize_switch(void)
>  	ctrl[1] = EXT_CTL_nRES_LAN;
>  	err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
>  
> -	mdelay(10);
> +	mdelay(50);
>  
>  	/* Change RGMII pins back to RGMII mode */
>  

I forgot to add

Fixes: 1da53ae26afc ("arm: mvebu: turris_omnia: Add support for design with SW reset signals")

  reply	other threads:[~2022-09-13 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 16:10 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Marek Behún
2022-09-13 16:11 ` Marek Behún [this message]
2022-09-14  6:22 ` Stefan Roese
2022-09-18 10:49 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220913181137.54c55e1f@dellmb \
    --to=kabel@kernel.org \
    --cc=pali@kernel.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox