* [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design
@ 2022-09-13 16:10 Marek Behún
2022-09-13 16:11 ` Marek Behún
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Behún @ 2022-09-13 16:10 UTC (permalink / raw)
To: Stefan Roese; +Cc: pali, U-Boot Mailing List, Marek Behún
It seems that waiting only 10 ms after releasing LAN switch from reset
is not enough for the strapping pins to latch the requested values.
P6_MODE[0] is latched to 0 instead of 1.
Increasing the delay to 50 ms fixes this issue.
Signed-off-by: Marek Behún <kabel@kernel.org>
---
board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index a7f96e5b77..19c5043fcb 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -654,7 +654,7 @@ static void initialize_switch(void)
ctrl[1] = EXT_CTL_nRES_LAN;
err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
- mdelay(10);
+ mdelay(50);
/* Change RGMII pins back to RGMII mode */
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design
2022-09-13 16:10 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Marek Behún
@ 2022-09-13 16:11 ` Marek Behún
2022-09-14 6:22 ` Stefan Roese
2022-09-18 10:49 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Marek Behún @ 2022-09-13 16:11 UTC (permalink / raw)
To: Stefan Roese; +Cc: pali, U-Boot Mailing List
On Tue, 13 Sep 2022 18:10:28 +0200
Marek Behún <kabel@kernel.org> wrote:
> It seems that waiting only 10 ms after releasing LAN switch from reset
> is not enough for the strapping pins to latch the requested values.
> P6_MODE[0] is latched to 0 instead of 1.
>
> Increasing the delay to 50 ms fixes this issue.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
> board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index a7f96e5b77..19c5043fcb 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -654,7 +654,7 @@ static void initialize_switch(void)
> ctrl[1] = EXT_CTL_nRES_LAN;
> err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
>
> - mdelay(10);
> + mdelay(50);
>
> /* Change RGMII pins back to RGMII mode */
>
I forgot to add
Fixes: 1da53ae26afc ("arm: mvebu: turris_omnia: Add support for design with SW reset signals")
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design
2022-09-13 16:10 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Marek Behún
2022-09-13 16:11 ` Marek Behún
@ 2022-09-14 6:22 ` Stefan Roese
2022-09-18 10:49 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-09-14 6:22 UTC (permalink / raw)
To: Marek Behún; +Cc: pali, U-Boot Mailing List
On 13.09.22 18:10, Marek Behún wrote:
> It seems that waiting only 10 ms after releasing LAN switch from reset
> is not enough for the strapping pins to latch the requested values.
> P6_MODE[0] is latched to 0 instead of 1.
>
> Increasing the delay to 50 ms fixes this issue.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index a7f96e5b77..19c5043fcb 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -654,7 +654,7 @@ static void initialize_switch(void)
> ctrl[1] = EXT_CTL_nRES_LAN;
> err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
>
> - mdelay(10);
> + mdelay(50);
>
> /* Change RGMII pins back to RGMII mode */
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design
2022-09-13 16:10 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Marek Behún
2022-09-13 16:11 ` Marek Behún
2022-09-14 6:22 ` Stefan Roese
@ 2022-09-18 10:49 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-09-18 10:49 UTC (permalink / raw)
To: Marek Behún; +Cc: pali, U-Boot Mailing List
On 13.09.22 18:10, Marek Behún wrote:
> It seems that waiting only 10 ms after releasing LAN switch from reset
> is not enough for the strapping pins to latch the requested values.
> P6_MODE[0] is latched to 0 instead of 1.
>
> Increasing the delay to 50 ms fixes this issue.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index a7f96e5b77..19c5043fcb 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -654,7 +654,7 @@ static void initialize_switch(void)
> ctrl[1] = EXT_CTL_nRES_LAN;
> err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
>
> - mdelay(10);
> + mdelay(50);
>
> /* Change RGMII pins back to RGMII mode */
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-18 10:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 16:10 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Marek Behún
2022-09-13 16:11 ` Marek Behún
2022-09-14 6:22 ` Stefan Roese
2022-09-18 10:49 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox