public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Yu Chien Peter Lin <peterlin@andestech.com>
To: <u-boot@lists.denx.de>
Cc: <ycliang@andestech.com>, <rick@andestech.com>,
	<prabhakar.csengg@gmail.com>,
	Yu Chien Peter Lin <peterlin@andestech.com>
Subject: [PATCH v2 03/10] driver: cache: cache-v5l2: Update memory-mapped scheme to support Gen2 platform
Date: Mon, 6 Feb 2023 16:10:46 +0800	[thread overview]
Message-ID: <20230206081053.1716-4-peterlin@andestech.com> (raw)
In-Reply-To: <20230206081053.1716-1-peterlin@andestech.com>

The L2C configuration register has MAP field to indicate its version
is v0 (Gen1) or v1 (Gen2) L2-cache. This patch makes the driver
compatible with both memory-mapped scheme.

Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
 drivers/cache/cache-v5l2.c | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)

diff --git a/drivers/cache/cache-v5l2.c b/drivers/cache/cache-v5l2.c
index bbdb76bd57..e782430c57 100644
--- a/drivers/cache/cache-v5l2.c
+++ b/drivers/cache/cache-v5l2.c
@@ -34,6 +34,14 @@ struct l2cache {
 	volatile u64	cctl_status;
 };
 
+/* Configuration register */
+#define MEM_MAP_OFF	20
+#define MEM_MAP_MSK	BIT(MEM_MAP_OFF)
+/* offset of v0 memory map (Gen1) */
+static u32 cmd_stride = 0x10;
+static u32 status_stride = 0x0;
+static u32 status_bit_offset = 0x4;
+
 /* Control Register */
 #define L2_ENABLE	0x1
 /* prefetch */
@@ -53,14 +61,15 @@ struct l2cache {
 #define DRAMICTL_MSK	BIT(DRAMICTL_OFF)
 
 /* CCTL Command Register */
-#define CCTL_CMD_REG(base, hart)	((ulong)(base) + 0x40 + (hart) * 0x10)
+#define CCTL_CMD_REG(base, hart)	((ulong)(base) + 0x40 + (hart) * (cmd_stride))
 #define L2_WBINVAL_ALL	0x12
 
 /* CCTL Status Register */
-#define CCTL_STATUS_MSK(hart)		(0xf << ((hart) * 4))
-#define CCTL_STATUS_IDLE(hart)		(0 << ((hart) * 4))
-#define CCTL_STATUS_PROCESS(hart)	(1 << ((hart) * 4))
-#define CCTL_STATUS_ILLEGAL(hart)	(2 << ((hart) * 4))
+#define CCTL_STATUS_REG(base, hart)	((ulong)(base) + 0x80 + (hart) * (status_stride))
+#define CCTL_STATUS_MSK(hart)		(0xf << ((hart) * (status_bit_offset)))
+#define CCTL_STATUS_IDLE(hart)		(0 << ((hart) * (status_bit_offset)))
+#define CCTL_STATUS_PROCESS(hart)	(1 << ((hart) * (status_bit_offset)))
+#define CCTL_STATUS_ILLEGAL(hart)	(2 << ((hart) * (status_bit_offset)))
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -133,12 +142,19 @@ static int v5l2_probe(struct udevice *dev)
 {
 	struct v5l2_plat *plat = dev_get_plat(dev);
 	struct l2cache *regs = plat->regs;
-	u32 ctl_val;
+	u32 cfg_val, ctl_val;
 
+	cfg_val = readl(&regs->configure);
 	ctl_val = readl(&regs->control);
 
-	if (!(ctl_val & L2_ENABLE))
-		ctl_val |= L2_ENABLE;
+	/* If true, v1 memory map (Gen2) */
+	if (cfg_val & MEM_MAP_MSK) {
+		cmd_stride = 0x1000;
+		status_stride = 0x1000;
+		status_bit_offset = 0x0;
+	}
+
+	ctl_val |= L2_ENABLE;
 
 	if (plat->iprefetch != -EINVAL) {
 		ctl_val &= ~(IPREPETCH_MSK);
-- 
2.34.1


  parent reply	other threads:[~2023-02-06  8:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  8:10 [PATCH v2 00/10] cache operation cleanups for Andes AE350 platform Yu Chien Peter Lin
2023-02-06  8:10 ` [PATCH v2 01/10] riscv: Remove redundant Kconfig "RISCV_NDS_CACHE" Yu Chien Peter Lin
2023-02-06  8:10 ` [PATCH v2 02/10] board: AndesTech: ax25-ae350.c: Enable v5l2-cache in spl_board_init() Yu Chien Peter Lin
2023-02-06  8:10 ` Yu Chien Peter Lin [this message]
     [not found]   ` <PU1PR03MB299780A8F8A9E40700D3AFF1C1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  1:37     ` [PATCH v2 03/10] driver: cache: cache-v5l2: Update memory-mapped scheme to support Gen2 platform Rick Chen
2023-02-06  8:10 ` [PATCH v2 04/10] riscv: cpu: ax25: Simplify cache enabling logic in harts_early_init() Yu Chien Peter Lin
     [not found]   ` <PU1PR03MB2997F3D15C2AEE4EA0622A9EC1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  1:43     ` Rick Chen
2023-02-06  8:10 ` [PATCH v2 05/10] riscv: ae350: dts: Update L2 cache compatible string Yu Chien Peter Lin
     [not found]   ` <PU1PR03MB29979A932AB9E25300FA0B3DC1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  1:50     ` Rick Chen
2023-02-06  8:10 ` [PATCH v2 06/10] riscv: ax25: cache.c: Cleanups to L1/L2 cache function used in SPL Yu Chien Peter Lin
     [not found]   ` <PU1PR03MB29979831919688FE773ECD5DC1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  1:55     ` Rick Chen
2023-02-06  8:10 ` [PATCH v2 07/10] configs: ae350: Enable v5l2 cache for AE350 platforms " Yu Chien Peter Lin
     [not found]   ` <PU1PR03MB29970FA2B9B1C5190208AB58C1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  2:02     ` Rick Chen
2023-02-06  8:10 ` [PATCH v2 08/10] configs: ae350: Increase maximum retry count for AE350 platforms Yu Chien Peter Lin
2023-02-06  8:10 ` [PATCH v2 09/10] configs: ae350: Display CPU and board info " Yu Chien Peter Lin
     [not found]   ` <PU1PR03MB2997124FC7A3EC9330D26D12C1D89@PU1PR03MB2997.apcprd03.prod.outlook.com>
2023-02-08  2:20     ` Rick Chen
2023-02-06  8:10 ` [PATCH v2 10/10] driver: cache-v5l2: Fix type casting warning on RV32 Yu Chien Peter Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206081053.1716-4-peterlin@andestech.com \
    --to=peterlin@andestech.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=rick@andestech.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox