From: Jagan Teki <jagan@amarulasolutions.com>
To: Kever Yang <kever.yang@rock-chips.com>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Jonas Karlman <jonas@kwiboo.se>,
u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,
Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v2 1/7] arm64: dts: rockchip: Drop unused rk3328-xhci node
Date: Tue, 6 Jun 2023 22:39:12 +0530 [thread overview]
Message-ID: <20230606170918.45581-2-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20230606170918.45581-1-jagan@amarulasolutions.com>
rk3328-xhci has been added due to the fact that the upstream
dwc3 is unsupported. Moreover, the driver for rk3328-xhci is
not added to the code tree.
By considering these facts and unsupported rk3328-xhci this
patch is dropping all related code from DT. However, the DWC3
is fixed now in dwc3-generic and RK3328 USB 3.0 is functional
in upcoming patches.
Let's drop it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- none
arch/arm/dts/rk3328-evb-u-boot.dtsi | 5 -----
arch/arm/dts/rk3328-roc-cc-u-boot.dtsi | 14 --------------
arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi | 5 -----
arch/arm/dts/rk3328-rock64-u-boot.dtsi | 15 ---------------
arch/arm/dts/rk3328-u-boot.dtsi | 11 -----------
5 files changed, 50 deletions(-)
diff --git a/arch/arm/dts/rk3328-evb-u-boot.dtsi b/arch/arm/dts/rk3328-evb-u-boot.dtsi
index 4bfa0c2330..f9c729d3bd 100644
--- a/arch/arm/dts/rk3328-evb-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-evb-u-boot.dtsi
@@ -44,8 +44,3 @@
/* Integrated PHY unsupported by U-boot */
status = "broken";
};
-
-&usb_host0_xhci {
- vbus-supply = <&vcc5v0_host_xhci>;
- status = "okay";
-};
diff --git a/arch/arm/dts/rk3328-roc-cc-u-boot.dtsi b/arch/arm/dts/rk3328-roc-cc-u-boot.dtsi
index 27a454f017..2062f34bf8 100644
--- a/arch/arm/dts/rk3328-roc-cc-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-roc-cc-u-boot.dtsi
@@ -48,20 +48,6 @@
bootph-pre-ram;
};
-&usb_host0_xhci {
- vbus-supply = <&vcc_host1_5v>;
- status = "okay";
-};
-
-/*
- * This makes XHCI responsible for toggling VBUS. This is needed to work
- * around an issue where either XHCI only works with USB 2.0 or OTG doesn't
- * work, depending on how VBUS is configured. Having USB 3.0 seems better.
- */
-&vcc_host1_5v {
- /delete-property/ regulator-always-on;
-};
-
/* Need this and all the pinctrl/gpio stuff above to set pinmux */
&vcc_sd {
bootph-pre-ram;
diff --git a/arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi b/arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi
index 088e21c76a..1f220c6dcd 100644
--- a/arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi
@@ -45,11 +45,6 @@
bootph-pre-ram;
};
-&usb_host0_xhci {
- vbus-supply = <&vcc_host_5v>;
- status = "okay";
-};
-
/* Need this and all the pinctrl/gpio stuff above to set pinmux */
&vcc_sd {
bootph-pre-ram;
diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
index c20a99a620..849854302e 100644
--- a/arch/arm/dts/rk3328-rock64-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-rock64-u-boot.dtsi
@@ -48,21 +48,6 @@
bootph-pre-ram;
};
-&usb_host0_xhci {
- vbus-supply = <&vcc_host_5v>;
- status = "okay";
-};
-
-/*
- * This makes XHCI responsible for toggling VBUS. This is needed to work
- * around an issue where either XHCI only works with USB 2.0 or OTG doesn't
- * work, depending on how VBUS is configured. Having USB 3.0 seems better.
- */
-&vcc_host_5v {
- /delete-property/ regulator-always-on;
- /delete-property/ regulator-boot-on;
-};
-
/* Need this and all the pinctrl/gpio stuff above to set pinmux */
&vcc_sd {
bootph-pre-ram;
diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi
index 668f8ca29d..ce96ce40a7 100644
--- a/arch/arm/dts/rk3328-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-u-boot.dtsi
@@ -26,17 +26,6 @@
0x0 0xff720000 0x0 0x1000
0x0 0xff798000 0x0 0x1000>;
};
-
- usb_host0_xhci: usb@ff600000 {
- compatible = "rockchip,rk3328-xhci";
- reg = <0x0 0xff600000 0x0 0x100000>;
- interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
- snps,dis-enblslpm-quirk;
- snps,phyif-utmi-bits = <16>;
- snps,dis-u2-freeclk-exists-quirk;
- snps,dis-u2-susphy-quirk;
- status = "disabled";
- };
};
&cru {
--
2.25.1
next prev parent reply other threads:[~2023-06-06 17:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 17:09 [PATCH v2 0/7] rockchip: Fix RK3328 USB support Jagan Teki
2023-06-06 17:09 ` Jagan Teki [this message]
2023-07-26 10:59 ` [PATCH v2 1/7] arm64: dts: rockchip: Drop unused rk3328-xhci node Kever Yang
2023-06-06 17:09 ` [PATCH v2 2/7] configs: Drop unused XHCI_DWC3 for RK3328 boards Jagan Teki
2023-07-26 11:00 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328 Jagan Teki
2023-06-11 14:53 ` Peter Robinson
2023-06-11 16:25 ` Jagan Teki
2023-07-26 11:00 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 4/7] configs: Enable DWC3 USB 3.0 on RK3328 boards Jagan Teki
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328 Jagan Teki
2023-06-07 9:12 ` Xavier Drudis Ferran
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 6/7] clk: rockchip: rk3328: Handle usb480m phy clock Jagan Teki
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 7/7] configs: rockchip: Enable USB2PHY for RK3328 boards Jagan Teki
2023-07-26 11:02 ` Kever Yang
2023-06-11 22:31 ` [PATCH v2 0/7] rockchip: Fix RK3328 USB support Peter Robinson
2023-07-13 9:31 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606170918.45581-2-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox