From: Kever Yang <kever.yang@rock-chips.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Jonas Karlman <jonas@kwiboo.se>,
u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328
Date: Wed, 26 Jul 2023 19:00:52 +0800 [thread overview]
Message-ID: <897f2a69-e50b-ff56-c31b-b54a3255b5f1@rock-chips.com> (raw)
In-Reply-To: <20230606170918.45581-4-jagan@amarulasolutions.com>
On 2023/6/7 01:09, Jagan Teki wrote:
> Like Rockchip RK3568, the RK3328 also have single node to
> represent the glue and ctrl for USB 3.0.
>
> So, use the driver data to use single ctrl for RK3328 DWC3.
>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> Changes for v2:
> - collect Marek RB
>
> drivers/usb/dwc3/dwc3-generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> index 5f8c2613a4..dcf420bafd 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -621,7 +621,7 @@ static const struct udevice_id dwc3_glue_ids[] = {
> { .compatible = "ti,dwc3", .data = (ulong)&ti_ops },
> { .compatible = "ti,am437x-dwc3", .data = (ulong)&ti_ops },
> { .compatible = "ti,am654-dwc3" },
> - { .compatible = "rockchip,rk3328-dwc3" },
> + { .compatible = "rockchip,rk3328-dwc3", .data = (ulong)&rk_ops },
> { .compatible = "rockchip,rk3399-dwc3" },
> { .compatible = "rockchip,rk3568-dwc3", .data = (ulong)&rk_ops },
> { .compatible = "qcom,dwc3" },
next prev parent reply other threads:[~2023-07-26 16:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 17:09 [PATCH v2 0/7] rockchip: Fix RK3328 USB support Jagan Teki
2023-06-06 17:09 ` [PATCH v2 1/7] arm64: dts: rockchip: Drop unused rk3328-xhci node Jagan Teki
2023-07-26 10:59 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 2/7] configs: Drop unused XHCI_DWC3 for RK3328 boards Jagan Teki
2023-07-26 11:00 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328 Jagan Teki
2023-06-11 14:53 ` Peter Robinson
2023-06-11 16:25 ` Jagan Teki
2023-07-26 11:00 ` Kever Yang [this message]
2023-06-06 17:09 ` [PATCH v2 4/7] configs: Enable DWC3 USB 3.0 on RK3328 boards Jagan Teki
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328 Jagan Teki
2023-06-07 9:12 ` Xavier Drudis Ferran
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 6/7] clk: rockchip: rk3328: Handle usb480m phy clock Jagan Teki
2023-07-26 11:01 ` Kever Yang
2023-06-06 17:09 ` [PATCH v2 7/7] configs: rockchip: Enable USB2PHY for RK3328 boards Jagan Teki
2023-07-26 11:02 ` Kever Yang
2023-06-11 22:31 ` [PATCH v2 0/7] rockchip: Fix RK3328 USB support Peter Robinson
2023-07-13 9:31 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897f2a69-e50b-ff56-c31b-b54a3255b5f1@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jonas@kwiboo.se \
--cc=linux-amarula@amarulasolutions.com \
--cc=marex@denx.de \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox