Re: [PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328

[Xavier Drudis Ferran <xdrudis@tinet.cat>]

El Tue, Jun 06, 2023 at 10:39:16PM +0530, Jagan Teki deia:
> USB2.0 Host and OTG controllers in RK3328 are using USB2PHY.
> 
> Add support for it.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Xavier Drudis Ferran <xdrudis@tinet.cat>

(fwiw, I just compared it with linux)

I just wanted to note this patch as written most likely depends on
https://patchwork.ozlabs.org/project/uboot/patch/464111fca83008503022e8ada5305e69ffd1afbd.1685974993.git.xdrudis@tinet.cat/

which introduces the struct member clkout_ctl used here.


> ---
> Changes for v2:
> - add clkout_ctl
> 
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index e43a5ba9b5..d8738f891d 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -345,6 +345,36 @@ bind_fail:
>  	return ret;
>  }
>  
> +static const struct rockchip_usb2phy_cfg rk3328_usb2phy_cfgs[] = {
> +	{
> +		.reg = 0x100,
> +		.clkout_ctl	= { 0x108, 4, 4, 1, 0 },
[...]