[PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Udit Kumar]

Increase malloc size to 32 MB to align with other J7
family devices.

Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
 configs/j784s4_evm_a72_defconfig | 1 +
 configs/j784s4_evm_r5_defconfig  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/j784s4_evm_a72_defconfig b/configs/j784s4_evm_a72_defconfig
index 3cfa006f86..520a53b12f 100644
--- a/configs/j784s4_evm_a72_defconfig
+++ b/configs/j784s4_evm_a72_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_K3=y
+CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SYS_MALLOC_F_LEN=0x8000
 CONFIG_SPL_GPIO=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
diff --git a/configs/j784s4_evm_r5_defconfig b/configs/j784s4_evm_r5_defconfig
index 7ace661526..543b0a50d7 100644
--- a/configs/j784s4_evm_r5_defconfig
+++ b/configs/j784s4_evm_r5_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_K3=y
+CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_SPL_GPIO=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
-- 
2.34.1

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Francesco Dolcini]

Hello,

On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
> Increase malloc size to 32 MB to align with other J7
> family devices.

Is this needed for any specific reason? I am asking to understand if
other boards using the same SOC should be updated to prevent
$random_issue.

Francesco

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Kumar, Udit]

Hi Francesco

On 7/17/2024 1:35 AM, Francesco Dolcini wrote:
> Hello,
>
> On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
>> Increase malloc size to 32 MB to align with other J7
>> family devices.
> Is this needed for any specific reason? I am asking to understand if
> other boards using the same SOC should be updated to prevent
> $random_issue.

In our downstream version, we are seeing an issue , while using DFU to MMC

Please see

https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82 



Since DFU is not supported yet in mainline u-boot, so I avoided to 
mention that failure.

Also this change is generic, so i thought of pushing it now instead of 
waiting for DFU series.


> Francesco
>

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Francesco Dolcini]

Hello,

On Wed, Jul 17, 2024 at 09:40:11AM +0530, Kumar, Udit wrote:
> On 7/17/2024 1:35 AM, Francesco Dolcini wrote:
> > On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
> > > Increase malloc size to 32 MB to align with other J7
> > > family devices.
> > Is this needed for any specific reason? I am asking to understand if
> > other boards using the same SOC should be updated to prevent
> > $random_issue.
> Since DFU is not supported yet in mainline u-boot, so I avoided to mention
> that failure.
> 
> Also this change is generic, so i thought of pushing it now instead of
> waiting for DFU series.

Thanks for the update, on our board DFU works fine on our j784s4 based
board (UUU or UMS are not working, but this is off topic for this
conversation ;-)

Francesco

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Nishanth Menon]

On 09:33-20240717, Francesco Dolcini wrote:
> Hello,
> 
> On Wed, Jul 17, 2024 at 09:40:11AM +0530, Kumar, Udit wrote:
> > On 7/17/2024 1:35 AM, Francesco Dolcini wrote:
> > > On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
> > > > Increase malloc size to 32 MB to align with other J7
> > > > family devices.
> > > Is this needed for any specific reason? I am asking to understand if
> > > other boards using the same SOC should be updated to prevent
> > > $random_issue.
> > Since DFU is not supported yet in mainline u-boot, so I avoided to mention
> > that failure.
> > 
> > Also this change is generic, so i thought of pushing it now instead of
> > waiting for DFU series.
> 
> Thanks for the update, on our board DFU works fine on our j784s4 based
> board (UUU or UMS are not working, but this is off topic for this
> conversation ;-)

I still think your comment is valid - commit message does need to
explain something like "make space for future standard features such as
DFU etc.."

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Nishanth Menon]

On 09:40-20240717, Kumar, Udit wrote:
> Hi Francesco
> 
> On 7/17/2024 1:35 AM, Francesco Dolcini wrote:
> > Hello,
> > 
> > On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
> > > Increase malloc size to 32 MB to align with other J7
> > > family devices.
> > Is this needed for any specific reason? I am asking to understand if
> > other boards using the same SOC should be updated to prevent
> > $random_issue.
> 
> In our downstream version, we are seeing an issue , while using DFU to MMC
> 
> Please see
> 
> https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82
> 
> 
> 
> Since DFU is not supported yet in mainline u-boot, so I avoided to mention
> that failure.
> 
> Also this change is generic, so i thought of pushing it now instead of
> waiting for DFU series.

if we are going to repeat this over and over - does it make sense to
have this in include? so that *other* board manufacturers do not need to
re-discover this?


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Francesco Dolcini]

On Wed, Jul 17, 2024 at 09:09:13AM -0500, Nishanth Menon wrote:
> On 09:40-20240717, Kumar, Udit wrote:
> > On 7/17/2024 1:35 AM, Francesco Dolcini wrote:
> > > On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote:
> > > > Increase malloc size to 32 MB to align with other J7
> > > > family devices.
> > > Is this needed for any specific reason? I am asking to understand if
> > > other boards using the same SOC should be updated to prevent
> > > $random_issue.
> > 
> > In our downstream version, we are seeing an issue , while using DFU to MMC
> > 
> > Please see
> > 
> > https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82
> > 
> > 
> > 
> > Since DFU is not supported yet in mainline u-boot, so I avoided to mention
> > that failure.
> > 
> > Also this change is generic, so i thought of pushing it now instead of
> > waiting for DFU series.
> 
> if we are going to repeat this over and over - does it make sense to
> have this in include? so that *other* board manufacturers do not need to
> re-discover this?

The reason we (our board) might be fine, is that we have

default 0x2000000 if ARCH_ROCKCHIP || ARCH_OMAP2PLUS || ARCH_MESON || ARCH_K3

from the downstream TI branch (the specific board we have with J784S4 is
not in mainline yet).

Francesco

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

[Tom Rini]

On Mon, 15 Jul 2024 23:13:01 +0530, Udit Kumar wrote:

> Increase malloc size to 32 MB to align with other J7
> family devices.
> 
> 

Applied to u-boot/master, thanks!

-- 
Tom