* [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
@ 2025-03-28 10:20 rafael
2025-03-28 12:52 ` Francesco Dolcini
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: rafael @ 2025-03-28 10:20 UTC (permalink / raw)
To: Francesco Dolcini, Tom Rini; +Cc: Rafael Beims, u-boot, rafael
From: Rafael Beims <rafael.beims@toradex.com>
If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
enabled, the build fails for the Apalis iMX6 board.
Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
---
board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/board/toradex/apalis_imx6/apalis_imx6.c b/board/toradex/apalis_imx6/apalis_imx6.c
index ec0f223c4aa6..0329563761b4 100644
--- a/board/toradex/apalis_imx6/apalis_imx6.c
+++ b/board/toradex/apalis_imx6/apalis_imx6.c
@@ -463,10 +463,12 @@ static iomux_v3_cfg_t const rgb_pads[] = {
MX6_PAD_EIM_D31__IPU1_DISP1_DATA20 | MUX_PAD_CTRL(OUTPUT_RGB),
};
+#ifdef CONFIG_IMX_HDMI
static void do_enable_hdmi(struct display_info_t const *dev)
{
imx_enable_hdmi_phy();
}
+#endif
static void enable_lvds(struct display_info_t const *dev)
{
@@ -496,7 +498,9 @@ static int detect_default(struct display_info_t const *dev)
return 1;
}
-struct display_info_t const displays[] = {{
+struct display_info_t const displays[] = {
+#ifdef CONFIG_IMX_HDMI
+{
.bus = -1,
.addr = 0,
.pixfmt = IPU_PIX_FMT_RGB24,
@@ -516,7 +520,9 @@ struct display_info_t const displays[] = {{
.vsync_len = 10,
.sync = FB_SYNC_EXT,
.vmode = FB_VMODE_NONINTERLACED
-} }, {
+} },
+#endif
+{
.bus = -1,
.addr = 0,
.di = 1,
@@ -586,7 +592,11 @@ static void setup_display(void)
int reg;
enable_ipu_clock();
+
+#ifdef CONFIG_IMX_HDMI
imx_setup_hdmi();
+#endif
+
/* Turn on LDB0,IPU,IPU DI0 clocks */
reg = __raw_readl(&mxc_ccm->CCGR3);
reg |= MXC_CCM_CCGR3_LDB_DI0_MASK;
--
2.47.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
2025-03-28 10:20 [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled rafael
@ 2025-03-28 12:52 ` Francesco Dolcini
2025-03-28 16:05 ` Tom Rini
2025-04-11 14:16 ` Fabio Estevam
2 siblings, 0 replies; 6+ messages in thread
From: Francesco Dolcini @ 2025-03-28 12:52 UTC (permalink / raw)
To: rafael; +Cc: Francesco Dolcini, Tom Rini, Rafael Beims, u-boot
On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> From: Rafael Beims <rafael.beims@toradex.com>
>
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
>
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Francesco
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
2025-03-28 10:20 [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled rafael
2025-03-28 12:52 ` Francesco Dolcini
@ 2025-03-28 16:05 ` Tom Rini
2025-03-30 18:56 ` Francesco Dolcini
2025-04-11 14:16 ` Fabio Estevam
2 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2025-03-28 16:05 UTC (permalink / raw)
To: rafael; +Cc: Francesco Dolcini, Rafael Beims, u-boot
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> From: Rafael Beims <rafael.beims@toradex.com>
>
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
>
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> ---
> board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Is there a reason why this requirement isn't enforced at the Kconfig
level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
otherwise useful and valid configuration?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
2025-03-28 16:05 ` Tom Rini
@ 2025-03-30 18:56 ` Francesco Dolcini
2025-03-31 14:11 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Francesco Dolcini @ 2025-03-30 18:56 UTC (permalink / raw)
To: Tom Rini; +Cc: rafael, Francesco Dolcini, Rafael Beims, u-boot
On Fri, Mar 28, 2025 at 10:05:57AM -0600, Tom Rini wrote:
> On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
>
> > From: Rafael Beims <rafael.beims@toradex.com>
> >
> > If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> > enabled, the build fails for the Apalis iMX6 board.
> >
> > Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > ---
> > board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
>
> Is there a reason why this requirement isn't enforced at the Kconfig
> level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
> otherwise useful and valid configuration?
I would say no. You can have the display output over DPI or LVDS, with
HDMI non being required at all.
Francesco
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
2025-03-30 18:56 ` Francesco Dolcini
@ 2025-03-31 14:11 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2025-03-31 14:11 UTC (permalink / raw)
To: Francesco Dolcini; +Cc: rafael, Francesco Dolcini, Rafael Beims, u-boot
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
On Sun, Mar 30, 2025 at 08:56:32PM +0200, Francesco Dolcini wrote:
> On Fri, Mar 28, 2025 at 10:05:57AM -0600, Tom Rini wrote:
> > On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> >
> > > From: Rafael Beims <rafael.beims@toradex.com>
> > >
> > > If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> > > enabled, the build fails for the Apalis iMX6 board.
> > >
> > > Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> > > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > > ---
> > > board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> > > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > Is there a reason why this requirement isn't enforced at the Kconfig
> > level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
> > otherwise useful and valid configuration?
>
> I would say no. You can have the display output over DPI or LVDS, with
> HDMI non being required at all.
And so yes, it's a useful and valid configuration. OK, thanks.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled
2025-03-28 10:20 [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled rafael
2025-03-28 12:52 ` Francesco Dolcini
2025-03-28 16:05 ` Tom Rini
@ 2025-04-11 14:16 ` Fabio Estevam
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2025-04-11 14:16 UTC (permalink / raw)
To: rafael; +Cc: Francesco Dolcini, Tom Rini, Rafael Beims, u-boot
On Fri, Mar 28, 2025 at 9:43 AM <rafael@beims.me> wrote:
>
> From: Rafael Beims <rafael.beims@toradex.com>
>
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
>
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-04-11 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 10:20 [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled rafael
2025-03-28 12:52 ` Francesco Dolcini
2025-03-28 16:05 ` Tom Rini
2025-03-30 18:56 ` Francesco Dolcini
2025-03-31 14:11 ` Tom Rini
2025-04-11 14:16 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox