[PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[rafael]

From: Rafael Beims <rafael.beims@toradex.com>

If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
enabled, the build fails for the Apalis iMX6 board.

Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
---
 board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/board/toradex/apalis_imx6/apalis_imx6.c b/board/toradex/apalis_imx6/apalis_imx6.c
index ec0f223c4aa6..0329563761b4 100644
--- a/board/toradex/apalis_imx6/apalis_imx6.c
+++ b/board/toradex/apalis_imx6/apalis_imx6.c
@@ -463,10 +463,12 @@ static iomux_v3_cfg_t const rgb_pads[] = {
 	MX6_PAD_EIM_D31__IPU1_DISP1_DATA20 | MUX_PAD_CTRL(OUTPUT_RGB),
 };
 
+#ifdef CONFIG_IMX_HDMI
 static void do_enable_hdmi(struct display_info_t const *dev)
 {
 	imx_enable_hdmi_phy();
 }
+#endif
 
 static void enable_lvds(struct display_info_t const *dev)
 {
@@ -496,7 +498,9 @@ static int detect_default(struct display_info_t const *dev)
 	return 1;
 }
 
-struct display_info_t const displays[] = {{
+struct display_info_t const displays[] = {
+#ifdef CONFIG_IMX_HDMI
+{
 	.bus	= -1,
 	.addr	= 0,
 	.pixfmt	= IPU_PIX_FMT_RGB24,
@@ -516,7 +520,9 @@ struct display_info_t const displays[] = {{
 		.vsync_len      = 10,
 		.sync           = FB_SYNC_EXT,
 		.vmode          = FB_VMODE_NONINTERLACED
-} }, {
+} },
+#endif
+{
 	.bus	= -1,
 	.addr	= 0,
 	.di	= 1,
@@ -586,7 +592,11 @@ static void setup_display(void)
 	int reg;
 
 	enable_ipu_clock();
+
+#ifdef CONFIG_IMX_HDMI
 	imx_setup_hdmi();
+#endif
+
 	/* Turn on LDB0,IPU,IPU DI0 clocks */
 	reg = __raw_readl(&mxc_ccm->CCGR3);
 	reg |= MXC_CCM_CCGR3_LDB_DI0_MASK;
-- 
2.47.2

Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Francesco Dolcini]

On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> From: Rafael Beims <rafael.beims@toradex.com>
> 
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
> 
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco

Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:

> From: Rafael Beims <rafael.beims@toradex.com>
> 
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
> 
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> ---
>  board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

Is there a reason why this requirement isn't enforced at the Kconfig
level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
otherwise useful and valid configuration?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Francesco Dolcini]

On Fri, Mar 28, 2025 at 10:05:57AM -0600, Tom Rini wrote:
> On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> 
> > From: Rafael Beims <rafael.beims@toradex.com>
> > 
> > If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> > enabled, the build fails for the Apalis iMX6 board.
> > 
> > Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > ---
> >  board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> Is there a reason why this requirement isn't enforced at the Kconfig
> level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
> otherwise useful and valid configuration?

I would say no. You can have the display output over DPI or LVDS, with
HDMI non being required at all.

Francesco

Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Sun, Mar 30, 2025 at 08:56:32PM +0200, Francesco Dolcini wrote:
> On Fri, Mar 28, 2025 at 10:05:57AM -0600, Tom Rini wrote:
> > On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> > 
> > > From: Rafael Beims <rafael.beims@toradex.com>
> > > 
> > > If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> > > enabled, the build fails for the Apalis iMX6 board.
> > > 
> > > Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> > > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > > ---
> > >  board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> > >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > Is there a reason why this requirement isn't enforced at the Kconfig
> > level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
> > otherwise useful and valid configuration?
> 
> I would say no. You can have the display output over DPI or LVDS, with
> HDMI non being required at all.

And so yes, it's a useful and valid configuration. OK, thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Fabio Estevam]

On Fri, Mar 28, 2025 at 9:43 AM <rafael@beims.me> wrote:
>
> From: Rafael Beims <rafael.beims@toradex.com>
>
> If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> enabled, the build fails for the Apalis iMX6 board.
>
> Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>

Applied, thanks.