* [PATCH] usb: musb-new: sunxi: remove unused define
@ 2023-06-07 23:16 Sam Edwards
2023-06-08 4:51 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Sam Edwards @ 2023-06-07 23:16 UTC (permalink / raw)
To: u-boot; +Cc: Andre Przywara, Jagan Teki, Marek Vasut, Sam Edwards
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
drivers/usb/musb-new/sunxi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
index 2b954601a0..85d815ad75 100644
--- a/drivers/usb/musb-new/sunxi.c
+++ b/drivers/usb/musb-new/sunxi.c
@@ -81,8 +81,6 @@
* From usbc/usbc.c
******************************************************************************/
-#define OFF_SUN6I_AHB_RESET0 0x2c0
-
struct sunxi_musb_config {
struct musb_hdrc_config *config;
bool has_sram;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: musb-new: sunxi: remove unused define
2023-06-07 23:16 [PATCH] usb: musb-new: sunxi: remove unused define Sam Edwards
@ 2023-06-08 4:51 ` Marek Vasut
2023-06-08 18:45 ` Sam Edwards
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2023-06-08 4:51 UTC (permalink / raw)
To: Sam Edwards, u-boot; +Cc: Andre Przywara, Jagan Teki
On 6/8/23 01:16, Sam Edwards wrote:
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> ---
> drivers/usb/musb-new/sunxi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
> index 2b954601a0..85d815ad75 100644
> --- a/drivers/usb/musb-new/sunxi.c
> +++ b/drivers/usb/musb-new/sunxi.c
> @@ -81,8 +81,6 @@
> * From usbc/usbc.c
> ******************************************************************************/
>
> -#define OFF_SUN6I_AHB_RESET0 0x2c0
> -
> struct sunxi_musb_config {
> struct musb_hdrc_config *config;
> bool has_sram;
Please add missing commit message and send V2.
Otherwise
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: musb-new: sunxi: remove unused define
2023-06-08 4:51 ` Marek Vasut
@ 2023-06-08 18:45 ` Sam Edwards
0 siblings, 0 replies; 3+ messages in thread
From: Sam Edwards @ 2023-06-08 18:45 UTC (permalink / raw)
To: Marek Vasut, u-boot; +Cc: Andre Przywara, Jagan Teki
Hi Marek,
> Please add missing commit message and send V2.
Ah, apologies! I had (mistakenly) believed that the summary line would
be a sufficient commit message for something so trivial.
Instead I did a little research into how this got here and wrote a quick
explanation of why it's unused. I figure that would be a bit more
helpful for someone reading the commit history than just reiterating
that "It's, y'know, unused." :)
> Otherwise
>
> Reviewed-by: Marek Vasut <marex@denx.de>
Thank you for the speedy review!
Cheers,
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-08 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 23:16 [PATCH] usb: musb-new: sunxi: remove unused define Sam Edwards
2023-06-08 4:51 ` Marek Vasut
2023-06-08 18:45 ` Sam Edwards
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox