* [virtio-dev] [PATCH v2] content: reserve device ID for virtio-pmem devices
@ 2019-04-15 6:22 Pankaj Gupta
2019-04-15 8:00 ` [virtio-dev] " Cornelia Huck
2019-04-19 23:23 ` Michael S. Tsirkin
0 siblings, 2 replies; 5+ messages in thread
From: Pankaj Gupta @ 2019-04-15 6:22 UTC (permalink / raw)
To: virtio-dev; +Cc: mst, stefanha, cohuck
We need a device ID for virtio-pmem devices. As 25 is requested by
audio device and 26 is requested by virtio-fs, so requesting
next available(27). Also, updated the previously requested github
issue[1] for voting.
[1] https://github.com/oasis-tcs/virtio-spec/issues/38
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
v2:
Use device ID 27
content.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/content.tex b/content.tex
index 193b6e1..aef7476 100644
--- a/content.tex
+++ b/content.tex
@@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
\hline
24 & Memory device \\
\hline
+27 & PMEM device \\
+\hline
\end{tabular}
Some of the devices above are unspecified by this document,
--
2.14.5
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 5+ messages in thread* [virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices
2019-04-15 6:22 [virtio-dev] [PATCH v2] content: reserve device ID for virtio-pmem devices Pankaj Gupta
@ 2019-04-15 8:00 ` Cornelia Huck
2019-04-15 8:29 ` Pankaj Gupta
2019-04-19 23:23 ` Michael S. Tsirkin
1 sibling, 1 reply; 5+ messages in thread
From: Cornelia Huck @ 2019-04-15 8:00 UTC (permalink / raw)
To: Pankaj Gupta; +Cc: virtio-dev, mst, stefanha
On Mon, 15 Apr 2019 11:52:39 +0530
Pankaj Gupta <pagupta@redhat.com> wrote:
> We need a device ID for virtio-pmem devices. As 25 is requested by
> audio device and 26 is requested by virtio-fs, so requesting
> next available(27). Also, updated the previously requested github
> issue[1] for voting.
>
> [1] https://github.com/oasis-tcs/virtio-spec/issues/38
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> v2:
> Use device ID 27
>
> content.tex | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index 193b6e1..aef7476 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
> \hline
> 24 & Memory device \\
> \hline
> +27 & PMEM device \\
> +\hline
> \end{tabular}
>
> Some of the devices above are unspecified by this document,
Sigh, I hope we have found a good id now...
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices
2019-04-15 8:00 ` [virtio-dev] " Cornelia Huck
@ 2019-04-15 8:29 ` Pankaj Gupta
0 siblings, 0 replies; 5+ messages in thread
From: Pankaj Gupta @ 2019-04-15 8:29 UTC (permalink / raw)
To: Cornelia Huck; +Cc: virtio-dev, mst, stefanha
> > We need a device ID for virtio-pmem devices. As 25 is requested by
> > audio device and 26 is requested by virtio-fs, so requesting
> > next available(27). Also, updated the previously requested github
> > issue[1] for voting.
> >
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/38
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > ---
> > v2:
> > Use device ID 27
> >
> > content.tex | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index 193b6e1..aef7476 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
> > \hline
> > 24 & Memory device \\
> > \hline
> > +27 & PMEM device \\
> > +\hline
> > \end{tabular}
> >
> > Some of the devices above are unspecified by this document,
>
> Sigh, I hope we have found a good id now...
Hope so :)
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thank you for the review.
Best regards,
Pankaj
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices
2019-04-15 6:22 [virtio-dev] [PATCH v2] content: reserve device ID for virtio-pmem devices Pankaj Gupta
2019-04-15 8:00 ` [virtio-dev] " Cornelia Huck
@ 2019-04-19 23:23 ` Michael S. Tsirkin
2019-04-22 5:25 ` Pankaj Gupta
1 sibling, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2019-04-19 23:23 UTC (permalink / raw)
To: Pankaj Gupta; +Cc: virtio-dev, stefanha, cohuck
On Mon, Apr 15, 2019 at 11:52:39AM +0530, Pankaj Gupta wrote:
> We need a device ID for virtio-pmem devices. As 25 is requested by
> audio device and 26 is requested by virtio-fs, so requesting
> next available(27). Also, updated the previously requested github
> issue[1] for voting.
>
> [1] https://github.com/oasis-tcs/virtio-spec/issues/38
That's not the way to link it. You want:
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/38
Otherwise github will not recognize it.
Also for guthub pls edit the main issue with new link to patch do not add new patch as
a comment.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> v2:
> Use device ID 27
>
> content.tex | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index 193b6e1..aef7476 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
> \hline
> 24 & Memory device \\
> \hline
> +27 & PMEM device \\
> +\hline
> \end{tabular}
>
> Some of the devices above are unspecified by this document,
> --
> 2.14.5
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread* [virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices
2019-04-19 23:23 ` Michael S. Tsirkin
@ 2019-04-22 5:25 ` Pankaj Gupta
0 siblings, 0 replies; 5+ messages in thread
From: Pankaj Gupta @ 2019-04-22 5:25 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtio-dev, stefanha, cohuck
> On Mon, Apr 15, 2019 at 11:52:39AM +0530, Pankaj Gupta wrote:
> > We need a device ID for virtio-pmem devices. As 25 is requested by
> > audio device and 26 is requested by virtio-fs, so requesting
> > next available(27). Also, updated the previously requested github
> > issue[1] for voting.
> >
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/38
>
> That's not the way to link it. You want:
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/38
>
> Otherwise github will not recognize it.
> Also for guthub pls edit the main issue with new link to patch do not add new
> patch as
> a comment.
Sure. Submitted a new version v3 with suggested change.
Also, updated the github main issue with link to patch.
Thanks,
Pankaj
>
>
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
>
>
> > ---
> > v2:
> > Use device ID 27
> >
> > content.tex | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index 193b6e1..aef7476 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
> > \hline
> > 24 & Memory device \\
> > \hline
> > +27 & PMEM device \\
> > +\hline
> > \end{tabular}
> >
> > Some of the devices above are unspecified by this document,
> > --
> > 2.14.5
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-22 5:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 6:22 [virtio-dev] [PATCH v2] content: reserve device ID for virtio-pmem devices Pankaj Gupta
2019-04-15 8:00 ` [virtio-dev] " Cornelia Huck
2019-04-15 8:29 ` Pankaj Gupta
2019-04-19 23:23 ` Michael S. Tsirkin
2019-04-22 5:25 ` Pankaj Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox