Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <sgarzare@redhat.com>, <pasic@linux.ibm.com>,
	<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v12 09/10] virtio-net: Avoid duplicate receive queue example
Date: Wed, 5 Apr 2023 04:06:56 +0300	[thread overview]
Message-ID: <20230405010657.612529-10-parav@nvidia.com> (raw)
In-Reply-To: <20230405010657.612529-1-parav@nvidia.com>

Receive queue number/index example is duplicate which is already defined
in the Setting RSS parameters section.

Hence, avoid such duplicate example and prepare it for the subsequent
patch to describe using receive queue handle.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/net/description.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index d7c8b1b..435c1fc 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1467,8 +1467,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 The device MUST determine the destination queue for a network packet as follows:
 \begin{itemize}
 \item Calculate the hash of the packet as defined in \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets}.
-\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure (value of 0 corresponds to receiveq1).
-\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq (value of 0 corresponds to receiveq1).
+\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure.
+\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq.
 \item If the destination receive queue is being reset (See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device MUST drop the packet.
 \end{itemize}
 
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-04-05  1:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  1:06 [virtio-dev] [PATCH v12 00/10] Rename queue number to queue index Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 01/10] content: Add vq index text Parav Pandit
2023-04-05  5:26   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:00     ` [virtio-dev] " Parav Pandit
2023-04-05  9:18   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:03     ` [virtio-dev] " Parav Pandit
2023-04-07 11:30       ` Michael S. Tsirkin
2023-04-07 15:34         ` Parav Pandit
2023-04-07 15:54           ` Michael S. Tsirkin
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 02/10] content.tex Replace virtqueue number with index Parav Pandit
2023-04-05  9:46   ` [virtio-dev] " Cornelia Huck
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-05  5:22   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:20     ` [virtio-dev] " Parav Pandit
2023-04-10 13:25       ` [virtio-dev] " Michael S. Tsirkin
2023-04-05  5:30   ` Michael S. Tsirkin
2023-04-05  9:57     ` Cornelia Huck
2023-04-05 13:21     ` [virtio-dev] " Parav Pandit
2023-04-05 15:27       ` Halil Pasic
2023-04-05 15:58         ` Parav Pandit
2023-04-07 11:43           ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-11  8:56             ` Cornelia Huck
2023-04-11 13:35               ` [virtio-dev] " Parav Pandit
2023-04-17  3:18                 ` [virtio-dev] " Halil Pasic
2023-04-17  7:04                   ` Michael S. Tsirkin
2023-04-17  8:47                     ` [virtio-dev] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names) Cornelia Huck
2023-04-17 11:45                       ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 16:13                     ` [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Halil Pasic
2023-04-07 11:44       ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 04/10] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 05/10] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 06/10] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 07/10] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 08/10] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-05  1:06 ` Parav Pandit [this message]
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-05  9:17   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:02     ` [virtio-dev] " Parav Pandit
2023-04-07 11:32       ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-05  5:32 ` [virtio-dev] Re: [PATCH v12 00/10] Rename queue number to queue index Michael S. Tsirkin
2023-04-05 13:11   ` [virtio-dev] " Parav Pandit
2023-04-05  9:20 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:05   ` [virtio-dev] " Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405010657.612529-10-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox