From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id
Date: Fri, 7 Apr 2023 07:32:36 -0400 [thread overview]
Message-ID: <20230407073027-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481035B8C5D113CA76CB6D9DC909@PH0PR12MB5481.namprd12.prod.outlook.com>
On Wed, Apr 05, 2023 at 01:02:24PM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, April 5, 2023 5:18 AM
>
> > following format for \field{command-specific-data}:
> > > \begin{lstlisting}
> > > +struct rss_rq_id {
> > > + le16 vqn_1_16: 15; /* Bits 1 to 16 of the vq index */
> >
> > Do you want to then call this vq_index_1_16 ?
> Yes. will change.
>
> > And in the comment I would just write virtqueue index.
> >
> Why do you prefer longer to name here instead of abbreviation?
Eschew abbreviation is standard advice for writers.
Full names reduce the cognitive load - reader has less terms to
remember to be able to understand the spec.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-07 11:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 1:06 [virtio-dev] [PATCH v12 00/10] Rename queue number to queue index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 01/10] content: Add vq index text Parav Pandit
2023-04-05 5:26 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:00 ` [virtio-dev] " Parav Pandit
2023-04-05 9:18 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:03 ` [virtio-dev] " Parav Pandit
2023-04-07 11:30 ` Michael S. Tsirkin
2023-04-07 15:34 ` Parav Pandit
2023-04-07 15:54 ` Michael S. Tsirkin
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 02/10] content.tex Replace virtqueue number with index Parav Pandit
2023-04-05 9:46 ` [virtio-dev] " Cornelia Huck
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-05 5:22 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:20 ` [virtio-dev] " Parav Pandit
2023-04-10 13:25 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 5:30 ` Michael S. Tsirkin
2023-04-05 9:57 ` Cornelia Huck
2023-04-05 13:21 ` [virtio-dev] " Parav Pandit
2023-04-05 15:27 ` Halil Pasic
2023-04-05 15:58 ` Parav Pandit
2023-04-07 11:43 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-11 8:56 ` Cornelia Huck
2023-04-11 13:35 ` [virtio-dev] " Parav Pandit
2023-04-17 3:18 ` [virtio-dev] " Halil Pasic
2023-04-17 7:04 ` Michael S. Tsirkin
2023-04-17 8:47 ` [virtio-dev] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names) Cornelia Huck
2023-04-17 11:45 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 16:13 ` [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Halil Pasic
2023-04-07 11:44 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 04/10] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 05/10] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 06/10] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 07/10] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 08/10] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 09/10] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-05 1:06 ` [virtio-dev] [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-05 9:17 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:02 ` [virtio-dev] " Parav Pandit
2023-04-07 11:32 ` Michael S. Tsirkin [this message]
2023-04-05 5:32 ` [virtio-dev] Re: [PATCH v12 00/10] Rename queue number to queue index Michael S. Tsirkin
2023-04-05 13:11 ` [virtio-dev] " Parav Pandit
2023-04-05 9:20 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:05 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407073027-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox