Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <sgarzare@redhat.com>, <pasic@linux.ibm.com>,
	<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v12 04/10] transport-pci: Avoid first vq index reference
Date: Wed, 5 Apr 2023 04:06:51 +0300	[thread overview]
Message-ID: <20230405010657.612529-5-parav@nvidia.com> (raw)
In-Reply-To: <20230405010657.612529-1-parav@nvidia.com>

Drop reference to first virtqueue as it is already
covered now by the generic section in first patch.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v11->v12:
- drop changes related to vq number
v9->v10:
- updated commit log to drop reference to old patch
v8->v9:
- reword the sentence to avoid future tense, like rest of the other
  fields description
- reword the sentence to avoid multiple verbs use and put -> uses
- use shorter name 'vq number' instead of 'virtqueue number'
v7->v8:
- remove note about first virtqueue number
- skipped Max's comment to put word 'structure' in same line as its
  crosses 65 chars limit per line
- reworded queue_notification data set line, as '=' and vq number
  wording was odd
v2->v3:
- addressed comments from Michael
- changed vqn to virtqueue number in the Note
- refer to vqn field instead of virtqueue number
---
 transport-pci.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index 6bbf61c..1e6604d 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -1009,7 +1009,7 @@ \subsubsection{Device Initialization}\label{sec:Virtio Transport Options / Virti
 The driver typically does this as follows, for each virtqueue a device has:
 
 \begin{enumerate}
-\item Write the virtqueue index (first queue is 0) to \field{queue_select}.
+\item Write the virtqueue index to \field{queue_select}.
 
 \item Read the virtqueue size from \field{queue_size}. This controls how big the virtqueue is
   (see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues}). If this field is 0, the virtqueue does not exist.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-04-05  1:07 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  1:06 [virtio-dev] [PATCH v12 00/10] Rename queue number to queue index Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 01/10] content: Add vq index text Parav Pandit
2023-04-05  5:26   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:00     ` [virtio-dev] " Parav Pandit
2023-04-05  9:18   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:03     ` [virtio-dev] " Parav Pandit
2023-04-07 11:30       ` Michael S. Tsirkin
2023-04-07 15:34         ` Parav Pandit
2023-04-07 15:54           ` Michael S. Tsirkin
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 02/10] content.tex Replace virtqueue number with index Parav Pandit
2023-04-05  9:46   ` [virtio-dev] " Cornelia Huck
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-05  5:22   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:20     ` [virtio-dev] " Parav Pandit
2023-04-10 13:25       ` [virtio-dev] " Michael S. Tsirkin
2023-04-05  5:30   ` Michael S. Tsirkin
2023-04-05  9:57     ` Cornelia Huck
2023-04-05 13:21     ` [virtio-dev] " Parav Pandit
2023-04-05 15:27       ` Halil Pasic
2023-04-05 15:58         ` Parav Pandit
2023-04-07 11:43           ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-11  8:56             ` Cornelia Huck
2023-04-11 13:35               ` [virtio-dev] " Parav Pandit
2023-04-17  3:18                 ` [virtio-dev] " Halil Pasic
2023-04-17  7:04                   ` Michael S. Tsirkin
2023-04-17  8:47                     ` [virtio-dev] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names) Cornelia Huck
2023-04-17 11:45                       ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 16:13                     ` [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Halil Pasic
2023-04-07 11:44       ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-05  1:06 ` Parav Pandit [this message]
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 05/10] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 06/10] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 07/10] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 08/10] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 09/10] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-05  1:06 ` [virtio-dev] [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-05  9:17   ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:02     ` [virtio-dev] " Parav Pandit
2023-04-07 11:32       ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-05  5:32 ` [virtio-dev] Re: [PATCH v12 00/10] Rename queue number to queue index Michael S. Tsirkin
2023-04-05 13:11   ` [virtio-dev] " Parav Pandit
2023-04-05  9:20 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:05   ` [virtio-dev] " Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405010657.612529-5-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox