Re: [cocci] Searching for lock calls without unlocking (with SmPL)?

[Markus Elfring <Markus.Elfring@web.de>]

>>>>>> May I expect that only a single call should be marked for such a test case?
>>>>>
>>>>> No, I already explained why two calls are marked.
>>>>
>>>> I see further challenges with this explanation approach.
>>>>
>>>>
>>>>> The shortest path constraint is that for A ... B, the ... doesn't contain
>>>>> A or B.
>>>>
>>>> This is generally fine.
>>
>> How does the “shortest path” fit to the statement “action_lock(&blockage2);”
>> from the if branch in your software view?
> 
> I explained it already.  If you have A ... B, Coccinelle doe not allow A
> or B to occur in the code matched by ...

How does the second lock call fit to these criteria?


> A problem that you see to insist on causing is that by using * you have
> no idea which matches involve which pieces of code.

Partly, yes.

The source code search patterns can occasionally be constructed with more
unique context data.
I hope still that undesirable data processing confusion can be reduced further.


>                                                      If you would print
> the line numbers of the involved calls then things would be clear.

I hope still that a better consensus can be achieved also for safer applications
of the SmPL asterisk functionality.


>> Can the path distance be determined anyhow?

I would appreciate a more helpful answer here.


…>>> independent.  There is no guarantee that one match will not cross another
>>> one.  Furthermore, (just in case this is the concern) when you mentin two
>>> different metavariables, there is no guarantee that they are not bound to
>>> the same term.
…>> Will it become more desirable to distinguish metavariable contents in an
>> unique way?
> 
> If you want something you have to express it in Coccinelle.
> 
> foo(A)
> ...
> (
> foo(A)
> |
> *foo(B)
> )
> 
> ensures that the marked foo(B) involves a different argument than the
> matched foo(A).

Would you like to provide a “guarantee” here?

Regards,
Markus