All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: Erick Karanja <karanja99erick@gmail.com>
Subject: Re: [cocci] Searching for lock calls without unlocking (with SmPL)?
Date: Sat, 2 Aug 2025 18:18:37 +0200	[thread overview]
Message-ID: <51664351-746c-4d7a-ae45-2a610ba45176@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2508021803360.3428@hadrien>

>>>      The one in the if is matching with the call closest to it,
>>
>> I interpret this hit as a false positive.
>> (The first lock call in the if branch is not the relevant companion call
>> from the function implementation.)
>>
>>
>>>                                                                 not the
>>> call at the beginning of the function.
>>
>> This is an essential requirement for the discussed source code search pattern,
>> isn't it?
> 
> No.

I hope still that a better common understanding can be achieved.


>      I don't understand why you think that.

The source code search pattern tries to find a pair of lock calls.
Is the passed expression determined for the metavariable “y” after the second
lock call was found at the beginning of the function implementation?

May these two calls be kept close together also in the desired search result?

Regards,
Markus

  reply	other threads:[~2025-08-02 16:18 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23  7:45 [cocci] Searching for questionable call pairs (with SmPL)? Markus Elfring
2025-07-24 14:15 ` Markus Elfring
2025-07-24 14:47 ` Julia Lawall
2025-07-24 15:02   ` Markus Elfring
2025-07-24 15:09     ` Julia Lawall
2025-07-24 15:15       ` Markus Elfring
2025-07-24 15:25         ` Julia Lawall
2025-07-24 15:30           ` Markus Elfring
2025-07-24 16:18       ` Markus Elfring
2025-07-30 12:10       ` Markus Elfring
2025-08-01  7:33         ` Markus Elfring
2025-08-01  8:06           ` Julia Lawall
2025-08-01  8:33             ` Markus Elfring
2025-08-02 10:13             ` [cocci] Searching for lock calls without unlocking " Markus Elfring
2025-08-02 11:18               ` Markus Elfring
2025-08-02 11:28                 ` Julia Lawall
2025-08-02 11:51                   ` Markus Elfring
2025-08-02 11:54                     ` Julia Lawall
2025-08-02 12:02                       ` Markus Elfring
2025-08-02 12:10                         ` Julia Lawall
2025-08-02 12:56                           ` Markus Elfring
2025-08-02 13:05                             ` Julia Lawall
2025-08-02 13:33                               ` Markus Elfring
2025-08-02 13:45                                 ` Julia Lawall
2025-08-02 14:06                                   ` Markus Elfring
2025-08-02 15:43                               ` Markus Elfring
2025-08-02 15:46                                 ` Julia Lawall
2025-08-02 16:01                                   ` Markus Elfring
2025-08-02 16:04                                     ` Julia Lawall
2025-08-02 16:18                                       ` Markus Elfring [this message]
2025-08-02 16:24                                         ` Julia Lawall
2025-08-02 16:35                                           ` Markus Elfring
2025-08-02 17:38                                             ` Julia Lawall
2025-08-02 18:11                                               ` Markus Elfring
2025-08-02 19:12                                                 ` Julia Lawall
2025-08-02 19:26                                                   ` Markus Elfring
2025-08-02 19:35                                                     ` Julia Lawall
2025-08-02 19:42                                                       ` Markus Elfring
2025-08-02 19:44                                                         ` Julia Lawall
2025-08-02 19:48                                                           ` [cocci] Evolution of software documentation? Markus Elfring
2025-08-03  5:24                                                   ` [cocci] Searching for lock calls without unlocking (with SmPL)? Markus Elfring
2025-08-03  5:34                                                     ` Julia Lawall
2025-08-03  5:55                                                       ` Markus Elfring
2025-08-03  7:55                                                       ` Markus Elfring
2025-08-04 10:55             ` [cocci] Searching for questionable call pairs " Markus Elfring
2025-08-04 11:25               ` [cocci] Searching for lock calls without unlocking " Markus Elfring
2025-08-06  9:30               ` [cocci] Searching for repeated actions " Markus Elfring
2025-07-24 18:37 ` [cocci] Searching for questionable call pairs " Markus Elfring
2025-07-25  7:06 ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51664351-746c-4d7a-ae45-2a610ba45176@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=karanja99erick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.