Re: [cocci] Searching for questionable call pairs (with SmPL)?

[Markus Elfring <Markus.Elfring@web.de>]

> Will another clarification become more interesting?

Another source code search approach can eventually help to provide further
insights into presented software development concerns.


// handle_uaudio_stream_req()
// https://elixir.bootlin.com/linux/v6.16-rc7/source/sound/usb/qcom/qc_audio_offload.c#L1508
@display@
expression x, y;
@@
 if (!svc->client_connected)
 {
    ...
 }

*mutex_lock(x);
 ...
*mutex_lock(y);
 <+...
*mutex_unlock(x);
 ...
*mutex_unlock(y);
 ...+>


Another test result (by the software combination “Coccinelle 1.3.0” for example):
Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> time /usr/bin/spatch --no-loops ../janitor/show_questionable_unlock_call_order5.cocci qc_audio_offload-handle_uaudio_stream_req-excerpt-20250722.c
[no diff output]
…
real    0m0,103s
user    0m0,085s
sys     0m0,018s



Does the specification of additional context from the beginning of the discussed
function implementation influence the exclusion of a false positive?

Regards,
Markus