Re: [cocci] Searching for questionable call pairs (with SmPL)?

[Markus Elfring <Markus.Elfring@web.de>]

>> @display@
>> expression x, y;
>> @@
>> *mutex_lock(x);
>>  ...
>> *mutex_lock(y);
>>  <+...
>> *mutex_unlock(x);
>>  ...
>> *mutex_unlock(y);
>>  ...+>
> * just highlights lines when there is a match.  Theer can be several
> possible matches.

This is actually the case for a known source file.
https://elixir.bootlin.com/linux/v6.16-rc7/source/sound/usb/qcom/qc_audio_offload.c


>                    In that case, the union of the relevant lines will be highlighted.

I am still looking for further possibilities to avoid false positives.

* The source code search pattern can be simplified a bit
  by omitting two SmPL ellipses.
  (But the search approach should be more advanced, shouldn't it?)

* Why is the diff marking missing for the first lock call so far
  (within the implementation of the function “handle_uaudio_stream_req”)?


I would appreciate further advices.

Regards,
Markus