RE: [PATCH v2 2/6] hw/arm/virt-acpi-build: Update IORT for multiple smmuv3 devices

[Shameerali Kolothum Thodi via <qemu-devel@nongnu.org>]

> -----Original Message-----
> From: Donald Dutile <ddutile@redhat.com>
> Sent: Friday, May 2, 2025 7:18 PM
> To: Nicolin Chen <nicolinc@nvidia.com>; Shameerali Kolothum Thodi
> <shameerali.kolothum.thodi@huawei.com>
> Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org;
> eric.auger@redhat.com; peter.maydell@linaro.org; jgg@nvidia.com;
> berrange@redhat.com; nathanc@nvidia.com; mochs@nvidia.com;
> smostafa@google.com; Linuxarm <linuxarm@huawei.com>; Wangzhou (B)
> <wangzhou1@hisilicon.com>; jiangkunkun <jiangkunkun@huawei.com>;
> Jonathan Cameron <jonathan.cameron@huawei.com>;
> zhangfei.gao@linaro.org
> Subject: Re: [PATCH v2 2/6] hw/arm/virt-acpi-build: Update IORT for
> multiple smmuv3 devices
> 
> 
> 
> On 5/2/25 1:13 PM, Nicolin Chen wrote:
> > On Fri, May 02, 2025 at 11:27:03AM +0100, Shameer Kolothum wrote:
> >> @@ -43,6 +43,7 @@
> >>   #include "hw/acpi/generic_event_device.h"
> >>   #include "hw/acpi/tpm.h"
> >>   #include "hw/acpi/hmat.h"
> >> +#include "hw/arm/smmuv3.h"
> >>   #include "hw/pci/pcie_host.h"
> >>   #include "hw/pci/pci.h"
> >>   #include "hw/pci/pci_bus.h"
> >> @@ -266,6 +267,75 @@ static int iort_idmap_compare(gconstpointer a,
> gconstpointer b)
> >>       return idmap_a->input_base - idmap_b->input_base;
> >>   }
> >>
> >> +struct SMMUv3Device {
> >> +    int irq;
> >> +    hwaddr base;
> >> +    GArray *smmu_idmaps;
> >> +    size_t offset;
> >> +};
> >> +typedef struct SMMUv3Device SMMUv3Device;
> >
> > "SMMUv3Device" sounds too general, like coming from smmuv3.h :-/
> >
> > Given this describes SMMUv3's IORT node, I still think we should name
> > it something like "IortSMMUv3Node" or so.
> >
> +1.. the more generic name had me thinking it was broader than IORT..
> the IORT-related naming is an improvement.

I thought it is obvious as I already replied to Nicolin 😊. I will consider this.

Thanks,
Shameer