Re: [PATCH v2 5/6] hw/arm/virt: Add support for smmuv3 device

[Nicolin Chen <nicolinc@nvidia.com>]

On Fri, May 02, 2025 at 11:27:06AM +0100, Shameer Kolothum wrote:
> @@ -2972,6 +3004,21 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev,
>          virtio_md_pci_plug(VIRTIO_MD_PCI(dev), MACHINE(hotplug_dev), errp);
>      }
>  
> +    if (object_dynamic_cast(OBJECT(dev), TYPE_ARM_SMMUV3)) {

This seems to be on the path of a hotplug function? Mind elaborating
why, while PATCH-1 sets hotpluggable to false?

> +        if (!vms->legacy_smmuv3_present && vms->platform_bus_dev) {
> +            VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
> +
> +            create_smmuv3_dev_dtb(vms, dev);
> +            if (vms->iommu != VIRT_IOMMU_SMMUV3) {

Should this be VIRT_IOMMU_NONE only as the other cases are rejected?

> +                vms->iommu = VIRT_IOMMU_SMMUV3;

Thanks
nicolin