From: "Eric W. Biederman" <ebiederm@xmission.com>
To: "<Andrew Morton" <akpm@osdl.org>
Cc: <containers@lists.osdl.org>, Oleg Nesterov <oleg@tv-sign.ru>,
Christoph Hellwig <hch@infradead.org>,
<linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH] ia64 sn xpc: Convert to use kthread API.
Date: Thu, 19 Apr 2007 00:55:39 -0600 [thread overview]
Message-ID: <11769657833898-git-send-email-ebiederm@xmission.com> (raw)
In-Reply-To: <m1slawn9eb.fsf@ebiederm.dsl.xmission.com>
From: Eric W. Biederman <ebiederm@xmission.com> - unquoted
This patch starts the xpc kernel threads using kthread_run
not a combination of kernel_thread and daemonize. Resuling
in slightly simpler and more maintainable code.
Cc: Jes Sorensen <jes@sgi.com>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
arch/ia64/sn/kernel/xpc_main.c | 31 +++++++++++++------------------
1 files changed, 13 insertions(+), 18 deletions(-)
diff --git a/arch/ia64/sn/kernel/xpc_main.c b/arch/ia64/sn/kernel/xpc_main.c
index e336e16..5b53642 100644
--- a/arch/ia64/sn/kernel/xpc_main.c
+++ b/arch/ia64/sn/kernel/xpc_main.c
@@ -56,6 +56,7 @@
#include <linux/reboot.h>
#include <linux/completion.h>
#include <linux/kdebug.h>
+#include <linux/kthread.h>
#include <asm/sn/intr.h>
#include <asm/sn/sn_sal.h>
#include <asm/uaccess.h>
@@ -253,8 +254,6 @@ xpc_hb_checker(void *ignore)
/* this thread was marked active by xpc_hb_init() */
- daemonize(XPC_HB_CHECK_THREAD_NAME);
-
set_cpus_allowed(current, cpumask_of_cpu(XPC_HB_CHECK_CPU));
xpc_hb_check_timeout = jiffies + (xpc_hb_check_interval * HZ);
@@ -324,8 +323,6 @@ xpc_hb_checker(void *ignore)
static int
xpc_initiate_discovery(void *ignore)
{
- daemonize(XPC_DISCOVERY_THREAD_NAME);
-
xpc_discovery();
dev_dbg(xpc_part, "discovery thread is exiting\n");
@@ -494,8 +491,6 @@ xpc_activating(void *__partid)
dev_dbg(xpc_part, "bringing partition %d up\n", partid);
- daemonize("xpc%02d", partid);
-
/*
* This thread needs to run at a realtime priority to prevent a
* significant performance degradation.
@@ -559,7 +554,7 @@ xpc_activate_partition(struct xpc_partition *part)
{
partid_t partid = XPC_PARTID(part);
unsigned long irq_flags;
- pid_t pid;
+ struct task_struct *task;
spin_lock_irqsave(&part->act_lock, irq_flags);
@@ -571,9 +566,10 @@ xpc_activate_partition(struct xpc_partition *part)
spin_unlock_irqrestore(&part->act_lock, irq_flags);
- pid = kernel_thread(xpc_activating, (void *) ((u64) partid), 0);
+ task = kthread_run(xpc_activating, (void *) ((u64) partid),
+ "xpc%02d", partid);
- if (unlikely(pid <= 0)) {
+ if (unlikely(IS_ERR(task))) {
spin_lock_irqsave(&part->act_lock, irq_flags);
part->act_state = XPC_P_INACTIVE;
XPC_SET_REASON(part, xpcCloneKThreadFailed, __LINE__);
@@ -724,8 +720,6 @@ xpc_daemonize_kthread(void *args)
unsigned long irq_flags;
- daemonize("xpc%02dc%d", partid, ch_number);
-
dev_dbg(xpc_chan, "kthread starting, partid=%d, channel=%d\n",
partid, ch_number);
@@ -844,8 +838,9 @@ xpc_create_kthreads(struct xpc_channel *ch, int needed,
(void) xpc_part_ref(part);
xpc_msgqueue_ref(ch);
- pid = kernel_thread(xpc_daemonize_kthread, (void *) args, 0);
- if (pid < 0) {
+ task = kthread_run(xpc_daemonize_kthread, args,
+ "xpc%02dc%d", partid, ch_number);
+ if (IS_ERR(task)) {
/* the fork failed */
/*
@@ -1222,7 +1217,7 @@ xpc_init(void)
int ret;
partid_t partid;
struct xpc_partition *part;
- pid_t pid;
+ struct task_struct *task;
size_t buf_size;
@@ -1353,8 +1348,8 @@ xpc_init(void)
* The real work-horse behind xpc. This processes incoming
* interrupts and monitors remote heartbeats.
*/
- pid = kernel_thread(xpc_hb_checker, NULL, 0);
- if (pid < 0) {
+ task = kthread_run(xpc_hb_checker, NULL, XPC_HB_CHECK_THREAD_NAME);
+ if (IS_ERR(task)) {
dev_err(xpc_part, "failed while forking hb check thread\n");
/* indicate to others that our reserved page is uninitialized */
@@ -1384,8 +1379,8 @@ xpc_init(void)
* activate based on info provided by SAL. This new thread is short
* lived and will exit once discovery is complete.
*/
- pid = kernel_thread(xpc_initiate_discovery, NULL, 0);
- if (pid < 0) {
+ task = kthread_run(xpc_initiate_discovery, NULL, XPC_DISCOVERY_THREAD_NAME);
+ if (IS_ERR(task)) {
dev_err(xpc_part, "failed while forking discovery thread\n");
/* mark this new thread as a non-starter */
--
1.5.0.g53756
next prev parent reply other threads:[~2007-04-19 7:05 UTC|newest]
Thread overview: 237+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 6:52 Remaining straight forward kthread API conversions Eric W. Biederman
2007-04-19 6:55 ` [PATCH] i386 balance_irq: Convert to the kthread api Eric W. Biederman
2007-04-19 6:55 ` [PATCH] i386 voyager: Convert the monitor thread to use the kthread API Eric W. Biederman
2007-04-22 19:30 ` Christoph Hellwig
2007-04-19 6:55 ` [PATCH] mtd_blkdevs: Convert " Eric W. Biederman
2007-04-19 16:47 ` Christoph Hellwig
2007-04-19 19:13 ` Eric W. Biederman
2007-04-19 22:26 ` Andrew Morton
2007-04-22 12:24 ` Christoph Hellwig
2007-04-22 13:23 ` David Woodhouse
2007-04-22 19:26 ` Christoph Hellwig
2007-04-22 19:40 ` Christoph Hellwig
2007-04-19 6:55 ` [PATCH] cpci_hotplug: " Eric W. Biederman
2007-04-22 12:05 ` Christoph Hellwig
2007-04-23 16:19 ` Scott Murray
2007-04-27 22:07 ` Scott Murray
2007-05-04 11:12 ` Christoph Hellwig
2007-05-07 18:18 ` Scott Murray
2007-05-09 23:24 ` Andrew Morton
2007-05-10 0:00 ` Kristen Carlson Accardi
2007-05-10 18:29 ` Scott Murray
2007-05-10 19:30 ` Andrew Morton
2007-04-19 6:55 ` [PATCH] ibmphp: Convert to use the kthreads API Eric W. Biederman
2007-04-22 12:09 ` Christoph Hellwig
2007-04-19 6:55 ` [PATCH] cpqphp: Convert to use the kthread API Eric W. Biederman
2007-04-22 12:12 ` Christoph Hellwig
2007-04-19 6:55 ` [PATCH] pnpbios: Conert " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] sas_scsi_host: Convert " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] sparc64/power.c: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] s390/net/lcs: Convert to " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] s390 qeth: Convert to use " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] s390/scsi/zfcp_erp: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] arm ecard: Conver " Eric W. Biederman
2007-04-19 6:55 ` Eric W. Biederman [this message]
2007-04-19 6:55 ` [PATCH] powerpc pseries eeh: Convert to " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] powerpc pseries rtasd: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] macintosh/therm_pm72.c: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] macintosh/therm_windtunnel.c: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] macintosh/adb: Convert to the " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] macintosh/mediabay: Convert to " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] bluetooth bnep: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] bluetooth cmtp: Convert to use " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] bluetooth hidp: Convert to " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] bluetooth rfcomm: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] fs/afs: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] net/rxrpc: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] ipv4/ipvs: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] saa7134-tvaudio: " Eric W. Biederman
2007-04-20 12:48 ` Cedric Le Goater
2007-04-20 13:05 ` Christoph Hellwig
2007-04-19 6:55 ` [PATCH] nfs lockd reclaimer: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] nfsv4 delegation: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] nfsd/nfs4state: Remove unnecessary daemonize call Eric W. Biederman
2007-04-19 6:55 ` [PATCH] nfs4state reclaimer: Remove unnecessary allow_signal Eric W. Biederman
2007-04-19 6:55 ` [PATCH] smbfs: " Eric W. Biederman
2007-04-19 6:55 ` [PATCH] dvb_en_50221: Convert to kthread API Eric W. Biederman
2007-04-19 6:56 ` [PATCH] md: Remove broken SIGKILL support Eric W. Biederman
2007-04-19 6:56 ` [PATCH] synchro_test: Convert to the kthread API Eric W. Biederman
2007-04-19 6:56 ` Eric W. Biederman
2007-04-19 7:58 ` [PATCH] i386 balance_irq: Convert to the kthread api Eric W. Biederman
2007-04-19 7:58 ` [PATCH] i386 voyager: Convert the monitor thread to use the kthread API Eric W. Biederman
2007-04-19 7:58 ` [PATCH] mtd_blkdevs: Convert " Eric W. Biederman
2007-04-19 7:58 ` [PATCH] cpci_hotplug: " Eric W. Biederman
2007-04-19 7:58 ` [PATCH] ibmphp: Convert to use the kthreads API Eric W. Biederman
2007-04-19 7:58 ` [PATCH] cpqphp: Convert to use the kthread API Eric W. Biederman
2007-04-20 1:54 ` Andrew Morton
2007-04-19 7:58 ` [PATCH] pnpbios: Conert " Eric W. Biederman
2007-04-19 7:58 ` [PATCH] sas_scsi_host: Convert " Eric W. Biederman
2007-04-20 0:37 ` Andrew Morton
2007-04-22 19:38 ` Christoph Hellwig
2007-04-22 21:37 ` James Bottomley
2007-04-22 21:48 ` Eric W. Biederman
2007-04-19 7:58 ` [PATCH] sparc64/power.c: " Eric W. Biederman
2007-04-20 0:30 ` Andrew Morton
2007-04-19 7:58 ` [PATCH] s390/net/lcs: Convert to " Eric W. Biederman
2007-04-19 8:19 ` Frank Pavlic
2007-04-19 7:58 ` [PATCH] s390 qeth: Convert to use " Eric W. Biederman
2007-04-19 7:58 ` [PATCH] s390/scsi/zfcp_erp: " Eric W. Biederman
2007-04-22 20:17 ` Christoph Hellwig
2007-04-30 10:41 ` Swen Schillig
2007-04-19 7:58 ` [PATCH] arm ecard: Conver " Eric W. Biederman
2007-04-22 20:18 ` Christoph Hellwig
2007-04-19 7:58 ` [PATCH] ia64 sn xpc: Convert to use " Eric W. Biederman
2007-04-19 23:51 ` Andrew Morton
2007-04-20 6:23 ` Jes Sorensen
2007-04-20 14:21 ` Robin Holt
2007-04-21 19:53 ` Eric W. Biederman
2007-04-22 20:36 ` Christoph Hellwig
2007-04-23 17:11 ` Jes Sorensen
2007-04-23 17:11 ` Jes Sorensen
2007-04-23 17:36 ` Eric W. Biederman
2007-04-23 17:36 ` Eric W. Biederman
2007-04-23 19:03 ` Russ Anderson
2007-04-23 19:03 ` Russ Anderson
2007-04-27 17:41 ` Dean Nelson
2007-04-27 18:34 ` Eric W. Biederman
2007-04-27 20:12 ` Dean Nelson
2007-04-27 20:33 ` Eric W. Biederman
2007-04-30 15:22 ` Dean Nelson
2007-05-02 15:16 ` Dean Nelson
2007-05-02 15:44 ` Eric W. Biederman
2007-05-17 13:44 ` Dean Nelson
2007-04-26 20:00 ` Dean Nelson
2007-04-19 7:58 ` [PATCH] powerpc pseries eeh: Convert to " Eric W. Biederman
2007-04-19 23:47 ` Andrew Morton
2007-04-22 12:31 ` Christoph Hellwig
2007-04-22 12:31 ` Christoph Hellwig
2007-04-23 20:50 ` Linas Vepstas
2007-04-24 1:38 ` Benjamin Herrenschmidt
2007-04-24 1:38 ` Benjamin Herrenschmidt
2007-04-24 2:08 ` Eric W. Biederman
2007-04-24 2:08 ` Eric W. Biederman
2007-04-24 2:42 ` Benjamin Herrenschmidt
2007-04-24 2:42 ` Benjamin Herrenschmidt
2007-04-24 3:20 ` Eric W. Biederman
2007-04-24 3:20 ` Eric W. Biederman
2007-04-24 4:34 ` Paul Mackerras
2007-04-24 4:34 ` Paul Mackerras
2007-04-24 4:34 ` Paul Mackerras
2007-04-24 4:51 ` Eric W. Biederman
2007-04-24 4:51 ` Eric W. Biederman
2007-04-24 5:00 ` Benjamin Herrenschmidt
2007-04-24 5:00 ` Benjamin Herrenschmidt
2007-04-24 5:43 ` Eric W. Biederman
2007-04-24 5:43 ` Eric W. Biederman
2007-04-24 5:58 ` Benjamin Herrenschmidt
2007-04-24 5:58 ` Benjamin Herrenschmidt
2007-04-24 6:17 ` SOME STUFF ABOUT REISER4 lkml777
2007-04-24 6:17 ` lkml777
2007-04-24 17:26 ` Eric M. Hopper
2007-04-24 7:46 ` [PATCH] powerpc pseries eeh: Convert to kthread API Cornelia Huck
2007-04-24 7:46 ` Cornelia Huck
2007-04-24 17:24 ` Linas Vepstas
2007-04-24 17:24 ` Linas Vepstas
2007-04-24 5:55 ` Paul Mackerras
2007-04-24 5:55 ` Paul Mackerras
2007-04-24 8:37 ` Christoph Hellwig
2007-04-24 8:37 ` Christoph Hellwig
2007-04-24 17:35 ` Linas Vepstas
2007-04-19 7:58 ` [PATCH] powerpc pseries rtasd: " Eric W. Biederman
2007-04-22 12:34 ` Christoph Hellwig
2007-04-19 7:58 ` [PATCH] macintosh/therm_pm72.c: " Eric W. Biederman
2007-04-22 19:16 ` Christoph Hellwig
2007-04-22 22:46 ` Paul Mackerras
2007-04-19 7:58 ` [PATCH] macintosh/therm_windtunnel.c: " Eric W. Biederman
2007-04-19 23:37 ` Andrew Morton
2007-04-20 8:53 ` Benjamin Herrenschmidt
2007-04-19 7:58 ` [PATCH] macintosh/adb: Convert to the " Eric W. Biederman
2007-04-19 7:58 ` [PATCH] macintosh/mediabay: Convert to " Eric W. Biederman
2007-04-19 23:30 ` Andrew Morton
2007-04-20 8:51 ` Benjamin Herrenschmidt
2007-04-19 7:58 ` [PATCH] bluetooth bnep: " Eric W. Biederman
2007-04-19 23:24 ` Andrew Morton
2007-04-20 10:20 ` [Devel] " Cedric Le Goater
2007-04-20 12:37 ` Cedric Le Goater
2007-04-21 16:11 ` Satyam Sharma
2007-04-22 19:44 ` Christoph Hellwig
2007-04-23 3:12 ` [PATCH] kthread: Spontaneous exit support Eric W. Biederman
2007-04-23 11:25 ` Christoph Hellwig
2007-04-23 16:58 ` Oleg Nesterov
2007-04-23 17:45 ` Eric W. Biederman
2007-04-23 18:09 ` Christoph Hellwig
2007-04-23 18:20 ` Oleg Nesterov
2007-04-24 13:08 ` Jan Engelhardt
2007-04-24 13:34 ` Christoph Hellwig
2007-04-19 7:58 ` [PATCH] bluetooth cmtp: Convert to use kthread API Eric W. Biederman
2007-04-19 7:58 ` [PATCH] bluetooth hidp: Convert to " Eric W. Biederman
2007-04-19 23:20 ` Andrew Morton
2007-04-19 7:58 ` [PATCH] bluetooth rfcomm: " Eric W. Biederman
2007-04-19 23:12 ` Andrew Morton
2007-04-20 15:20 ` [Devel] " Cedric Le Goater
2007-04-22 20:14 ` Christoph Hellwig
2007-04-19 7:58 ` [PATCH] fs/afs: " Eric W. Biederman
2007-04-19 9:32 ` David Howells
2007-04-19 7:58 ` [PATCH] net/rxrpc: " Eric W. Biederman
2007-04-19 9:32 ` David Howells
2007-04-19 13:05 ` Eric W. Biederman
2007-04-19 14:18 ` Getting the new RxRPC patches upstream David Howells
2007-04-19 15:50 ` Eric W. Biederman
2007-04-19 16:18 ` David Howells
2007-04-19 19:14 ` Eric W. Biederman
2007-04-19 20:14 ` David Miller
2007-04-20 1:15 ` Herbert Xu
2007-04-20 8:02 ` David Howells
2007-04-20 8:58 ` David Miller
2007-04-20 10:41 ` David Howells
2007-04-20 18:38 ` Andrew Morton
2007-04-20 21:28 ` Oleg Nesterov
2007-04-23 8:32 ` David Howells
2007-04-23 17:11 ` Oleg Nesterov
2007-04-24 13:37 ` David Howells
2007-04-24 14:22 ` Oleg Nesterov
2007-04-24 15:51 ` David Howells
2007-04-24 16:40 ` Oleg Nesterov
2007-04-24 16:58 ` David Howells
2007-04-24 17:33 ` Oleg Nesterov
2007-04-24 18:22 ` David Howells
2007-04-24 19:34 ` Oleg Nesterov
2007-04-25 8:10 ` David Howells
2007-04-25 10:41 ` Oleg Nesterov
2007-04-25 10:45 ` David Howells
2007-04-25 13:48 ` David Howells
2007-04-19 23:05 ` [PATCH] net/rxrpc: Convert to kthread API Andrew Morton
2007-04-20 7:47 ` David Howells
2007-04-19 7:58 ` [PATCH] ipv4/ipvs: " Eric W. Biederman
2007-04-19 9:04 ` Simon Horman
2007-04-19 22:59 ` Andrew Morton
2007-04-22 19:50 ` Christoph Hellwig
2007-04-19 7:58 ` [PATCH] saa7134-tvaudio: " Eric W. Biederman
2007-04-19 22:52 ` Andrew Morton
2007-04-19 7:58 ` [PATCH] nfs lockd reclaimer: " Eric W. Biederman
2007-04-19 16:21 ` Trond Myklebust
2007-04-19 19:20 ` Eric W. Biederman
2007-04-19 21:19 ` Trond Myklebust
2007-04-19 21:25 ` Dave Hansen
2007-04-21 19:04 ` Eric W. Biederman
2007-04-19 21:40 ` Andrew Morton
2007-04-19 22:04 ` Trond Myklebust
2007-04-21 19:47 ` Eric W. Biederman
2007-04-19 7:59 ` [PATCH] nfsv4 delegation: " Eric W. Biederman
2007-04-19 16:22 ` Trond Myklebust
2007-04-19 7:59 ` [PATCH] nfsd/nfs4state: Remove unnecessary daemonize call Eric W. Biederman
2007-04-19 7:59 ` [PATCH] nfs4state reclaimer: Remove unnecessary allow_signal Eric W. Biederman
2007-04-19 16:26 ` Trond Myklebust
2007-04-19 7:59 ` [PATCH] smbfs: " Eric W. Biederman
2007-04-19 22:47 ` Andrew Morton
2007-04-19 7:59 ` [PATCH] dvb_en_50221: Convert to kthread API Eric W. Biederman
2007-04-19 22:34 ` Andrew Morton
2007-04-20 6:37 ` Christoph Hellwig
2007-04-20 6:48 ` Andrew Morton
2007-04-20 9:37 ` Cedric Le Goater
2007-04-19 7:59 ` [PATCH] md: Remove broken SIGKILL support Eric W. Biederman
2007-05-01 0:47 ` Neil Brown
2007-05-01 6:13 ` Eric W. Biederman
2007-04-19 7:59 ` [PATCH] synchro_test: Convert to the kthread API Eric W. Biederman
2007-04-19 7:59 ` Eric W. Biederman
2007-04-22 12:15 ` Remaining straight forward kthread API conversions Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11769657833898-git-send-email-ebiederm@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=containers@lists.osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.