* [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... @ 2007-09-27 13:57 Thiemo Seufer 2007-09-27 14:08 ` Jocelyn Mayer 0 siblings, 1 reply; 6+ messages in thread From: Thiemo Seufer @ 2007-09-27 13:57 UTC (permalink / raw) To: qemu-devel CVSROOT: /sources/qemu Module name: qemu Changes by: Thiemo Seufer <ths> 07/09/27 13:57:58 Modified files: linux-user : qemu.h signal.c syscall.c target-alpha : cpu.h target-arm : cpu.h target-i386 : cpu.h target-mips : cpu.h target-ppc : cpu.h target-sparc : cpu.h Added files: linux-user/alpha: target_signal.h linux-user/arm : target_signal.h linux-user/i386: target_signal.h linux-user/m68k: target_signal.h linux-user/mips: target_signal.h linux-user/ppc : target_signal.h linux-user/ppc64: target_signal.h linux-user/sh4 : target_signal.h linux-user/sparc: target_signal.h linux-user/sparc64: target_signal.h linux-user/x86_64: target_signal.h Log message: linux-user sigaltstack() syscall, by Thayne Harbaugh. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/qemu.h?cvsroot=qemu&r1=1.35&r2=1.36 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/signal.c?cvsroot=qemu&r1=1.42&r2=1.43 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/syscall.c?cvsroot=qemu&r1=1.135&r2=1.136 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/alpha/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/arm/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/i386/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/m68k/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/mips/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/ppc/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/ppc64/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/sh4/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/sparc/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/sparc64/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/x86_64/target_signal.h?cvsroot=qemu&rev=1.1 http://cvs.savannah.gnu.org/viewcvs/qemu/target-alpha/cpu.h?cvsroot=qemu&r1=1.6&r2=1.7 http://cvs.savannah.gnu.org/viewcvs/qemu/target-arm/cpu.h?cvsroot=qemu&r1=1.32&r2=1.33 http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/cpu.h?cvsroot=qemu&r1=1.48&r2=1.49 http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/cpu.h?cvsroot=qemu&r1=1.45&r2=1.46 http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/cpu.h?cvsroot=qemu&r1=1.58&r2=1.59 http://cvs.savannah.gnu.org/viewcvs/qemu/target-sparc/cpu.h?cvsroot=qemu&r1=1.50&r2=1.51 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... 2007-09-27 13:57 [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu Thiemo Seufer @ 2007-09-27 14:08 ` Jocelyn Mayer 2007-09-27 15:26 ` Thiemo Seufer 2007-09-27 15:53 ` Thayne Harbaugh 0 siblings, 2 replies; 6+ messages in thread From: Jocelyn Mayer @ 2007-09-27 14:08 UTC (permalink / raw) To: qemu-devel On Thu, 2007-09-27 at 13:57 +0000, Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer <ths> 07/09/27 13:57:58 > > Modified files: > linux-user : qemu.h signal.c syscall.c > target-alpha : cpu.h > target-arm : cpu.h > target-i386 : cpu.h > target-mips : cpu.h > target-ppc : cpu.h static inline target_ulong get_sp_from_cpustate(CPUPPCState *state) { return state->gpr[1]; } This is no way related to CPU emulation then has nothing to do in cpu.h. Furthermore, there no notion of sigaltstack or even stack pointer in the PowerPC specification. Revert this patch immediatly, please, and stop breaking others code... How should we say "don't do weird things in others code" ??? Again, and again and again... ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... 2007-09-27 14:08 ` Jocelyn Mayer @ 2007-09-27 15:26 ` Thiemo Seufer 2007-09-27 15:53 ` Thayne Harbaugh 1 sibling, 0 replies; 6+ messages in thread From: Thiemo Seufer @ 2007-09-27 15:26 UTC (permalink / raw) To: Jocelyn Mayer; +Cc: qemu-devel Jocelyn Mayer wrote: > On Thu, 2007-09-27 at 13:57 +0000, Thiemo Seufer wrote: > > CVSROOT: /sources/qemu > > Module name: qemu > > Changes by: Thiemo Seufer <ths> 07/09/27 13:57:58 > > > > Modified files: > > linux-user : qemu.h signal.c syscall.c > > target-alpha : cpu.h > > target-arm : cpu.h > > target-i386 : cpu.h > > target-mips : cpu.h > > target-ppc : cpu.h > > static inline target_ulong get_sp_from_cpustate(CPUPPCState *state) > { > return state->gpr[1]; > } > > This is no way related to CPU emulation then has nothing to do in cpu.h. Agreed, it should be confined to the linux-user implementation. > Furthermore, there no notion of sigaltstack or even stack pointer in the > PowerPC specification. You would need to look in the Linux PPC ABI for that. Thiemo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... 2007-09-27 14:08 ` Jocelyn Mayer 2007-09-27 15:26 ` Thiemo Seufer @ 2007-09-27 15:53 ` Thayne Harbaugh 2007-09-27 16:41 ` Jocelyn Mayer 2007-09-27 16:47 ` Thiemo Seufer 1 sibling, 2 replies; 6+ messages in thread From: Thayne Harbaugh @ 2007-09-27 15:53 UTC (permalink / raw) To: qemu-devel On Thu, 2007-09-27 at 16:08 +0200, Jocelyn Mayer wrote: > On Thu, 2007-09-27 at 13:57 +0000, Thiemo Seufer wrote: > > CVSROOT: /sources/qemu > > Module name: qemu > > Changes by: Thiemo Seufer <ths> 07/09/27 13:57:58 > > > > Modified files: > > linux-user : qemu.h signal.c syscall.c > > target-alpha : cpu.h > > target-arm : cpu.h > > target-i386 : cpu.h > > target-mips : cpu.h > > target-ppc : cpu.h > > static inline target_ulong get_sp_from_cpustate(CPUPPCState *state) > { > return state->gpr[1]; > } > > This is no way related to CPU emulation then has nothing to do in cpu.h. > Furthermore, there no notion of sigaltstack or even stack pointer in the > PowerPC specification. > Revert this patch immediatly, please, and stop breaking others code... My apologies. I put get_sp_from_cpustate() in cpu.h because it is a generic function that isn't exclusive to sigaltstack(). If it's preferred it can be exclusive to sigaltstack(). > How should we say "don't do weird things in others code" ??? Again, and > again and again... My hope was that these types of comments would be made prior to the patch being committed. Is there a developer document that describes the intentions of code layout, design philosophy, etc. so that I'm not guessing? Please send me additional comments so that I can rework the patch for resubmission. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... 2007-09-27 15:53 ` Thayne Harbaugh @ 2007-09-27 16:41 ` Jocelyn Mayer 2007-09-27 16:47 ` Thiemo Seufer 1 sibling, 0 replies; 6+ messages in thread From: Jocelyn Mayer @ 2007-09-27 16:41 UTC (permalink / raw) To: thayne, qemu-devel On Thu, 2007-09-27 at 09:53 -0600, Thayne Harbaugh wrote: > On Thu, 2007-09-27 at 16:08 +0200, Jocelyn Mayer wrote: > > On Thu, 2007-09-27 at 13:57 +0000, Thiemo Seufer wrote: > > > CVSROOT: /sources/qemu > > > Module name: qemu > > > Changes by: Thiemo Seufer <ths> 07/09/27 13:57:58 > > > > > > Modified files: > > > linux-user : qemu.h signal.c syscall.c > > > target-alpha : cpu.h > > > target-arm : cpu.h > > > target-i386 : cpu.h > > > target-mips : cpu.h > > > target-ppc : cpu.h > > > > static inline target_ulong get_sp_from_cpustate(CPUPPCState *state) > > { > > return state->gpr[1]; > > } > > > > This is no way related to CPU emulation then has nothing to do in cpu.h. > > Furthermore, there no notion of sigaltstack or even stack pointer in the > > PowerPC specification. > > Revert this patch immediatly, please, and stop breaking others code... > > My apologies. I put get_sp_from_cpustate() in cpu.h because it is a > generic function that isn't exclusive to sigaltstack(). If it's > preferred it can be exclusive to sigaltstack(). > > > How should we say "don't do weird things in others code" ??? Again, and > > again and again... > > My hope was that these types of comments would be made prior to the > patch being committed. Is there a developer document that describes the > intentions of code layout, design philosophy, etc. so that I'm not > guessing? Then, I'm sorry, I did not notice this when you submitted your patch. And I even did not imagine that it could touch anything out of linux-user. Please apologize, I've been reading your submission too fast, not being directly interressed by the patch... > Please send me additional comments so that I can rework the patch for > resubmission. I don't know in which header you should define those ABI specific stuff. Maybe a header may be added in the linux-user target subdirectories for those kind of definitions; it may help avoiding too many #ifdef everywhere... ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... 2007-09-27 15:53 ` Thayne Harbaugh 2007-09-27 16:41 ` Jocelyn Mayer @ 2007-09-27 16:47 ` Thiemo Seufer 1 sibling, 0 replies; 6+ messages in thread From: Thiemo Seufer @ 2007-09-27 16:47 UTC (permalink / raw) To: Thayne Harbaugh; +Cc: qemu-devel Thayne Harbaugh wrote: [snip] > > static inline target_ulong get_sp_from_cpustate(CPUPPCState *state) > > { > > return state->gpr[1]; > > } > > > > This is no way related to CPU emulation then has nothing to do in cpu.h. > > Furthermore, there no notion of sigaltstack or even stack pointer in the > > PowerPC specification. > > Revert this patch immediatly, please, and stop breaking others code... > > My apologies. I put get_sp_from_cpustate() in cpu.h because it is a > generic function that isn't exclusive to sigaltstack(). If it's > preferred it can be exclusive to sigaltstack(). I moved it over to target_signal.h, which seems to be the best place for the time being. I also enabled do_sigaltstack processing for MIPS, PPC and Alpha, as I don't see a reason not to support it. Thiemo ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-09-27 16:47 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-09-27 13:57 [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu Thiemo Seufer 2007-09-27 14:08 ` Jocelyn Mayer 2007-09-27 15:26 ` Thiemo Seufer 2007-09-27 15:53 ` Thayne Harbaugh 2007-09-27 16:41 ` Jocelyn Mayer 2007-09-27 16:47 ` Thiemo Seufer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.