From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, rdreier@cisco.com,
shemminger@linux-foundation.org, davem@davemloft.net,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
Date: Tue, 16 Oct 2007 17:37:03 +1000 [thread overview]
Message-ID: <1192520223.7205.5.camel@pasglop> (raw)
In-Reply-To: <E1IhfZr-0002FE-00@gondolin.me.apana.org.au>
On Tue, 2007-10-16 at 14:06 +0800, Herbert Xu wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Note: I use msleep_interruptible(1); just like napi_disable(). However
> > I'm not too happy that the "hot" loop that results of a pending signal
> > here will spin without even a cpu_relax ... what do you guys think would
> > be the best way to handle this ?
>
> Well since the loop does not check signals at all, it should
> just use msleep.
>
> Granted the process will end up in the D state and contribute
> to the load average. But if this loop executes long enough
> for that to be noticed then we've got bigger problems to worry
> about.
If Dave & Stephen agree, I'll send a patch changing napi_disable() too
then.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
davem@davemloft.net, rdreier@cisco.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
Date: Tue, 16 Oct 2007 17:37:03 +1000 [thread overview]
Message-ID: <1192520223.7205.5.camel@pasglop> (raw)
In-Reply-To: <E1IhfZr-0002FE-00@gondolin.me.apana.org.au>
On Tue, 2007-10-16 at 14:06 +0800, Herbert Xu wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Note: I use msleep_interruptible(1); just like napi_disable(). However
> > I'm not too happy that the "hot" loop that results of a pending signal
> > here will spin without even a cpu_relax ... what do you guys think would
> > be the best way to handle this ?
>
> Well since the loop does not check signals at all, it should
> just use msleep.
>
> Granted the process will end up in the D state and contribute
> to the load average. But if this loop executes long enough
> for that to be noticed then we've got bigger problems to worry
> about.
If Dave & Stephen agree, I'll send a patch changing napi_disable() too
then.
Cheers,
Ben.
next prev parent reply other threads:[~2007-10-16 7:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:49 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
2007-10-16 5:49 ` Benjamin Herrenschmidt
2007-10-16 6:06 ` Herbert Xu
2007-10-16 6:06 ` Herbert Xu
2007-10-16 7:37 ` Benjamin Herrenschmidt [this message]
2007-10-16 7:37 ` Benjamin Herrenschmidt
2007-10-16 7:44 ` David Miller
2007-10-16 7:44 ` David Miller
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-17 2:50 ` Benjamin Herrenschmidt
2007-10-17 2:50 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 21:52 ` Benjamin Herrenschmidt
2007-10-17 22:04 ` [PATCH] net: Add napi_sycnhronize() " Benjamin Herrenschmidt
2007-10-17 22:04 ` Benjamin Herrenschmidt
2007-10-17 23:36 ` Josh Boyer
2007-10-17 23:36 ` Josh Boyer
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-17 23:14 ` [PATCH] fix EMAC driver for proper napi_synchronize API Benjamin Herrenschmidt
2007-10-17 23:14 ` Benjamin Herrenschmidt
2007-10-18 0:21 ` Jeff Garzik
2007-10-18 0:21 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-10-16 5:40 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
2007-10-16 5:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192520223.7205.5.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.