From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
Date: Wed, 17 Oct 2007 12:50:12 +1000 [thread overview]
Message-ID: <1192589412.11899.127.camel@pasglop> (raw)
In-Reply-To: <20071016115318.0fc36af3@freepuppy.rosehill>
napi: use non-interruptible sleep in napi_disable
The current napi_disable() uses msleep_interruptible() but doesn't
(and can't) exit in case there's a signal, thus ending up doing a
hot spin without a cpu_relax. Use uninterruptible sleep instead.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/include/linux/netdevice.h
===================================================================
--- linux-work.orig/include/linux/netdevice.h 2007-10-17 12:39:16.000000000 +1000
+++ linux-work/include/linux/netdevice.h 2007-10-17 12:45:00.000000000 +1000
@@ -390,7 +390,7 @@ static inline void napi_complete(struct
static inline void napi_disable(struct napi_struct *n)
{
while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
- msleep_interruptible(1);
+ msleep(1);
}
/**
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Roland Dreier <rdreier@cisco.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
Date: Wed, 17 Oct 2007 12:50:12 +1000 [thread overview]
Message-ID: <1192589412.11899.127.camel@pasglop> (raw)
In-Reply-To: <20071016115318.0fc36af3@freepuppy.rosehill>
napi: use non-interruptible sleep in napi_disable
The current napi_disable() uses msleep_interruptible() but doesn't
(and can't) exit in case there's a signal, thus ending up doing a
hot spin without a cpu_relax. Use uninterruptible sleep instead.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/include/linux/netdevice.h
===================================================================
--- linux-work.orig/include/linux/netdevice.h 2007-10-17 12:39:16.000000000 +1000
+++ linux-work/include/linux/netdevice.h 2007-10-17 12:45:00.000000000 +1000
@@ -390,7 +390,7 @@ static inline void napi_complete(struct
static inline void napi_disable(struct napi_struct *n)
{
while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
- msleep_interruptible(1);
+ msleep(1);
}
/**
next prev parent reply other threads:[~2007-10-17 2:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:49 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
2007-10-16 5:49 ` Benjamin Herrenschmidt
2007-10-16 6:06 ` Herbert Xu
2007-10-16 6:06 ` Herbert Xu
2007-10-16 7:37 ` Benjamin Herrenschmidt
2007-10-16 7:37 ` Benjamin Herrenschmidt
2007-10-16 7:44 ` David Miller
2007-10-16 7:44 ` David Miller
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-17 2:50 ` Benjamin Herrenschmidt [this message]
2007-10-17 2:50 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 21:52 ` Benjamin Herrenschmidt
2007-10-17 22:04 ` [PATCH] net: Add napi_sycnhronize() " Benjamin Herrenschmidt
2007-10-17 22:04 ` Benjamin Herrenschmidt
2007-10-17 23:36 ` Josh Boyer
2007-10-17 23:36 ` Josh Boyer
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-17 23:14 ` [PATCH] fix EMAC driver for proper napi_synchronize API Benjamin Herrenschmidt
2007-10-17 23:14 ` Benjamin Herrenschmidt
2007-10-18 0:21 ` Jeff Garzik
2007-10-18 0:21 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-10-16 5:40 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
2007-10-16 5:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192589412.11899.127.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.