From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [PATCH] kern/err.c + disk/raid.c error handling fixes
Date: Tue, 12 Aug 2008 18:28:07 +0200 [thread overview]
Message-ID: <1218558487.19045.8.camel@fz.local> (raw)
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
As requested by Robert on IRC
here are now my 2 little recent patches merged into one
2008-08-12 Felix Zielcke <fzielcke@z-51.de>
* kern/err.c [GRUB_UTIL]: Include <stdio.h>.
[GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead of
grub_printf.
* disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID
errors and reset grub_errno. Do not give errors to the upper layer.
[-- Attachment #2: kern_err.diff --]
[-- Type: text/x-patch, Size: 572 bytes --]
Index: kern/err.c
===================================================================
--- kern/err.c (revision 1800)
+++ kern/err.c (working copy)
@@ -21,6 +21,9 @@
#include <grub/misc.h>
#include <stdarg.h>
+#ifdef GRUB_UTIL
+#include <stdio.h>
+#endif
#define GRUB_MAX_ERRMSG 256
#define GRUB_ERROR_STACK_SIZE 10
@@ -121,7 +124,11 @@
do
{
if (grub_errno != GRUB_ERR_NONE)
+#ifdef GRUB_UTIL
+ fprintf (stderr, "error: %s\n", grub_errmsg);
+#else
grub_printf ("error: %s\n", grub_errmsg);
+#endif
}
while (grub_error_pop ());
next reply other threads:[~2008-08-12 16:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 16:28 Felix Zielcke [this message]
2008-08-12 16:32 ` [PATCH] kern/err.c + disk/raid.c error handling fixes Felix Zielcke
2008-08-12 21:42 ` Marco Gerards
2008-08-12 22:40 ` Robert Millan
2008-08-13 5:56 ` Felix Zielcke
2008-08-13 9:47 ` Marco Gerards
2008-08-13 20:31 ` Felix Zielcke
2008-08-13 20:38 ` Felix Zielcke
2008-08-13 21:50 ` Robert Millan
2008-08-13 22:39 ` Felix Zielcke
2008-08-13 23:30 ` Felix Zielcke
2008-08-14 7:13 ` Marco Gerards
2008-08-14 11:02 ` Felix Zielcke
2008-08-14 18:08 ` Robert Millan
2008-08-14 18:16 ` Vesa Jääskeläinen
2008-08-14 18:27 ` Marco Gerards
2008-08-14 18:48 ` Felix Zielcke
2008-08-13 23:32 ` Robert Millan
2008-08-13 9:40 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218558487.19045.8.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.